This is an archive of the discontinued LLVM Phabricator instance.

Add more historic DWARF vendor extensions
ClosedPublic

Authored by aprantl on Feb 22 2021, 5:25 PM.

Details

Summary

David Anderson, the maintainer of libdwarf kindly provided this patch with a bunch of historic DWARF extensions that are missing from Dwarf.def. To avoid the potential for conflicts in the user-defined vendor extension space I think these would be very useful to add.

Diff Detail

Event Timeline

aprantl requested review of this revision.Feb 22 2021, 5:25 PM
aprantl created this revision.
echristo accepted this revision.Feb 22 2021, 7:35 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Feb 22 2021, 7:35 PM
probinson accepted this revision.Feb 23 2021, 8:28 AM

A few typos. Nice to have these!

Dwarf.def
434 ↗(On Diff #325624)

9x2005?

528 ↗(On Diff #325624)

Three blank lines seems a bit much?

829 ↗(On Diff #325624)

// Conflicts with GNU_push_tls_address

This revision was automatically updated to reflect the committed changes.
aprantl marked 2 inline comments as done.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 23 2021, 5:54 PM
Herald added a subscriber: aheejin. · View Herald Transcript
thakis added a subscriber: thakis.Feb 23 2021, 6:32 PM

This breaks check-llvm: http://45.33.8.238/linux/40166/step_12.txt

PTAL, and revert for now if it takes a while to fix.

(breaks check-llvm more on windows: http://45.33.8.238/win/33808/step_11.txt)

Also fails locally for me in a normal cmake build. Reverted for now in f14a14dd2564703db02f80c00db8ae492b594f77.

Please run tests before committing.

Please run tests before committing.

Yeah, it was hopelessly optimistic of me to just run check-llvm-debuginfo check-llvm-tools. Recommitted after passing check-llvm check-clang!