Allow the attributor to delete functions only if requested
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/test/Transforms/Attributor/nodelete.ll | ||
|---|---|---|
| 2 | Maybe generate this with update_test_checks.py? I guess it would be easier to update and also for consistency. | |
| llvm/test/Transforms/Attributor/nodelete.ll | ||
|---|---|---|
| 2 | I missed this. Use the same run lines as other tests and the update test script please. | |
| llvm/test/Transforms/Attributor/nodelete.ll | ||
|---|---|---|
| 2 | Using the same line as others reveals a similar issue for non cgss mode. Is it preferable to leave those tests disabled for the moment (like below) or to also disable function removal for that mode? | |
| llvm/test/Transforms/Attributor/nodelete.ll | ||
|---|---|---|
| 2 | I guess we should do that while we are at it. | |
Nit: .