Page MenuHomePhabricator

[OpenMP][NFC] clang-format the whole openmp project
ClosedPublic

Authored by tianshilei1992 on Feb 19 2021, 2:10 PM.

Details

Diff Detail

Event Timeline

tianshilei1992 created this revision.Feb 19 2021, 2:10 PM
tianshilei1992 requested review of this revision.Feb 19 2021, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2021, 2:10 PM
tianshilei1992 added inline comments.Feb 19 2021, 2:21 PM
openmp/libomptarget/deviceRTLs/interface.h
182–183

The latest version of clang-format can surprisingly handle this type of comments so well!

openmp/runtime/doc/doxygen/libomp_interface.h
4

This file should be filtered out.

openmp/runtime/src/thirdparty/ittnotify/disable_warnings.h
15

The tailing \ is unnecessary. Probably because clang-format takes it part of the pragma.

openmp/runtime/src/thirdparty/ittnotify/ittnotify_static.cpp
1049–1052

Here as well

I scrolled through all of it. 3 nits. LGTM otherwise, wait for @AndreyChurbanov though.

openmp/runtime/src/thirdparty/ittnotify/ittnotify.h
483

This needs to be fixed. Change the comment style or sth

780

same.

868

same.

tianshilei1992 marked 2 inline comments as done.

Fixed comments

tianshilei1992 marked an inline comment as done.Feb 19 2021, 6:34 PM
This revision is now accepted and ready to land.Feb 20 2021, 9:44 AM
This revision was landed with ongoing or failed builds.Feb 20 2021, 9:46 AM
This revision was automatically updated to reflect the committed changes.