This is an archive of the discontinued LLVM Phabricator instance.

Differential D96892

[OpenMP] libomp: cleanup some resource leaks
ClosedPublic

Authored by AndreyChurbanov on Feb 17 2021, 1:05 PM.

Details

Reviewers
hbae
jlpeyton
tlwilmar
Nawrin
jdoerfert
Commits
rG1611e5473c5e: [OpenMP] libomp: cleanup some resource leaks
Summary

Close mutexattr and condattr local objects to eliminate resource leaks.

Diff Detail

Event Timeline

AndreyChurbanov created this revision.Feb 17 2021, 1:05 PM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptFeb 17 2021, 1:05 PM
AndreyChurbanov requested review of this revision.Feb 17 2021, 1:05 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptFeb 17 2021, 1:05 PM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B89600: Diff 324399.Feb 17 2021, 2:29 PM
Nawrin accepted this revision.Feb 19 2021, 3:22 PM

LGTM

This revision is now accepted and ready to land.Feb 19 2021, 3:22 PM
Closed by commit rG1611e5473c5e: [OpenMP] libomp: cleanup some resource leaks (authored by AndreyChurbanov). · Explain WhyFeb 20 2021, 12:28 PM
This revision was automatically updated to reflect the committed changes.
AndreyChurbanov added a commit: rG1611e5473c5e: [OpenMP] libomp: cleanup some resource leaks.

Revision Contents

PathSize
openmp/
runtime/
src/
4 lines

Diff 325230

openmp/runtime/src/z_Linux_util.cpp

Show First 20 Lines • Show All 1,903 Lines • ▼ Show 20 Lines#endif /* KMP_32_BIT_ARCH */
status = pthread_key_create(&__kmp_gtid_threadprivate_key, status = pthread_key_create(&__kmp_gtid_threadprivate_key,
__kmp_internal_end_dest); __kmp_internal_end_dest);
KMP_CHECK_SYSFAIL("pthread_key_create", status); KMP_CHECK_SYSFAIL("pthread_key_create", status);
status = pthread_mutexattr_init(&mutex_attr); status = pthread_mutexattr_init(&mutex_attr);
KMP_CHECK_SYSFAIL("pthread_mutexattr_init", status); KMP_CHECK_SYSFAIL("pthread_mutexattr_init", status);
status = pthread_mutex_init(&__kmp_wait_mx.m_mutex, &mutex_attr); status = pthread_mutex_init(&__kmp_wait_mx.m_mutex, &mutex_attr);
KMP_CHECK_SYSFAIL("pthread_mutex_init", status); KMP_CHECK_SYSFAIL("pthread_mutex_init", status);
status = pthread_mutexattr_destroy(&mutex_attr);
KMP_CHECK_SYSFAIL("pthread_mutexattr_destroy", status);
status = pthread_condattr_init(&cond_attr); status = pthread_condattr_init(&cond_attr);
KMP_CHECK_SYSFAIL("pthread_condattr_init", status); KMP_CHECK_SYSFAIL("pthread_condattr_init", status);
status = pthread_cond_init(&__kmp_wait_cv.c_cond, &cond_attr); status = pthread_cond_init(&__kmp_wait_cv.c_cond, &cond_attr);
KMP_CHECK_SYSFAIL("pthread_cond_init", status); KMP_CHECK_SYSFAIL("pthread_cond_init", status);
status = pthread_condattr_destroy(&cond_attr);
KMP_CHECK_SYSFAIL("pthread_condattr_destroy", status);
#if USE_ITT_BUILD #if USE_ITT_BUILD
__kmp_itt_initialize(); __kmp_itt_initialize();
#endif /* USE_ITT_BUILD */ #endif /* USE_ITT_BUILD */
__kmp_init_runtime = TRUE; __kmp_init_runtime = TRUE;
} }
void __kmp_runtime_destroy(void) { void __kmp_runtime_destroy(void) {
▲ Show 20 Lines • Show All 767 Lines • Show Last 20 Lines