This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Move command handlers into a map in ClangdLSPServer. NFC
ClosedPublic

Authored by sammccall on Feb 11 2021, 7:32 AM.

Diff Detail

Event Timeline

sammccall created this revision.Feb 11 2021, 7:32 AM
sammccall requested review of this revision.Feb 11 2021, 7:32 AM
kadircet accepted this revision.Feb 11 2021, 10:26 AM

thanks, lgtm!

clang-tools-extra/clangd/ClangdLSPServer.cpp
587

nit: llvm::append_range(Commands, CommandHandlers.keys())

649

nit: std::move(Commands)

clang-tools-extra/clangd/Protocol.h
918

can we also move these into ClangdLSPServer now ?

This revision is now accepted and ready to land.Feb 11 2021, 10:26 AM
This revision was landed with ongoing or failed builds.Feb 12 2021, 6:57 AM
This revision was automatically updated to reflect the committed changes.
sammccall marked 3 inline comments as done.
thakis added a subscriber: thakis.Feb 12 2021, 8:55 AM

Looks like this doesn't build on Windows: http://45.33.8.238/win/33161/step_4.txt (clang-cl + msvc stdlib)