This is an archive of the discontinued LLVM Phabricator instance.

Differential D96389

[analyzer] Update static analyzer to be support sarif-html
ClosedPublic

Authored by isthismyaccount on Feb 9 2021, 5:37 PM.

Details

Reviewers
aabbaabb
jansvoboda11
NoQ
vsavchenko
Szelethus
Commits
rG2407eb08a574: [analyzer] Update static analyzer to be support sarif-html
Summary

Updates static analyzer to be able to generate both sarif and html output in a single run similar to plist-html.

Diff Detail

Event Timeline

isthismyaccount created this revision.Feb 9 2021, 5:37 PM
Herald added a reviewer: jansvoboda11. · View Herald TranscriptFeb 9 2021, 5:37 PM
Herald added subscribers: nullptr.cpp, steakhal, dang and 11 others. · View Herald Transcript
isthismyaccount requested review of this revision.Feb 9 2021, 5:37 PM
Charusso added reviewers: NoQ, vsavchenko.Feb 9 2021, 5:44 PM
vsavchenko added inline comments.Feb 9 2021, 10:28 PM
clang/include/clang/StaticAnalyzer/Core/Analyses.def
58

I think we should put a better explanation here :-)

isthismyaccount updated this revision to Diff 322717.Feb 10 2021, 9:52 AM

Whoops, haha...

clang/include/clang/StaticAnalyzer/Core/Analyses.def
58

Whoops. Thanks!

vsavchenko added inline comments.Feb 10 2021, 9:56 AM
clang/include/clang/StaticAnalyzer/Core/Analyses.def
59

Sorry for complaining about it again, it'd be more consistent with other descriptions to replace it with "using".

Szelethus added inline comments.Feb 10 2021, 10:05 AM
clang/include/clang/StaticAnalyzer/Core/Analyses.def
59

[...] SARIF and HTML output files.

isthismyaccount updated this revision to Diff 322756.Feb 10 2021, 10:57 AM

Update help message.

isthismyaccount marked 2 inline comments as done.Feb 10 2021, 10:57 AM
vsavchenko accepted this revision.Feb 10 2021, 10:58 AM

LGTM

This revision is now accepted and ready to land.Feb 10 2021, 10:58 AM
Szelethus accepted this revision.Feb 10 2021, 4:30 PM
Closed by commit rG2407eb08a574: [analyzer] Update static analyzer to be support sarif-html (authored by Daniel Hwang <arkay@google.com>, committed by haowei). · Explain WhyFeb 10 2021, 6:35 PM
This revision was automatically updated to reflect the committed changes.
haowei added a commit: rG2407eb08a574: [analyzer] Update static analyzer to be support sarif-html.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2021, 6:35 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
isthismyaccount mentioned this in D96570: [scan-build-py] Add sarif-html support in scan-build-py.Feb 11 2021, 7:25 PM
charco mentioned this in rG97a304cc8f94: [scan-build-py] Add sarif-html support in scan-build-py.Feb 23 2021, 2:42 PM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
2 lines
StaticAnalyzer/
Core/
4 lines
lib/
StaticAnalyzer/
Core/
10 lines

Diff 322717

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 3,661 Lines • ▼ Show 20 Lines
def _mhwdiv_EQ : Joined<["--"], "mhwdiv=">, Alias<mhwdiv_EQ>; def _mhwdiv_EQ : Joined<["--"], "mhwdiv=">, Alias<mhwdiv_EQ>;
def _mhwdiv : Separate<["--"], "mhwdiv">, Alias<mhwdiv_EQ>; def _mhwdiv : Separate<["--"], "mhwdiv">, Alias<mhwdiv_EQ>;
def _CLASSPATH_EQ : Joined<["--"], "CLASSPATH=">, Alias<fclasspath_EQ>; def _CLASSPATH_EQ : Joined<["--"], "CLASSPATH=">, Alias<fclasspath_EQ>;
def _CLASSPATH : Separate<["--"], "CLASSPATH">, Alias<fclasspath_EQ>; def _CLASSPATH : Separate<["--"], "CLASSPATH">, Alias<fclasspath_EQ>;
def _all_warnings : Flag<["--"], "all-warnings">, Alias<Wall>; def _all_warnings : Flag<["--"], "all-warnings">, Alias<Wall>;
def _analyzer_no_default_checks : Flag<["--"], "analyzer-no-default-checks">, Flags<[NoXarchOption]>; def _analyzer_no_default_checks : Flag<["--"], "analyzer-no-default-checks">, Flags<[NoXarchOption]>;
def _analyzer_output : JoinedOrSeparate<["--"], "analyzer-output">, Flags<[NoXarchOption]>, def _analyzer_output : JoinedOrSeparate<["--"], "analyzer-output">, Flags<[NoXarchOption]>,
HelpText<"Static analyzer report output format (html|plist|plist-multi-file|plist-html|sarif|text).">; HelpText<"Static analyzer report output format (html|plist|plist-multi-file|plist-html|sarif|sarif-html|text).">;
def _analyze : Flag<["--"], "analyze">, Flags<[NoXarchOption, CoreOption]>, def _analyze : Flag<["--"], "analyze">, Flags<[NoXarchOption, CoreOption]>,
HelpText<"Run the static analyzer">; HelpText<"Run the static analyzer">;
def _assemble : Flag<["--"], "assemble">, Alias<S>; def _assemble : Flag<["--"], "assemble">, Alias<S>;
def _assert_EQ : Joined<["--"], "assert=">, Alias<A>; def _assert_EQ : Joined<["--"], "assert=">, Alias<A>;
def _assert : Separate<["--"], "assert">, Alias<A>; def _assert : Separate<["--"], "assert">, Alias<A>;
def _bootclasspath_EQ : Joined<["--"], "bootclasspath=">, Alias<fbootclasspath_EQ>; def _bootclasspath_EQ : Joined<["--"], "bootclasspath=">, Alias<fbootclasspath_EQ>;
def _bootclasspath : Separate<["--"], "bootclasspath">, Alias<fbootclasspath_EQ>; def _bootclasspath : Separate<["--"], "bootclasspath">, Alias<fbootclasspath_EQ>;
def _classpath_EQ : Joined<["--"], "classpath=">, Alias<fclasspath_EQ>; def _classpath_EQ : Joined<["--"], "classpath=">, Alias<fclasspath_EQ>;
▲ Show 20 Lines • Show All 2,256 Lines • Show Last 20 Lines

clang/include/clang/StaticAnalyzer/Core/Analyses.def

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
ANALYSIS_DIAGNOSTICS(PLIST_HTML, "plist-html", ANALYSIS_DIAGNOSTICS(PLIST_HTML, "plist-html",
"Output analysis results using HTML wrapped with Plists", "Output analysis results using HTML wrapped with Plists",
createPlistHTMLDiagnosticConsumer) createPlistHTMLDiagnosticConsumer)
ANALYSIS_DIAGNOSTICS(SARIF, "sarif", "Output analysis results in a SARIF file", ANALYSIS_DIAGNOSTICS(SARIF, "sarif", "Output analysis results in a SARIF file",
createSarifDiagnosticConsumer) createSarifDiagnosticConsumer)
ANALYSIS_DIAGNOSTICS(SARIF_HTML, "sarif-html",
vsavchenkoUnsubmitted
Not Done
ReplyInline Actions

I think we should put a better explanation here :-)

vsavchenko: I think we should put a better explanation here :-)
isthismyaccountAuthorUnsubmitted
Done
ReplyInline Actions

Whoops. Thanks!

isthismyaccount: Whoops. Thanks!
"Output analysis results in both SARIF and HTML.",
vsavchenkoUnsubmitted
Done
ReplyInline Actions

Sorry for complaining about it again, it'd be more consistent with other descriptions to replace it with "using".

vsavchenko: Sorry for complaining about it again, it'd be more consistent with other descriptions to…
SzelethusUnsubmitted
Done
ReplyInline Actions

[...] SARIF and HTML output files.

Szelethus: `[...] SARIF and HTML output files.`
createSarifHTMLDiagnosticConsumer)
ANALYSIS_DIAGNOSTICS(TEXT, "text", "Text output of analysis results to stderr", ANALYSIS_DIAGNOSTICS(TEXT, "text", "Text output of analysis results to stderr",
createTextPathDiagnosticConsumer) createTextPathDiagnosticConsumer)
ANALYSIS_DIAGNOSTICS(TEXT_MINIMAL, "text-minimal", ANALYSIS_DIAGNOSTICS(TEXT_MINIMAL, "text-minimal",
"Emits minimal diagnostics to stderr, stating only the " "Emits minimal diagnostics to stderr, stating only the "
"warning message and the associated notes. Usually " "warning message and the associated notes. Usually "
"used in addition to other analysis types", "used in addition to other analysis types",
createTextMinimalPathDiagnosticConsumer) createTextMinimalPathDiagnosticConsumer)
Show All 32 Lines

clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp

Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Linesvoid ento::createPlistHTMLDiagnosticConsumer(
createHTMLDiagnosticConsumer( createHTMLDiagnosticConsumer(
DiagOpts, C, std::string(llvm::sys::path::parent_path(prefix)), PP, DiagOpts, C, std::string(llvm::sys::path::parent_path(prefix)), PP,
CTU); CTU);
createPlistMultiFileDiagnosticConsumer(DiagOpts, C, prefix, PP, CTU); createPlistMultiFileDiagnosticConsumer(DiagOpts, C, prefix, PP, CTU);
createTextMinimalPathDiagnosticConsumer(std::move(DiagOpts), C, prefix, PP, createTextMinimalPathDiagnosticConsumer(std::move(DiagOpts), C, prefix, PP,
CTU); CTU);
} }
void ento::createSarifHTMLDiagnosticConsumer(
PathDiagnosticConsumerOptions DiagOpts, PathDiagnosticConsumers &C,
const std::string &sarif_file, const Preprocessor &PP,
const cross_tu::CrossTranslationUnitContext &CTU) {
createHTMLDiagnosticConsumer(DiagOpts, C, std::string(llvm::sys::path::parent_path(sarif_file)), PP, CTU);
createSarifDiagnosticConsumer(DiagOpts, C, sarif_file, PP, CTU);
createTextMinimalPathDiagnosticConsumer(std::move(DiagOpts), C, sarif_file, PP,
CTU);
}
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Report processing. // Report processing.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
void HTMLDiagnostics::FlushDiagnosticsImpl( void HTMLDiagnostics::FlushDiagnosticsImpl(
std::vector<const PathDiagnostic *> &Diags, std::vector<const PathDiagnostic *> &Diags,
FilesMade *filesMade) { FilesMade *filesMade) {
for (const auto Diag : Diags) for (const auto Diag : Diags)
▲ Show 20 Lines • Show All 966 Lines • Show Last 20 Lines