Details
Details
Diff Detail
Diff Detail
Event Timeline
llvm/include/llvm/CodeGen/ValueTypes.td | ||
---|---|---|
179 | typo here: x 2 -> x 1? |
Comment Actions
LGTM. I've always disliked how finicky adding a new MVT is but that's neither here nor there :)
Paths
| Differential D96249
[ValueTypes] Add MVT for nxv1bf16. ClosedPublic Authored by sdesmalen on Feb 8 2021, 1:55 AM.
Details
Diff Detail Event TimelineHerald added subscribers: dexonsmith, hiraditya, dschuff. · View Herald TranscriptFeb 8 2021, 1:55 AM
Comment Actions LGTM. I've always disliked how finicky adding a new MVT is but that's neither here nor there :) This revision is now accepted and ready to land.Feb 9 2021, 2:22 AM Closed by commit rG750a78cd5d4b: [ValueTypes] Add MVT for nxv1bf16. (authored by sdesmalen). · Explain WhyFeb 10 2021, 12:51 AM This revision was automatically updated to reflect the committed changes. Comment Actions
Yes, definitely not the most elegant part of LLVM :) Thanks for the review!
Revision Contents
Diff 322054 llvm/include/llvm/CodeGen/ValueTypes.td
llvm/include/llvm/Support/MachineValueType.h
llvm/lib/CodeGen/ValueTypes.cpp
|
typo here: x 2 -> x 1?