This is an archive of the discontinued LLVM Phabricator instance.

[ValueTypes] Add MVT for nxv1bf16.
ClosedPublic

Authored by sdesmalen on Feb 8 2021, 1:55 AM.

Diff Detail

Event Timeline

sdesmalen created this revision.Feb 8 2021, 1:55 AM
sdesmalen requested review of this revision.Feb 8 2021, 1:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2021, 1:55 AM
Herald added a subscriber: aheejin. · View Herald Transcript
frasercrmck added inline comments.Feb 8 2021, 1:57 AM
llvm/include/llvm/CodeGen/ValueTypes.td
179

typo here: x 2 -> x 1?

sdesmalen updated this revision to Diff 322059.Feb 8 2021, 2:35 AM

Fixed typo.

sdesmalen marked an inline comment as done.Feb 8 2021, 2:35 AM
frasercrmck accepted this revision.Feb 9 2021, 2:22 AM

LGTM. I've always disliked how finicky adding a new MVT is but that's neither here nor there :)

This revision is now accepted and ready to land.Feb 9 2021, 2:22 AM
This revision was automatically updated to reflect the committed changes.

LGTM. I've always disliked how finicky adding a new MVT is but that's neither here nor there :)

Yes, definitely not the most elegant part of LLVM :) Thanks for the review!