This is an archive of the discontinued LLVM Phabricator instance.

[ASTReader] Always rebuild a cached module that has errors
ClosedPublic

Authored by bnbarham on Feb 3 2021, 5:16 PM.

Details

Summary

A module in the cache with an error should just be a cache miss. If
allowing errors (with -fallow-pcm-with-compiler-errors), a rebuild is
needed so that the appropriate diagnostics are output and in case search
paths have changed. If not allowing errors, the module was built
*allowing* errors and thus should be rebuilt regardless.

Diff Detail

Event Timeline

bnbarham requested review of this revision.Feb 3 2021, 5:16 PM
bnbarham created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2021, 5:16 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
akyrtzi accepted this revision.Feb 3 2021, 8:35 PM
This revision is now accepted and ready to land.Feb 3 2021, 8:35 PM
bnbarham updated this revision to Diff 321305.Feb 3 2021, 8:58 PM

Added a couple semi-colons to the test file

bnbarham updated this revision to Diff 321308.Feb 3 2021, 9:06 PM
bnbarham set the repository for this revision to rG LLVM Github Monorepo.
This revision was landed with ongoing or failed builds.Feb 3 2021, 10:15 PM
This revision was automatically updated to reflect the committed changes.