Page MenuHomePhabricator

bnbarham (Ben Barham)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2020, 6:11 PM (35 w, 4 d)

Recent Activity

Apr 16 2021

bnbarham added inline comments to D100619: [ASTReader] Only mark module out of date if not already compiled.
Apr 16 2021, 3:23 PM · Restricted Project

Apr 15 2021

bnbarham requested review of D100619: [ASTReader] Only mark module out of date if not already compiled.
Apr 15 2021, 9:36 PM · Restricted Project

Feb 8 2021

bnbarham accepted D96246: Make sure a module file with errors produced via '-fallow-pcm-with-compiler-errors' can be loaded when using implicit modules.

LGTM

Feb 8 2021, 2:38 PM · Restricted Project

Feb 3 2021

bnbarham updated the diff for D95989: [ASTReader] Always rebuild a cached module that has errors.
Feb 3 2021, 9:06 PM · Restricted Project
bnbarham updated the diff for D95989: [ASTReader] Always rebuild a cached module that has errors.

Added a couple semi-colons to the test file

Feb 3 2021, 8:58 PM · Restricted Project
bnbarham requested review of D95989: [ASTReader] Always rebuild a cached module that has errors.
Feb 3 2021, 5:16 PM · Restricted Project

Jan 21 2021

bnbarham accepted D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file.

LGTM, just the one minor comment

Jan 21 2021, 2:08 PM · Restricted Project

Nov 17 2020

bnbarham updated the diff for D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.

Have allow-pcm also set allow-pch + test to make sure that works.

Nov 17 2020, 3:43 PM · Restricted Project

Nov 16 2020

bnbarham updated the diff for D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.

Noticed I had left in the -fdisable-module-hash flags in the test, removed now.

Nov 16 2020, 4:28 PM · Restricted Project
bnbarham requested review of D91580: [Frontend] Add flag to allow PCM generation despite compiler errors.
Nov 16 2020, 4:24 PM · Restricted Project

Oct 8 2020

bnbarham updated the diff for D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.

Removed platform-specific path separator

Oct 8 2020, 6:25 PM · Restricted Project

Oct 7 2020

bnbarham updated the diff for D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.

Update test to include explicit OSX target triple

Oct 7 2020, 9:07 PM · Restricted Project
bnbarham updated the diff for D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.

Ran clang-format again

Oct 7 2020, 8:30 PM · Restricted Project
bnbarham requested review of D89024: [AST] Fix crashes caused by redeclarations in hidden prototypes.
Oct 7 2020, 7:59 PM · Restricted Project