Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

bnbarham (Ben Barham)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2020, 6:11 PM (154 w, 4 d)

Recent Activity

Aug 22 2023

bnbarham added a comment to D148997: [clang] Add a new annotation token: annot_repl_input_end.

So, in that case we should bring back the boolean flag for incremental processing and keep the IncrementalExtensions LanguageOption separate. In that case IncrementalExtensions would mean that we must turn on incremental processing for managing lifetime and only use the language option when extending the parsing logic. However, I think the problem would be what to do with the tok::eof and tok::annot_repl_input_end? I'd probably need @aaron.ballman or @rsmith here...

Aug 22 2023, 12:23 PM · Restricted Project, Restricted Project

Aug 17 2023

bnbarham added inline comments to D142560: Allow getRawCommentForDecl to find comments in macros.
Aug 17 2023, 9:28 PM · Restricted Project, Restricted Project

Aug 4 2023

bnbarham added a comment to D148997: [clang] Add a new annotation token: annot_repl_input_end.

My other concern here is that it seems our use cases are somewhat different, eg. we wouldn't want any parsing differences and while I don't know why this is yet, the removal of:

I think I understand now. We basically want a mode which keeps some of the clang objects alive and ready to process more input. And on top, for clang-repl we want to enable some special parsing mode for the top-level statement declarations.

Aug 4 2023, 12:34 PM · Restricted Project, Restricted Project
bnbarham added a comment to D148997: [clang] Add a new annotation token: annot_repl_input_end.

https://github.com/llvm/llvm-project/blob/df6b35e329ebecad6dc3bfb83183e482eb7a0020/clang/lib/Parse/ParseExprCXX.cpp#L4070

That looks a bit obscure to me. Looks like we are trying to reach some error recovery anchor but do you happen to have some use case at hand? In principle we could do the same as for the other 3.

This was just one I picked at random from my grep over the parser. It's unclear how often this would be hit, but I have to assume it (and the other references) can, even if they're obscure/unlikely. My main point is that !eof is being used somewhat frequently to end loops, but with this change they will now all never end.

Since eof there were several eof-like tokens that were added: annot_module_begin, annot_module_end, tok::annot_module_include which are commonly handled in isEofOrEom. We could update these uses with isEofOrEom but I am pretty sure that @rsmith will point out cases where that's not a good very good idea :) We could either experiment with using isEofOrEom or have a similar utility function only for the two tokens (say isEoI -- end of input whatever that means).

Aug 4 2023, 12:08 PM · Restricted Project, Restricted Project
bnbarham added a comment to D148997: [clang] Add a new annotation token: annot_repl_input_end.

I meant that I'd like to figure out if we could use the annot_repl_input_end before considering a new flag.

Aug 4 2023, 9:27 AM · Restricted Project, Restricted Project
bnbarham added a comment to D148997: [clang] Add a new annotation token: annot_repl_input_end.

I'd prefer to avoid adding a new flag. Is there a way to see how does the diff looks like?

Aug 4 2023, 9:11 AM · Restricted Project, Restricted Project

Aug 3 2023

bnbarham added a comment to D148997: [clang] Add a new annotation token: annot_repl_input_end.

Are there other users of incremental processing mode, other than the REPL / IncrementalParser?

Aug 3 2023, 9:24 PM · Restricted Project, Restricted Project

Jun 30 2023

bnbarham committed rGa57bdc8fe687: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test (authored by hamishknight).
[clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test
Jun 30 2023, 4:03 PM · Restricted Project, Restricted Project
bnbarham closed D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test.
Jun 30 2023, 4:03 PM · Restricted Project, Restricted Project
bnbarham accepted D154257: [clang] Fix leak in LoadFromCommandLineWorkingDirectory unit test.
Jun 30 2023, 1:52 PM · Restricted Project, Restricted Project
bnbarham committed rG62e4c22c95a9: [clang] Fix ASTUnit working directory handling (authored by hamishknight).
[clang] Fix ASTUnit working directory handling
Jun 30 2023, 9:57 AM · Restricted Project, Restricted Project
bnbarham closed D154134: [clang] Fix ASTUnit working directory handling.
Jun 30 2023, 9:57 AM · Restricted Project, Restricted Project

Jun 29 2023

bnbarham accepted D154134: [clang] Fix ASTUnit working directory handling.
Jun 29 2023, 1:08 PM · Restricted Project, Restricted Project

May 30 2023

bnbarham accepted D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile.
May 30 2023, 5:21 PM · Restricted Project, Restricted Project

May 16 2023

bnbarham accepted D150492: [AST] Initialize local counter.
May 16 2023, 4:44 PM · Restricted Project, Restricted Project

Mar 24 2023

bnbarham added a comment to D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.

I have decided against doing that, because we can't specify @LINE in the c-index-test command line.

Mar 24 2023, 10:53 AM · Restricted Project, Restricted Project
bnbarham accepted D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.
Mar 24 2023, 10:35 AM · Restricted Project, Restricted Project

Mar 22 2023

bnbarham added inline comments to D146656: [clang][ExtractAPI] Refactor ExtractAPIVisitor to make it more extensible.
Mar 22 2023, 1:12 PM · Restricted Project, Restricted Project

Mar 21 2023

bnbarham added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mar 21 2023, 2:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 13 2023

bnbarham added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mar 13 2023, 3:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bnbarham added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mar 13 2023, 3:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
bnbarham added inline comments to D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type..
Mar 13 2023, 2:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 19 2023

bnbarham accepted D142101: [clang] [extract-api] Don't crash for category in libclang APIs.
Jan 19 2023, 11:20 AM · Restricted Project, Restricted Project

Jan 10 2023

bnbarham accepted D141324: [clang] extend external_source_symbol attribute with the USR clause.

LGTM, thanks Alex!

Jan 10 2023, 1:37 PM · Restricted Project, Restricted Project

Dec 21 2022

bnbarham added inline comments to D115232: [clangd] Indexing of standard library.
Dec 21 2022, 11:09 AM · Restricted Project, Restricted Project
bnbarham added inline comments to D115232: [clangd] Indexing of standard library.
Dec 21 2022, 10:36 AM · Restricted Project, Restricted Project

Dec 19 2022

bnbarham added inline comments to D115232: [clangd] Indexing of standard library.
Dec 19 2022, 4:23 PM · Restricted Project, Restricted Project

Dec 13 2022

bnbarham accepted D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

LGTM. If you could put up a PR after to fix the use of sys::fs::make_absolute that would be appreciated 🙇.

Dec 13 2022, 4:49 PM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2022

bnbarham committed rG699ae92f0453: [Index] Add various missing USR generation (authored by bnbarham).
[Index] Add various missing USR generation
Nov 28 2022, 11:51 AM · Restricted Project, Restricted Project
bnbarham closed D138322: [Index] Add various missing USR generation.
Nov 28 2022, 11:51 AM · Restricted Project, Restricted Project

Nov 18 2022

bnbarham updated the diff for D138322: [Index] Add various missing USR generation.

Add missing --target

Nov 18 2022, 3:16 PM · Restricted Project, Restricted Project
bnbarham added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 18 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham requested review of D138322: [Index] Add various missing USR generation.
Nov 18 2022, 12:35 PM · Restricted Project, Restricted Project

Nov 15 2022

bnbarham added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 15 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

bnbarham added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 8 2022, 5:21 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham added inline comments to D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.
Nov 8 2022, 12:58 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham updated subscribers of D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file.

This seems reasonable to me in general. @dexonsmith in case you have any thoughts.

Nov 8 2022, 10:24 AM · Restricted Project, Restricted Project, Restricted Project

Nov 3 2022

bnbarham added inline comments to D137304: [clang] Store filename per include instead of mutating filename.
Nov 3 2022, 10:09 AM · Restricted Project, Restricted Project

Oct 31 2022

bnbarham accepted D136844: [libclang] Expose completion result kind in `CXCompletionResult`.

Thanks Egor!

Oct 31 2022, 4:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 24 2022

bnbarham added a comment to D136651: [Clang] Give Clang the ability to use a shared stat cache.

You're correct that this overhead has been measured on implicit module builds. As I mentioned in the commit message this saves over 20% of the overall built time in some cases. This time is split between module validation (which could be skipped) and HeaderSearch (which cannot be skipped).

Oct 24 2022, 8:46 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham added a comment to D136651: [Clang] Give Clang the ability to use a shared stat cache.

Mostly just skimmed so far, will hopefully have some time to look at this more tomorrow. Out of interest, do you have any performance numbers using this change? I assume this mainly impacts implicit modules (since I suspect we'd also be opening the file as well anyway), is that true?

Oct 24 2022, 6:41 PM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

bnbarham added a comment to D135634: [clang][modules] Serialize VFS overlay paths into PCMs.

I think we should deduplicate the vfs overlays if the same ivfsoverlay is specified in both the pcm and the command-line.

My understanding is that ASTUnit never uses command-line and always adopts whatever is in the PCM.

Oct 18 2022, 3:49 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham added a comment to D135634: [clang][modules] Serialize VFS overlay paths into PCMs.

I think we should deduplicate the vfs overlays if the same ivfsoverlay is specified in both the pcm and the command-line.

@bnbarham any concern about overlay vs chaining behaviour here? I remember you looking at that a while ago.

Oct 18 2022, 2:24 PM · Restricted Project, Restricted Project, Restricted Project

Oct 5 2022

bnbarham accepted D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef.
Oct 5 2022, 9:51 AM · Restricted Project, Restricted Project

Sep 20 2022

bnbarham accepted D134249: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'"..

When we try to load such outdated .pcm file, we shouldn't change any already loaded and processed modules.

Sep 20 2022, 3:01 PM · Restricted Project, Restricted Project

Aug 5 2022

bnbarham accepted D131273: [clang] Fix redirection behaviour for cached FileEntryRef.
Aug 5 2022, 12:06 PM · Restricted Project, Restricted Project

Aug 3 2022

bnbarham accepted D131076: [clang][modules] Don't depend on sharing FileManager during module build.
Aug 3 2022, 1:01 PM · Restricted Project, Restricted Project

Aug 2 2022

bnbarham accepted D131017: Fix use-after-free in clang-apply-replacements.
Aug 2 2022, 1:33 PM · Restricted Project, Restricted Project
bnbarham accepted D131004: [clang] Add FileEntryRef::getNameAsRequested().

Thanks 🙇

Aug 2 2022, 12:37 PM · Restricted Project, Restricted Project

Aug 1 2022

bnbarham accepted D130935: [clang] Only modify FileEntryRef names that are externally remapped.
Aug 1 2022, 1:57 PM · Restricted Project, Restricted Project
bnbarham accepted D130934: [clang] Update code that assumes FileEntry::getName is absolute NFC.

LGTM, thanks for doing this 🙇

Aug 1 2022, 1:52 PM · Restricted Project, Restricted Project, Restricted Project

Jun 13 2022

bnbarham added a comment to D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap().

The failure here is likely due to the hack in FileManager::getFileRef:

// FIXME: This hack ensures that `getDir()` will use the path that was
// used to lookup this file, even if we found a file by different path
// first. This is required in order to find a module's structure when its
// headers/module map are mapped in the VFS.

So the directory returned from the FileEntry is the *lookup* directory, but the FileEntryRef will be giving back the directory from the external path (if it has been remapped).

Jun 13 2022, 12:39 PM · Restricted Project, Restricted Project
bnbarham added a comment to D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile.

Failing test seems to be because . is turned into the full path at some point. It's possible that this is because getFileRef returns the absolute path (see the massive FIXME there). If that's the case we could fix that by fixing clang-apply-replacements and then change the Status.getName() == Filename to only check whether it's an externally mapped path.

Jun 13 2022, 11:22 AM · Restricted Project, Restricted Project
bnbarham accepted D127663: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::LookupFile.
Jun 13 2022, 11:15 AM · Restricted Project, Restricted Project
bnbarham accepted D127660: [clang][lex] NFCI: Use DirectoryEntryRef in Preprocessor::MainFileDir.
Jun 13 2022, 11:02 AM · Restricted Project, Restricted Project
bnbarham added inline comments to D127654: [clang] NFCI: Use DirectoryEntryRef in Module::Directory.
Jun 13 2022, 10:59 AM · Restricted Project, Restricted Project
bnbarham accepted D127658: [clang][lex] NFCI: Use FileEntryRef in Sema::CodeCompleteIncludedFile.
Jun 13 2022, 10:55 AM · Restricted Project, Restricted Project
bnbarham accepted D127654: [clang] NFCI: Use DirectoryEntryRef in Module::Directory.
Jun 13 2022, 10:54 AM · Restricted Project, Restricted Project
bnbarham accepted D127651: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::parseModuleMapFile().
Jun 13 2022, 10:01 AM · Restricted Project, Restricted Project, Restricted Project
bnbarham accepted D127648: [clang][lex] NFCI: Use DirectoryEntryRef in ModuleMap::inferFrameworkModule().
Jun 13 2022, 9:42 AM · Restricted Project, Restricted Project
bnbarham accepted D127647: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::{load,lookup}ModuleMap().

Few small comments, LGTM otherwise.

Jun 13 2022, 9:38 AM · Restricted Project, Restricted Project

May 9 2022

bnbarham added inline comments to D125152: [compiler-rt] Add missing arguments to dynamic cflags.
May 9 2022, 10:51 AM · Restricted Project, Restricted Project

May 6 2022

bnbarham requested review of D125152: [compiler-rt] Add missing arguments to dynamic cflags.
May 6 2022, 5:49 PM · Restricted Project, Restricted Project

Apr 22 2022

bnbarham committed rG089b6efefc3d: [Index] Remove reference to `UnresolvedUsingIfExists` (authored by bnbarham).
[Index] Remove reference to `UnresolvedUsingIfExists`
Apr 22 2022, 5:20 PM · Restricted Project, Restricted Project
bnbarham closed D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.
Apr 22 2022, 5:19 PM · Restricted Project, Restricted Project
bnbarham updated the diff for D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.

Remove line for <unknown> check

Apr 22 2022, 3:16 PM · Restricted Project, Restricted Project
bnbarham updated the diff for D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.

Update title/message

Apr 22 2022, 2:43 PM · Restricted Project, Restricted Project
bnbarham updated the diff for D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.

After speaking with Ben, we decided it makes more sense to just remove the reference entirely.

Apr 22 2022, 2:42 PM · Restricted Project, Restricted Project
bnbarham added inline comments to D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.
Apr 22 2022, 11:44 AM · Restricted Project, Restricted Project
bnbarham requested review of D124288: [Index] Remove reference to `UnresolvedUsingIfExists`.
Apr 22 2022, 11:40 AM · Restricted Project, Restricted Project

Apr 15 2022

bnbarham accepted D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion().

Shadowing of FE almost tripped me up there 😅

Apr 15 2022, 9:18 AM · Restricted Project, Restricted Project
bnbarham accepted D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry.
Apr 15 2022, 9:16 AM · Restricted Project, Restricted Project
bnbarham accepted D123853: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile().
Apr 15 2022, 9:08 AM · Restricted Project, Restricted Project
bnbarham accepted D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().
Apr 15 2022, 9:07 AM · Restricted Project, Restricted Project

Apr 14 2022

bnbarham accepted D123770: [clang] NFCI: Use FileEntryRef in FileManagerTest.
Apr 14 2022, 9:42 AM · Restricted Project, Restricted Project
bnbarham accepted D123772: [clang][lex] NFC: Use FileEntryRef in PreprocessorLexer::getFileEntry().
Apr 14 2022, 9:39 AM · Restricted Project, Restricted Project
bnbarham accepted D123768: [clang][CodeGen] NFCI: Use FileEntryRef.
Apr 14 2022, 9:39 AM · Restricted Project, Restricted Project
bnbarham added inline comments to D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*().
Apr 14 2022, 9:36 AM · Restricted Project, Restricted Project
bnbarham accepted D123769: [clang] NFCI: Use DirectoryEntryRef in collectIncludePCH.
Apr 14 2022, 9:12 AM · Restricted Project, Restricted Project
bnbarham accepted D123767: [clang][parse] NFCI: Use FileEntryRef in Parser::ParseModuleImport().

Thanks for doing all these Jan!

Apr 14 2022, 9:10 AM · Restricted Project, Restricted Project

Apr 12 2022

bnbarham accepted D123574: [clang][lex] NFCI: Use FileEntryRef in PPCallbacks::InclusionDirective().

Thanks Jan :)!

Apr 12 2022, 11:54 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

bnbarham committed rGfe2478d44e4f: [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham).
[VFS] RedirectingFileSystem only replace path if not already mapped
Apr 11 2022, 2:53 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham closed D123398: [VFS] RedirectingFileSystem only replace path if not already mapped.
Apr 11 2022, 2:53 PM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

bnbarham added a comment to D123398: [VFS] RedirectingFileSystem only replace path if not already mapped.

Does clang/test/VFS/external-names-multi-overlay.c need to be formatted or is it fine? It uses split-file so I'd really like to avoid the format here (makes it pretty silly).

Apr 8 2022, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham abandoned D123104: [Modules] Use looked-up filename when looking for module maps.

Looks like there's more changes required for modulemap-collision.m to actually pass. I'll try figure those out when I have the time.

Apr 8 2022, 9:06 AM · Restricted Project, Restricted Project
bnbarham requested review of D123398: [VFS] RedirectingFileSystem only replace path if not already mapped.
Apr 8 2022, 9:04 AM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

bnbarham updated the diff for D123104: [Modules] Use looked-up filename when looking for module maps.

Added a potential plan to remove the FileManager hacks.

Apr 5 2022, 6:16 PM · Restricted Project, Restricted Project
bnbarham added inline comments to D123104: [Modules] Use looked-up filename when looking for module maps.
Apr 5 2022, 6:01 PM · Restricted Project, Restricted Project
bnbarham added a reverting change for rG3fda0edc51fd: [VFS] RedirectingFileSystem only replace path if not already mapped: rGf65b0b5dcfeb: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".
Apr 5 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham committed rGf65b0b5dcfeb: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped" (authored by bnbarham).
Revert "[VFS] RedirectingFileSystem only replace path if not already mapped"
Apr 5 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham added a reverting change for D122549: [VFS] RedirectingFileSystem only replace path if not already mapped: rGf65b0b5dcfeb: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".
Apr 5 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham closed D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".
Apr 5 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2022

bnbarham added a comment to D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".

This broke crash reproducers in very specific circumstances, see https://reviews.llvm.org/D123104. I'll re-commit with adding ExposesExternalVFSPath instead of replacing IsVFSMapped.

Apr 4 2022, 5:26 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham requested review of D123104: [Modules] Use looked-up filename when looking for module maps.
Apr 4 2022, 5:20 PM · Restricted Project, Restricted Project
bnbarham added a reverting change for rG3fda0edc51fd: [VFS] RedirectingFileSystem only replace path if not already mapped: D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".
Apr 4 2022, 5:20 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham requested review of D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".
Apr 4 2022, 5:19 PM · Restricted Project, Restricted Project, Restricted Project
bnbarham added a reverting change for D122549: [VFS] RedirectingFileSystem only replace path if not already mapped: D123103: Revert "[VFS] RedirectingFileSystem only replace path if not already mapped".
Apr 4 2022, 5:19 PM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

bnbarham committed rG3fda0edc51fd: [VFS] RedirectingFileSystem only replace path if not already mapped (authored by bnbarham).
[VFS] RedirectingFileSystem only replace path if not already mapped
Mar 30 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
bnbarham closed D122549: [VFS] RedirectingFileSystem only replace path if not already mapped.
Mar 30 2022, 11:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

bnbarham updated the diff for D122549: [VFS] RedirectingFileSystem only replace path if not already mapped.

Keep using the redirection hack for the time being

Mar 29 2022, 12:42 PM · Restricted Project, Restricted Project, Restricted Project