Priorities below 101 are reserved for the implementation, so that's what
we should be using here. That is unfortunately only supported on more
recent versions of Clang. See https://reviews.llvm.org/D31413 for details.
Details
Details
- Reviewers
aaron.ballman - Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libcxx/src/experimental/memory_resource.cpp | ||
---|---|---|
79 | @arthur.j.odwyer Pinging you here since you wrote that code. Does this LGTY? |
libcxx/src/experimental/memory_resource.cpp | ||
---|---|---|
79 | @ldionne: I just copied this line from experimental/... oh wait, this is experimental/... yeah, this was added by @EricWF in https://github.com/llvm/llvm-project/commit/4efaa30934e81 . IIUC, if we're sure this file is always compiled as C++14 at this point, then I don't even think it matters what we put here. In C++20 we should mark this variable constinit. However, whatever you decide on, it'd be useful if you could add a review comment to D89057 . |