One question below. Sorry to bother you about this nit. :)
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/SPIRV/IR/SPIRVTypes.cpp | ||
---|---|---|
328 ↗ | (On Diff #320943) | Any idea how we can silence these warnings? I'm seeing quite a few here and in TypeDetail.h. Mostly for all the bitfields. I think the problem is that the underlying type of the enums is int by default so we could assign random int values to the enum variables which would require more bits than the specified by the bitfield. |
I think this is a problem with old versions of GCC, I see these with gcc5 but not gcc7 and above.
I'm using GCC 7.5.0. Ok, if those bitfields are not problematic and there is no easy way to silence them, I'll remove the comments then.
Ah maybe it is only gcc 8 and above then, here is our CI log with gcc8 : https://buildkite.com/organizations/mlir/pipelines/mlir-core/builds/11292/jobs/e2dcad00-1ff4-4abd-ac86-d68668fcc673/raw_log
Removing "warning" comments.
If no more comments, I'll commit this since it's a trivial change.
Thanks!
mlir/lib/Dialect/Affine/Transforms/SuperVectorize.cpp | ||
---|---|---|
1339 | It honestly looks like this function should just return a result, and uses of it should assert that it returns success. |
clang-tidy: warning: unused function 'unwrap' [clang-diagnostic-unused-function]
not useful
clang-tidy: warning: unused function 'wrap' [clang-diagnostic-unused-function]
not useful