Add the conversion pattern for vector.bitcast to lower it to
the LLVM Dialect.
RFC: https://llvm.discourse.group/t/rfc-vector-standard-add-bitcast-operation
Paths
| Differential D95579
[mlir][Vector] Add lowering to LLVM for vector.bitcast ClosedPublic Authored by dcaballe on Jan 27 2021, 5:56 PM.
Details Summary Add the conversion pattern for vector.bitcast to lower it to RFC: https://llvm.discourse.group/t/rfc-vector-standard-add-bitcast-operation
Diff Detail
Event TimelineHerald added subscribers: teijeong, rdzhabarov, tatianashp and 13 others. · View Herald TranscriptJan 27 2021, 5:56 PM
dcaballe marked an inline comment as done. Comment ActionsAddressing feedback
Comment Actions Any other comments?
This revision is now accepted and ready to land.Feb 1 2021, 10:16 AM Closed by commit rGcf5c517c05e0: [mlir][Vector] Add lowering to LLVM for vector.bitcast (authored by dcaballe). · Explain WhyFeb 2 2021, 3:29 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 319761 mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp
mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir
|
This only works for vector of rank 1 right? We should probably check and fail for larger ranks?