Page MenuHomePhabricator

sgrechanik (Sergei Grechanik)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2020, 3:19 PM (19 w, 5 d)

Recent Activity

Yesterday

sgrechanik added a comment to D100694: [mlir][Affine][Vector] Support vectorizing reduction loops.

Thank you for the feedback, I'll update the patch soon.

Mon, Apr 19, 8:36 PM · Restricted Project

Fri, Apr 16

sgrechanik requested review of D100694: [mlir][Affine][Vector] Support vectorizing reduction loops.
Fri, Apr 16, 7:29 PM · Restricted Project

Tue, Apr 13

sgrechanik committed rGf56791ae2ea0: [mlir] Prevent operations with users from being hoisted (authored by sumesh13).
[mlir] Prevent operations with users from being hoisted
Tue, Apr 13, 3:38 PM
sgrechanik closed D99761: [mlir] Prevent operations with users from being hoisted.
Tue, Apr 13, 3:38 PM · Restricted Project

Mon, Mar 29

sgrechanik added a comment to D98530: [mlir][Vector] Pass for lowering of transfer_read/write.

@nicolasvasilache @aartbik Kindly ping. This patch changes the directory structure quite a bit, so I'm not comfortable proceeding without a second opinion.

Mon, Mar 29, 5:51 PM · Restricted Project

Sun, Mar 28

sgrechanik accepted D99019: [mlir][vector] Add lowering of Transfer_read with leading dim broadcast and permutation map.
Sun, Mar 28, 11:55 AM · Restricted Project

Wed, Mar 24

sgrechanik added inline comments to D99019: [mlir][vector] Add lowering of Transfer_read with leading dim broadcast and permutation map.
Wed, Mar 24, 8:29 PM · Restricted Project

Mar 17 2021

sgrechanik updated the diff for D98530: [mlir][Vector] Pass for lowering of transfer_read/write.
  • Fixed the clang-tidy warning
Mar 17 2021, 3:11 PM · Restricted Project
sgrechanik added inline comments to D98530: [mlir][Vector] Pass for lowering of transfer_read/write.
Mar 17 2021, 8:57 AM · Restricted Project
sgrechanik updated the diff for D98530: [mlir][Vector] Pass for lowering of transfer_read/write.

Fixed formatting

Mar 17 2021, 8:56 AM · Restricted Project

Mar 16 2021

sgrechanik updated the diff for D98530: [mlir][Vector] Pass for lowering of transfer_read/write.
  • Moved the pass to a separate file.
  • Restructured the mlir/lib/Dialect/Vector directory.
  • Split the MLIRVector library into MLIRVector and MLIRVectorTransforms
Mar 16 2021, 7:00 PM · Restricted Project

Mar 15 2021

sgrechanik updated the diff for D98530: [mlir][Vector] Pass for lowering of transfer_read/write.
Mar 15 2021, 4:24 PM · Restricted Project

Mar 12 2021

sgrechanik requested review of D98530: [mlir][Vector] Pass for lowering of transfer_read/write.
Mar 12 2021, 10:31 AM · Restricted Project

Mar 11 2021

sgrechanik committed rGfd2b08969b8a: [mlir][Vector] Lowering of transfer_read/write to vector.load/store (authored by sgrechanik).
[mlir][Vector] Lowering of transfer_read/write to vector.load/store
Mar 11 2021, 6:20 PM
sgrechanik closed D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.
Mar 11 2021, 6:19 PM · Restricted Project
sgrechanik committed rG46ef6ffdaf7c: [NFC] Test commit. Add empty lines. (authored by sgrechanik).
[NFC] Test commit. Add empty lines.
Mar 11 2021, 5:34 PM

Mar 10 2021

sgrechanik added inline comments to D98239: [MLIR][Affine] Add utility to check if the slice is valid.
Mar 10 2021, 2:55 PM · Restricted Project
sgrechanik added a comment to D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.

As I mentioned before, I would suggest that we create a regular pass for this lowering, not only a test pass, so that we can compose it as needed in the pipeline.

Mar 10 2021, 10:38 AM · Restricted Project

Mar 9 2021

sgrechanik updated the diff for D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.
Mar 9 2021, 10:59 AM · Restricted Project

Mar 8 2021

sgrechanik updated the diff for D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.
  • Rolled back to the previous version (i.e. no new canonicalization patterns).
  • Moved isMinorIdentityWithBroadcasting inside the AffineMap class (although not sure if it really deserves this).
Mar 8 2021, 1:33 PM · Restricted Project

Mar 5 2021

sgrechanik updated the diff for D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.

Moved the lowering pattern to canonicalization patterns.

Mar 5 2021, 3:57 PM · Restricted Project

Mar 4 2021

sgrechanik updated the diff for D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.

Updated the diff according to Diego's feedback

Mar 4 2021, 8:51 AM · Restricted Project

Mar 3 2021

sgrechanik added inline comments to D97820: [mlir] Add 'Skip' result to Operation visitor.
Mar 3 2021, 10:31 AM · Restricted Project

Mar 2 2021

sgrechanik requested review of D97822: [mlir][Vector] Lowering of transfer_read/write to vector.load/store.
Mar 2 2021, 5:32 PM · Restricted Project
sgrechanik added inline comments to D97442: [mlir][Vector][Affine] Improve affine vectorizer algorithm.
Mar 2 2021, 3:16 PM · Restricted Project

Jan 8 2021

sgrechanik added a comment to D92233: [MLIR][Affine] Add affine.for normalization support.

Hey guys,
I found a problem with this pass; if you feed it the following loop:

Jan 8 2021, 5:26 PM · Restricted Project

Dec 7 2020

sgrechanik added inline comments to D92702: [mlir][Affine] Fix vectorizability check for multiple load/stores.
Dec 7 2020, 3:40 PM · Restricted Project
sgrechanik updated the diff for D92702: [mlir][Affine] Fix vectorizability check for multiple load/stores.
  • Set *memRefDim to -1 in the beginning
  • Fix indentation for the test case
Dec 7 2020, 3:40 PM · Restricted Project

Dec 4 2020

sgrechanik requested review of D92702: [mlir][Affine] Fix vectorizability check for multiple load/stores.
Dec 4 2020, 3:29 PM · Restricted Project