This adds sadd.sat, uadd.sat, ssub.sat and usub.sat costs for AArch64, similar to how they were recently added for ARM.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM
| llvm/test/Analysis/CostModel/AArch64/arith-ssat.ll | ||
|---|---|---|
| 34–35 | I know you're just handling legal costs in this patch but these appear to be very high! | |
| llvm/test/Analysis/CostModel/AArch64/arith-ssat.ll | ||
|---|---|---|
| 34–35 | Whoops! Thanks for noticing. These should be legal, I apparently wasn't paying enough attention to how the tests changed. | |
| llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp | ||
|---|---|---|
| 249 | For the Instrs == 4 case? Yeah, those are cases like: | |
| llvm/test/Analysis/CostModel/AArch64/arith-ssat.ll | ||
| 82 | Will do. | |
are there test cases for that?