Page MenuHomePhabricator

[AArch64][GlobalISel] Fix instruction selection for G_USUBO
AbandonedPublic

Authored by porglezomp on Jan 22 2021, 4:33 PM.

Details

Summary

G_USUBO needs to be checked for overflow with the LO condition code
instead of the HS condition code.

Diff Detail

Event Timeline

porglezomp created this revision.Jan 22 2021, 4:33 PM
porglezomp requested review of this revision.Jan 22 2021, 4:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 4:33 PM

I don't know the most convenient way to provide this—should I squash this onto the D95032 review instead, so it can get re-reviewed/tested there, and then these re-landed?

I also reopened D95032 with the fix squashed onto that, please review whichever of them will be more convenient.

I also reopened D95032 with the fix squashed onto that, please review whichever of them will be more convenient.

It's fine to use the existing review.

porglezomp abandoned this revision.Jan 22 2021, 7:04 PM