Page MenuHomePhabricator

porglezomp (Cassie Jones)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 2:37 PM (98 w, 5 d)

hey look its cassie porglezomp

Recent Activity

Thu, Jun 10

porglezomp accepted D104017: [Utils] Add missing freeze and poison keyword highlights.

This looks good to me.

Thu, Jun 10, 5:29 PM · Restricted Project

May 18 2021

porglezomp committed rG7faabe5fc91e: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives (authored by zsrkmyn).
[Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives
May 18 2021, 8:42 PM
porglezomp closed D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.
May 18 2021, 8:42 PM · Restricted Project

Apr 26 2021

porglezomp accepted D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Style nit on quote-vs-slash, but otherwise this looks good to me.

Apr 26 2021, 3:43 AM · Restricted Project

Feb 23 2021

porglezomp committed rG2ddd25fd0d6f: [Test][AArch64] Test SADDO/SSUBO narrowing legalization (authored by porglezomp).
[Test][AArch64] Test SADDO/SSUBO narrowing legalization
Feb 23 2021, 11:41 PM
porglezomp closed D96675: [Test][AArch64] Test SADDO/SSUBO narrowing legalization.
Feb 23 2021, 11:41 PM · Restricted Project

Feb 22 2021

porglezomp committed rG0596086242b2: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization (authored by porglezomp).
[Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization
Feb 22 2021, 5:00 PM
porglezomp committed rG8b10aa67ad5c: [AArch64][GlobalISel] Make overflow legalization use clampScalar (authored by porglezomp).
[AArch64][GlobalISel] Make overflow legalization use clampScalar
Feb 22 2021, 5:00 PM
porglezomp committed rG8f956a5e8f5a: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE (authored by porglezomp).
[GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE
Feb 22 2021, 5:00 PM
porglezomp committed rGe1532649cb2a: [GlobalISel] Implement narrowScalar for SADDO/SSUBO (authored by porglezomp).
[GlobalISel] Implement narrowScalar for SADDO/SSUBO
Feb 22 2021, 5:00 PM
porglezomp closed D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp committed rGc63b33b79261: [GlobalISel] Implement narrowScalar for UADDO/USUBO (authored by porglezomp).
[GlobalISel] Implement narrowScalar for UADDO/USUBO
Feb 22 2021, 5:00 PM
porglezomp closed D96674: [AArch64][GlobalISel] Make overflow legalization use clampScalar.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp closed D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp closed D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp closed D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.
Feb 22 2021, 4:59 PM · Restricted Project
porglezomp added a comment to D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

ping on this one, since it's the first in the stack and blocking the others

Feb 22 2021, 9:56 AM · Restricted Project

Feb 19 2021

porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Flip argument order of EXPECT_EQ for better failure messages

Feb 19 2021, 11:00 AM · Restricted Project
porglezomp updated the diff for D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.

Flip argument order of EXPECT_EQ for better failure messages

Feb 19 2021, 10:54 AM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Flip argument order of EXPECT_EQ for better failure messages

Feb 19 2021, 10:52 AM · Restricted Project

Feb 18 2021

porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Change some EXPECT_TRUE to EXPECT_EQ

Feb 18 2021, 10:58 PM · Restricted Project
porglezomp updated the diff for D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.

Change some EXPECT_TRUE to EXPECT_EQ

Feb 18 2021, 10:58 PM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Change some ASSERT_TRUE to ASSERT_EQ

Feb 18 2021, 10:58 PM · Restricted Project
porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Change Optional<Register> to Register, change a >= to == since it's all that's needed

Feb 18 2021, 6:04 PM · Restricted Project
porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Remove ";" file I accidentally added

Feb 18 2021, 12:05 PM · Restricted Project
porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Change unittest buildInstr to more specific build* calls

Feb 18 2021, 12:03 PM · Restricted Project
porglezomp updated the diff for D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.

Change unittest buildInstr to buildSAddo/buildSSubo

Feb 18 2021, 12:00 PM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Add comment about number of defs, change buildInstr

Feb 18 2021, 11:57 AM · Restricted Project

Feb 17 2021

porglezomp added inline comments to D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.
Feb 17 2021, 6:19 PM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Change Optional<Register> to Register

Feb 17 2021, 10:47 AM · Restricted Project

Feb 16 2021

porglezomp added inline comments to D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.
Feb 16 2021, 11:54 PM · Restricted Project
porglezomp committed rGed7638a34d32: [vim] Highlight most common MIR syntax not in LLVM IR (authored by porglezomp).
[vim] Highlight most common MIR syntax not in LLVM IR
Feb 16 2021, 11:41 PM
porglezomp committed rGc6a96df37520: [vim] Add initial syntax definition for .mir files (authored by porglezomp).
[vim] Add initial syntax definition for .mir files
Feb 16 2021, 11:41 PM
porglezomp closed D95553: [vim] Highlight most common MIR syntax not in LLVM IR.
Feb 16 2021, 11:41 PM · Restricted Project
porglezomp closed D95552: [vim] Add initial syntax definition for .mir files.
Feb 16 2021, 11:41 PM · Restricted Project
porglezomp added a comment to D95552: [vim] Add initial syntax definition for .mir files.

I can commit them.

Feb 16 2021, 5:53 PM · Restricted Project
porglezomp added a comment to D95552: [vim] Add initial syntax definition for .mir files.

The MIR syntax is based on extending the yaml syntax and then embedding the machine-ir syntax inside it, I've defined it as two separate files so it's easier to separate "highlighting the instructions" from "embedding it inside yaml".

Feb 16 2021, 5:31 PM · Restricted Project

Feb 14 2021

porglezomp requested review of D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.
Feb 14 2021, 3:42 PM · Restricted Project
porglezomp requested review of D96675: [Test][AArch64] Test SADDO/SSUBO narrowing legalization.
Feb 14 2021, 3:42 PM · Restricted Project
porglezomp requested review of D96674: [AArch64][GlobalISel] Make overflow legalization use clampScalar.
Feb 14 2021, 3:41 PM · Restricted Project
porglezomp requested review of D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.
Feb 14 2021, 3:39 PM · Restricted Project
porglezomp requested review of D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.
Feb 14 2021, 3:37 PM · Restricted Project
porglezomp requested review of D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.
Feb 14 2021, 3:36 PM · Restricted Project
porglezomp committed rG97a1cdb15618: [GlobalISel] Disable vector types in narrowScalarAddSub (authored by porglezomp).
[GlobalISel] Disable vector types in narrowScalarAddSub
Feb 14 2021, 3:07 PM
porglezomp committed rG36246388bae2: [GlobalISel] Extract a narrowScalarAddSub method. NFC (authored by porglezomp).
[GlobalISel] Extract a narrowScalarAddSub method. NFC
Feb 14 2021, 3:07 PM
porglezomp closed D95699: [GlobalISel] Disable vector types in narrowScalarAddSub.
Feb 14 2021, 3:07 PM · Restricted Project
porglezomp closed D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Feb 14 2021, 3:07 PM · Restricted Project

Feb 4 2021

porglezomp added a comment to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

ping, are there any changes this still needs? I think the existing comments are sufficiently addressed given that the goal is to make this an NFC change and fix them up separately.

Feb 4 2021, 10:42 AM · Restricted Project

Jan 29 2021

porglezomp updated the diff for D95699: [GlobalISel] Disable vector types in narrowScalarAddSub.

Use a temporary variable for the destination register/type

Jan 29 2021, 10:21 PM · Restricted Project
porglezomp requested review of D95699: [GlobalISel] Disable vector types in narrowScalarAddSub.
Jan 29 2021, 2:26 PM · Restricted Project
porglezomp updated the diff for D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

Re-add the vector code to make it more properly an NFC commit

Jan 29 2021, 2:22 PM · Restricted Project
porglezomp added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 29 2021, 11:02 AM · Restricted Project
porglezomp updated the diff for D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

Moved unreachable case to bottom of switch

Jan 29 2021, 10:23 AM · Restricted Project
porglezomp updated the diff for D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

Add a default case assertion, mark vectors as unsupported, cleanups

Jan 29 2021, 10:16 AM · Restricted Project
porglezomp added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 29 2021, 2:37 AM · Restricted Project

Jan 28 2021

porglezomp committed rGf22f4557a749: [GlobalISel] Implement widenScalar for carry-in add/sub (authored by porglezomp).
[GlobalISel] Implement widenScalar for carry-in add/sub
Jan 28 2021, 2:06 PM
porglezomp closed D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.
Jan 28 2021, 2:06 PM · Restricted Project

Jan 27 2021

porglezomp added a comment to D95552: [vim] Add initial syntax definition for .mir files.

A question for reviewers who might be able to explain:

Jan 27 2021, 1:04 PM · Restricted Project
porglezomp requested review of D95553: [vim] Highlight most common MIR syntax not in LLVM IR.
Jan 27 2021, 11:36 AM · Restricted Project
porglezomp requested review of D95552: [vim] Add initial syntax definition for .mir files.
Jan 27 2021, 11:35 AM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Add unreachable case, give vregs names in tests

Jan 27 2021, 11:19 AM · Restricted Project
porglezomp added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 27 2021, 11:15 AM · Restricted Project
porglezomp committed rGcde1f54fb3fa: [Test][AArch64] Use named vregs in overflow legalization tests. NFC (authored by porglezomp).
[Test][AArch64] Use named vregs in overflow legalization tests. NFC
Jan 27 2021, 1:42 AM
porglezomp committed rG40f6599c20af: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal (authored by porglezomp).
[AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal
Jan 27 2021, 1:37 AM
porglezomp closed D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.
Jan 27 2021, 1:37 AM · Restricted Project

Jan 26 2021

porglezomp updated the diff for D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

Fix broken named vreg in legalize-ssube.mir

Jan 26 2021, 11:50 PM · Restricted Project
porglezomp updated the diff for D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

Used named vregs in test cases

Jan 26 2021, 9:32 PM · Restricted Project
porglezomp requested review of D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 26 2021, 1:13 AM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Add unit-tests in LegalizerHelperTest

Jan 26 2021, 12:35 AM · Restricted Project

Jan 25 2021

porglezomp committed rGfdbfda2178a7: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE (authored by porglezomp).
[Test][AArch64] Add s32 legalizer test for UADDE/USUBE
Jan 25 2021, 7:05 PM
porglezomp committed rG2ba1f9c4e0e1: [Test][AArch64] Move overflow add/sub tests to their own file. NFC (authored by porglezomp).
[Test][AArch64] Move overflow add/sub tests to their own file. NFC
Jan 25 2021, 7:05 PM
porglezomp closed D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.
Jan 25 2021, 7:05 PM · Restricted Project
porglezomp closed D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.
Jan 25 2021, 7:05 PM · Restricted Project
porglezomp committed rGaa8f3677f799: Recommit "[AArch64][GlobalISel] Implement widenScalar for signed overflow" (authored by porglezomp).
Recommit "[AArch64][GlobalISel] Implement widenScalar for signed overflow"
Jan 25 2021, 2:02 PM
porglezomp closed D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow.
Jan 25 2021, 2:02 PM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Change MachineOperand variable to Register, use getReg(0) on MachineInstrBuilder

Jan 25 2021, 11:36 AM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Update tests to match run-line changes

Jan 25 2021, 10:55 AM · Restricted Project
porglezomp updated the diff for D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

Update test run line to match suggestions on D95323

Jan 25 2021, 10:54 AM · Restricted Project
porglezomp updated the diff for D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.

Update test run line to match suggestions on D95323

Jan 25 2021, 10:53 AM · Restricted Project
porglezomp updated the diff for D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.

Change the run-line for the new test files

Jan 25 2021, 10:29 AM · Restricted Project

Jan 24 2021

porglezomp requested review of D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.
Jan 24 2021, 6:05 PM · Restricted Project
porglezomp requested review of D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.
Jan 24 2021, 5:58 PM · Restricted Project
porglezomp requested review of D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.
Jan 24 2021, 5:54 PM · Restricted Project
porglezomp requested review of D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.
Jan 24 2021, 5:53 PM · Restricted Project

Jan 22 2021

porglezomp reopened D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method.

The buildbot with the UBSan tests passed for the first commit in this stack, so I think this should be safe to re-land http://lab.llvm.org:8011/#/builders/77/builds/3112

Jan 22 2021, 7:04 PM · Restricted Project
porglezomp abandoned D95275: [AArch64][GlobalISel] Fix instruction selection for G_USUBO.
Jan 22 2021, 7:04 PM · Restricted Project
porglezomp reopened D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow.

The buildbot with the UBSan tests passed for the first commit in this stack, so I think this should be safe to re-land http://lab.llvm.org:8011/#/builders/77/builds/3112

Jan 22 2021, 7:03 PM · Restricted Project
porglezomp added a comment to D95275: [AArch64][GlobalISel] Fix instruction selection for G_USUBO.

I also reopened D95032 with the fix squashed onto that, please review whichever of them will be more convenient.

Jan 22 2021, 4:51 PM · Restricted Project
porglezomp updated the diff for D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Fix instruction selection for G_USUBO

Jan 22 2021, 4:50 PM · Restricted Project
porglezomp reopened D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.
Jan 22 2021, 4:50 PM · Restricted Project
porglezomp added a comment to D95275: [AArch64][GlobalISel] Fix instruction selection for G_USUBO.

I don't know the most convenient way to provide this—should I squash this onto the D95032 review instead, so it can get re-reviewed/tested there, and then these re-landed?

Jan 22 2021, 4:48 PM · Restricted Project
porglezomp requested review of D95275: [AArch64][GlobalISel] Fix instruction selection for G_USUBO.
Jan 22 2021, 4:33 PM · Restricted Project
porglezomp updated the diff for D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method.

Update tests for changed legalization

Jan 22 2021, 11:57 AM · Restricted Project
porglezomp added a comment to D94457: [AArch64] Add some missing fusion subtarget features.

I don't have commit access, so could someone commit the change for me? Thanks.

Jan 22 2021, 11:29 AM · Restricted Project

Jan 21 2021

porglezomp added a comment to D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Since I don't have commit access, could you commit these for me?

Jan 21 2021, 2:52 PM · Restricted Project

Jan 20 2021

porglezomp abandoned D65421: Make lit.py abort_now() kill the worker process more precisely.
Jan 20 2021, 12:25 PM · Restricted Project
porglezomp updated the diff for D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Add the requested selection tests

Jan 20 2021, 12:04 PM · Restricted Project
porglezomp abandoned D94936: [AArch64][GlobalISel] Instruction selection for add/sub with carry-in.

Closing this in favor of separate revisions for the individual changes.

Jan 20 2021, 12:01 PM · Restricted Project
porglezomp updated porglezomp.
Jan 20 2021, 11:21 AM
porglezomp requested review of D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method.
Jan 20 2021, 4:55 AM · Restricted Project