Page MenuHomePhabricator

porglezomp (Cassie Jones)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 2:37 PM (152 w, 3 d)

hey look its cassie porglezomp

Recent Activity

May 14 2022

porglezomp committed rGae8bbc43f470: [clang] Require including config.h for CLANG_DEFAULT_STD_C (authored by porglezomp).
[clang] Require including config.h for CLANG_DEFAULT_STD_C
May 14 2022, 1:50 AM · Restricted Project, Restricted Project
porglezomp committed rG2e2709479636: [clang] Include clang config.h in LangStandards.cpp (authored by porglezomp).
[clang] Include clang config.h in LangStandards.cpp
May 14 2022, 1:50 AM · Restricted Project, Restricted Project
porglezomp closed D124974: [clang] Include clang config.h in LangStandards.cpp.
May 14 2022, 1:50 AM · Restricted Project, Restricted Project

May 13 2022

porglezomp updated the diff for D124974: [clang] Include clang config.h in LangStandards.cpp.

I haven't used arc in a little while and am having trouble sorry for the emails

May 13 2022, 9:33 AM · Restricted Project, Restricted Project
porglezomp updated the diff for D124974: [clang] Include clang config.h in LangStandards.cpp.

Arcanist accidentally threw away the first commit in the sequence...

May 13 2022, 9:31 AM · Restricted Project, Restricted Project
porglezomp updated the diff for D124974: [clang] Include clang config.h in LangStandards.cpp.

Add changes suggested by Duncan to make CLANG_DEFAULT_STD_C more misuse-resistant

May 13 2022, 9:25 AM · Restricted Project, Restricted Project
porglezomp added a comment to D124974: [clang] Include clang config.h in LangStandards.cpp.

That looks good to me. I'm testing it out locally to make sure it still works right and also catches the issue, and will plan put up an updated patch in the morning.

May 13 2022, 1:31 AM · Restricted Project, Restricted Project

May 10 2022

porglezomp added a comment to D124974: [clang] Include clang config.h in LangStandards.cpp.

Ah, so it'd be a test that passes pretty trivially on any bot that doesn't have a custom version of CLANG_DEFAULT_STD_C and CLANG_DEFAULT_STD_CXX like the default config, but could get caught by any other bots that do set it?

May 10 2022, 5:03 PM · Restricted Project, Restricted Project

May 9 2022

porglezomp added a comment to D124974: [clang] Include clang config.h in LangStandards.cpp.

Unless anyone has an idea about how to test this, I'm going to commit this without adding a test.

May 9 2022, 11:18 AM · Restricted Project, Restricted Project

May 5 2022

porglezomp added a comment to D124974: [clang] Include clang config.h in LangStandards.cpp.

I would be interested in adding some kind of test for this, but am not sure how.

May 5 2022, 10:54 AM · Restricted Project, Restricted Project

May 4 2022

porglezomp requested review of D124974: [clang] Include clang config.h in LangStandards.cpp.
May 4 2022, 7:14 PM · Restricted Project, Restricted Project

Jun 10 2021

porglezomp accepted D104017: [Utils] Add missing freeze and poison keyword highlights.

This looks good to me.

Jun 10 2021, 5:29 PM · Restricted Project

May 18 2021

porglezomp committed rG7faabe5fc91e: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives (authored by zsrkmyn).
[Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives
May 18 2021, 8:42 PM
porglezomp closed D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.
May 18 2021, 8:42 PM · Restricted Project

Apr 26 2021

porglezomp accepted D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives.

Style nit on quote-vs-slash, but otherwise this looks good to me.

Apr 26 2021, 3:43 AM · Restricted Project

Feb 23 2021

porglezomp committed rG2ddd25fd0d6f: [Test][AArch64] Test SADDO/SSUBO narrowing legalization (authored by porglezomp).
[Test][AArch64] Test SADDO/SSUBO narrowing legalization
Feb 23 2021, 11:41 PM
porglezomp closed D96675: [Test][AArch64] Test SADDO/SSUBO narrowing legalization.
Feb 23 2021, 11:41 PM · Restricted Project

Feb 22 2021

porglezomp committed rG0596086242b2: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization (authored by porglezomp).
[Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization
Feb 22 2021, 5:00 PM
porglezomp committed rG8b10aa67ad5c: [AArch64][GlobalISel] Make overflow legalization use clampScalar (authored by porglezomp).
[AArch64][GlobalISel] Make overflow legalization use clampScalar
Feb 22 2021, 5:00 PM
porglezomp committed rG8f956a5e8f5a: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE (authored by porglezomp).
[GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE
Feb 22 2021, 5:00 PM
porglezomp committed rGe1532649cb2a: [GlobalISel] Implement narrowScalar for SADDO/SSUBO (authored by porglezomp).
[GlobalISel] Implement narrowScalar for SADDO/SSUBO
Feb 22 2021, 5:00 PM
porglezomp closed D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp committed rGc63b33b79261: [GlobalISel] Implement narrowScalar for UADDO/USUBO (authored by porglezomp).
[GlobalISel] Implement narrowScalar for UADDO/USUBO
Feb 22 2021, 5:00 PM
porglezomp closed D96674: [AArch64][GlobalISel] Make overflow legalization use clampScalar.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp closed D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp closed D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.
Feb 22 2021, 5:00 PM · Restricted Project
porglezomp closed D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.
Feb 22 2021, 4:59 PM · Restricted Project
porglezomp added a comment to D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

ping on this one, since it's the first in the stack and blocking the others

Feb 22 2021, 9:56 AM · Restricted Project

Feb 19 2021

porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Flip argument order of EXPECT_EQ for better failure messages

Feb 19 2021, 11:00 AM · Restricted Project
porglezomp updated the diff for D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.

Flip argument order of EXPECT_EQ for better failure messages

Feb 19 2021, 10:54 AM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Flip argument order of EXPECT_EQ for better failure messages

Feb 19 2021, 10:52 AM · Restricted Project

Feb 18 2021

porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Change some EXPECT_TRUE to EXPECT_EQ

Feb 18 2021, 10:58 PM · Restricted Project
porglezomp updated the diff for D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.

Change some EXPECT_TRUE to EXPECT_EQ

Feb 18 2021, 10:58 PM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Change some ASSERT_TRUE to ASSERT_EQ

Feb 18 2021, 10:58 PM · Restricted Project
porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Change Optional<Register> to Register, change a >= to == since it's all that's needed

Feb 18 2021, 6:04 PM · Restricted Project
porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Remove ";" file I accidentally added

Feb 18 2021, 12:05 PM · Restricted Project
porglezomp updated the diff for D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.

Change unittest buildInstr to more specific build* calls

Feb 18 2021, 12:03 PM · Restricted Project
porglezomp updated the diff for D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.

Change unittest buildInstr to buildSAddo/buildSSubo

Feb 18 2021, 12:00 PM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Add comment about number of defs, change buildInstr

Feb 18 2021, 11:57 AM · Restricted Project

Feb 17 2021

porglezomp added inline comments to D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.
Feb 17 2021, 6:19 PM · Restricted Project
porglezomp updated the diff for D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.

Change Optional<Register> to Register

Feb 17 2021, 10:47 AM · Restricted Project

Feb 16 2021

porglezomp added inline comments to D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.
Feb 16 2021, 11:54 PM · Restricted Project
porglezomp committed rGed7638a34d32: [vim] Highlight most common MIR syntax not in LLVM IR (authored by porglezomp).
[vim] Highlight most common MIR syntax not in LLVM IR
Feb 16 2021, 11:41 PM
porglezomp committed rGc6a96df37520: [vim] Add initial syntax definition for .mir files (authored by porglezomp).
[vim] Add initial syntax definition for .mir files
Feb 16 2021, 11:41 PM
porglezomp closed D95553: [vim] Highlight most common MIR syntax not in LLVM IR.
Feb 16 2021, 11:41 PM · Restricted Project
porglezomp closed D95552: [vim] Add initial syntax definition for .mir files.
Feb 16 2021, 11:41 PM · Restricted Project
porglezomp added a comment to D95552: [vim] Add initial syntax definition for .mir files.

I can commit them.

Feb 16 2021, 5:53 PM · Restricted Project
porglezomp added a comment to D95552: [vim] Add initial syntax definition for .mir files.

The MIR syntax is based on extending the yaml syntax and then embedding the machine-ir syntax inside it, I've defined it as two separate files so it's easier to separate "highlighting the instructions" from "embedding it inside yaml".

Feb 16 2021, 5:31 PM · Restricted Project

Feb 14 2021

porglezomp requested review of D96676: [Test][AArch64] Test SADDE/SSUBE/UADDE/USUBE narrowing legalization.
Feb 14 2021, 3:42 PM · Restricted Project
porglezomp requested review of D96675: [Test][AArch64] Test SADDO/SSUBO narrowing legalization.
Feb 14 2021, 3:42 PM · Restricted Project
porglezomp requested review of D96674: [AArch64][GlobalISel] Make overflow legalization use clampScalar.
Feb 14 2021, 3:41 PM · Restricted Project
porglezomp requested review of D96673: [GlobalISel] Implement narrowScalar for SADDE/SSUBE/UADDE/USUBE.
Feb 14 2021, 3:39 PM · Restricted Project
porglezomp requested review of D96672: [GlobalISel] Implement narrowScalar for SADDO/SSUBO.
Feb 14 2021, 3:37 PM · Restricted Project
porglezomp requested review of D96671: [GlobalISel] Implement narrowScalar for UADDO/USUBO.
Feb 14 2021, 3:36 PM · Restricted Project
porglezomp committed rG97a1cdb15618: [GlobalISel] Disable vector types in narrowScalarAddSub (authored by porglezomp).
[GlobalISel] Disable vector types in narrowScalarAddSub
Feb 14 2021, 3:07 PM
porglezomp committed rG36246388bae2: [GlobalISel] Extract a narrowScalarAddSub method. NFC (authored by porglezomp).
[GlobalISel] Extract a narrowScalarAddSub method. NFC
Feb 14 2021, 3:07 PM
porglezomp closed D95699: [GlobalISel] Disable vector types in narrowScalarAddSub.
Feb 14 2021, 3:07 PM · Restricted Project
porglezomp closed D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Feb 14 2021, 3:07 PM · Restricted Project

Feb 4 2021

porglezomp added a comment to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

ping, are there any changes this still needs? I think the existing comments are sufficiently addressed given that the goal is to make this an NFC change and fix them up separately.

Feb 4 2021, 10:42 AM · Restricted Project

Jan 29 2021

porglezomp updated the diff for D95699: [GlobalISel] Disable vector types in narrowScalarAddSub.

Use a temporary variable for the destination register/type

Jan 29 2021, 10:21 PM · Restricted Project
porglezomp requested review of D95699: [GlobalISel] Disable vector types in narrowScalarAddSub.
Jan 29 2021, 2:26 PM · Restricted Project
porglezomp updated the diff for D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

Re-add the vector code to make it more properly an NFC commit

Jan 29 2021, 2:22 PM · Restricted Project
porglezomp added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 29 2021, 11:02 AM · Restricted Project
porglezomp updated the diff for D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

Moved unreachable case to bottom of switch

Jan 29 2021, 10:23 AM · Restricted Project
porglezomp updated the diff for D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.

Add a default case assertion, mark vectors as unsupported, cleanups

Jan 29 2021, 10:16 AM · Restricted Project
porglezomp added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 29 2021, 2:37 AM · Restricted Project

Jan 28 2021

porglezomp committed rGf22f4557a749: [GlobalISel] Implement widenScalar for carry-in add/sub (authored by porglezomp).
[GlobalISel] Implement widenScalar for carry-in add/sub
Jan 28 2021, 2:06 PM
porglezomp closed D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.
Jan 28 2021, 2:06 PM · Restricted Project

Jan 27 2021

porglezomp added a comment to D95552: [vim] Add initial syntax definition for .mir files.

A question for reviewers who might be able to explain:

Jan 27 2021, 1:04 PM · Restricted Project
porglezomp requested review of D95553: [vim] Highlight most common MIR syntax not in LLVM IR.
Jan 27 2021, 11:36 AM · Restricted Project
porglezomp requested review of D95552: [vim] Add initial syntax definition for .mir files.
Jan 27 2021, 11:35 AM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Add unreachable case, give vregs names in tests

Jan 27 2021, 11:19 AM · Restricted Project
porglezomp added inline comments to D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 27 2021, 11:15 AM · Restricted Project
porglezomp committed rGcde1f54fb3fa: [Test][AArch64] Use named vregs in overflow legalization tests. NFC (authored by porglezomp).
[Test][AArch64] Use named vregs in overflow legalization tests. NFC
Jan 27 2021, 1:42 AM
porglezomp committed rG40f6599c20af: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal (authored by porglezomp).
[AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal
Jan 27 2021, 1:37 AM
porglezomp closed D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.
Jan 27 2021, 1:37 AM · Restricted Project

Jan 26 2021

porglezomp updated the diff for D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

Fix broken named vreg in legalize-ssube.mir

Jan 26 2021, 11:50 PM · Restricted Project
porglezomp updated the diff for D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

Used named vregs in test cases

Jan 26 2021, 9:32 PM · Restricted Project
porglezomp requested review of D95426: [GlobalISel] Extract a narrowScalarAddSub method. NFC.
Jan 26 2021, 1:13 AM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Add unit-tests in LegalizerHelperTest

Jan 26 2021, 12:35 AM · Restricted Project

Jan 25 2021

porglezomp committed rGfdbfda2178a7: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE (authored by porglezomp).
[Test][AArch64] Add s32 legalizer test for UADDE/USUBE
Jan 25 2021, 7:05 PM
porglezomp committed rG2ba1f9c4e0e1: [Test][AArch64] Move overflow add/sub tests to their own file. NFC (authored by porglezomp).
[Test][AArch64] Move overflow add/sub tests to their own file. NFC
Jan 25 2021, 7:05 PM
porglezomp closed D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.
Jan 25 2021, 7:05 PM · Restricted Project
porglezomp closed D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.
Jan 25 2021, 7:05 PM · Restricted Project
porglezomp committed rGaa8f3677f799: Recommit "[AArch64][GlobalISel] Implement widenScalar for signed overflow" (authored by porglezomp).
Recommit "[AArch64][GlobalISel] Implement widenScalar for signed overflow"
Jan 25 2021, 2:02 PM
porglezomp closed D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow.
Jan 25 2021, 2:02 PM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Change MachineOperand variable to Register, use getReg(0) on MachineInstrBuilder

Jan 25 2021, 11:36 AM · Restricted Project
porglezomp updated the diff for D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.

Update tests to match run-line changes

Jan 25 2021, 10:55 AM · Restricted Project
porglezomp updated the diff for D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.

Update test run line to match suggestions on D95323

Jan 25 2021, 10:54 AM · Restricted Project
porglezomp updated the diff for D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.

Update test run line to match suggestions on D95323

Jan 25 2021, 10:53 AM · Restricted Project
porglezomp updated the diff for D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.

Change the run-line for the new test files

Jan 25 2021, 10:29 AM · Restricted Project

Jan 24 2021

porglezomp requested review of D95326: [GlobalISel] Implement widenScalar for carry-in add/sub.
Jan 24 2021, 6:05 PM · Restricted Project
porglezomp requested review of D95325: [AArch64][GlobalISel] Make G_SADDE and G_SSUBE legal.
Jan 24 2021, 5:58 PM · Restricted Project
porglezomp requested review of D95324: [Test][AArch64] Add s32 legalizer test for UADDE/USUBE.
Jan 24 2021, 5:54 PM · Restricted Project
porglezomp requested review of D95323: [Test][AArch64] Move overflow add/sub tests to their own file. NFC.
Jan 24 2021, 5:53 PM · Restricted Project

Jan 22 2021

porglezomp reopened D95035: [GlobalISel] LegalizerHelper - Extract widenScalarAddoSubo method.

The buildbot with the UBSan tests passed for the first commit in this stack, so I think this should be safe to re-land http://lab.llvm.org:8011/#/builders/77/builds/3112

Jan 22 2021, 7:04 PM · Restricted Project
porglezomp abandoned D95275: [AArch64][GlobalISel] Fix instruction selection for G_USUBO.
Jan 22 2021, 7:04 PM · Restricted Project
porglezomp reopened D95034: [AArch64][GlobalISel] Implement widenScalar for signed overflow.

The buildbot with the UBSan tests passed for the first commit in this stack, so I think this should be safe to re-land http://lab.llvm.org:8011/#/builders/77/builds/3112

Jan 22 2021, 7:03 PM · Restricted Project
porglezomp added a comment to D95275: [AArch64][GlobalISel] Fix instruction selection for G_USUBO.

I also reopened D95032 with the fix squashed onto that, please review whichever of them will be more convenient.

Jan 22 2021, 4:51 PM · Restricted Project
porglezomp updated the diff for D95032: [AArch64][GlobalISel] Make G_USUBO legal and select it.

Fix instruction selection for G_USUBO

Jan 22 2021, 4:50 PM · Restricted Project