Page MenuHomePhabricator

[PowerPC][NFCI] PassSubtarget to ASMWriter
ClosedPublic

Authored by jsji on Jan 11 2021, 1:53 PM.

Details

Reviewers
sfertile
steven.zhang
Group Reviewers
Restricted Project
Commits
rG93b54b7c6733: [PowerPC][NFCI] PassSubtarget to ASMWriter
Summary

Subtarget feature bits are needed to change instprinter's behavior based
on feature bits.

Most of the other popular targets were updated back in 2015,
in https://reviews.llvm.org/rGb46d0234a6969
we should update it too.

Diff Detail

Event Timeline

jsji created this revision.Jan 11 2021, 1:53 PM
jsji requested review of this revision.Jan 11 2021, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2021, 1:53 PM
qiucf added a subscriber: qiucf.Jan 11 2021, 5:51 PM

This looks like an NFC change?

sfertile accepted this revision as: sfertile.Jan 12 2021, 7:40 AM

Thanks Jinsong, LGTM.

This looks like an NFC change?

Yep, please have [NFC] in the commit message title.

This revision is now accepted and ready to land.Jan 12 2021, 7:40 AM
jsji retitled this revision from [PowerPC] PassSubtarget to ASMWriter to [PowerPC][NFCI] PassSubtarget to ASMWriter.Jan 12 2021, 7:56 AM

Please mention the commit that added this support initially (and maybe to one or two other targets) to the commit message.

jsji edited the summary of this revision. (Show Details)Jan 12 2021, 8:07 AM
This revision was automatically updated to reflect the committed changes.