Details
Diff Detail
- Repository
- rZORG LLVM Github Zorg
Event Timeline
You are going to also want the pybind11 package. That will be the next error after the numpy error :)
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
21 | pybind11-dev is installed here, isn't it enough? |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
21 | Probably not because that is going to be the system pybind11 package, which for this OS, is quite old. The version we require is from 2020. We can just remove the install of the system version and switch to pip install, which is the most reliable way to stay current (we upped the min version after the above change was made). The cmake scripts will autodetect and use a pip version -- and this is how I've set everything else up. |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
30 | I suspect we should pin exact versions if we want reproducibility of the Docker image build, WDYT? |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
18 | Why do you use apt-get update, if you are interested in reproducibility? It actually hurts for non-pinned packages. |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
18 | That a good point as well, I was hoping that Ubuntu packages without experimental / PPA are fairly stable and should get only bug fixes? | |
18 |
I'm contrasting with python pip which is always pulling recent versions independently of the OS version. |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
30 | Let's change it to: pip install numpy==1.19.3 pybind11==2.6.0 The pybind11 version is our minimum required in the cmake, and that specific numpy version avoids some incompatibilities on Windows that affect head versions on some patch levels. I verified that both work on Windows 10. |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
18 | You pinned the base image. So you should be fine. |
buildbot/google/docker/buildbot-mlir-nvidia/Dockerfile | ||
---|---|---|
18 |
AFAIK we need to run an apt-update before we can install packages. Otherwise apt will not find them. |
Why do you use apt-get update, if you are interested in reproducibility? It actually hurts for non-pinned packages.