This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] - Dump the ELF file type better.
ClosedPublic

Authored by grimar on Dec 22 2020, 4:33 AM.

Details

Summary

Currently llvm-readelf might print "OS Specific/Processor Specific/<unknown>"
hint when dumping the ELF file type. The patch teaches llvm-readobj to do the same.

This fixes https://bugs.llvm.org/show_bug.cgi?id=40868

I am removing Object/elf-unknown-type.test test because it is not in the right place,
it is outdated and very limited.
The readobj/ELF/file-types.test checks the functionality much better.

Diff Detail

Event Timeline

grimar created this revision.Dec 22 2020, 4:33 AM
grimar requested review of this revision.Dec 22 2020, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2020, 4:33 AM
MaskRay accepted this revision.Dec 22 2020, 8:33 PM
MaskRay added inline comments.
llvm/tools/llvm-readobj/ELFDumper.cpp
3516

static

This revision is now accepted and ready to land.Dec 22 2020, 8:33 PM
This revision was automatically updated to reflect the committed changes.