This is an archive of the discontinued LLVM Phabricator instance.

Differential D93181

[NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp
ClosedPublic

Authored by t-tye on Dec 13 2020, 9:26 AM.

Details

Reviewers
kzhuravl
ronlieb
Commits
rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 windows > LLVM.CodeGen/XCore::threads.ll

Event Timeline

t-tye created this revision.Dec 13 2020, 9:26 AM
Herald added subscribers: dexonsmith, tpr, dstuttard, yaxunl. · View Herald TranscriptDec 13 2020, 9:26 AM
t-tye requested review of this revision.Dec 13 2020, 9:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2020, 9:26 AM
Herald added subscribers: cfe-commits, wdng. · View Herald Transcript
kzhuravl accepted this revision.Dec 13 2020, 9:49 AM

lgtm

This revision is now accepted and ready to land.Dec 13 2020, 9:49 AM
Harbormaster completed remote builds in B82187: Diff 311454.Dec 13 2020, 10:06 AM
This revision was landed with ongoing or failed builds.Dec 13 2020, 3:03 PM
Closed by commit rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp (authored by t-tye). · Explain Why
This revision was automatically updated to reflect the committed changes.
t-tye added a commit: rG5ad202ce8963: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp.
tra added a subscriber: tra.Dec 14 2020, 10:38 AM
tra added inline comments.
clang/lib/Basic/Cuda.cpp
75–102

These comments are kind of redundant now as they do not convey anything in addition to the macro itself.

Revision Contents

PathSize
clang/
lib/
Basic/
45 lines

Diff 311454

clang/lib/Basic/Cuda.cpp

Show First 20 Lines • Show All 66 Lines • ▼ Show 20 LinesCudaArchToStringMap arch_names[] = {
{CudaArch::UNUSED, "", ""}, {CudaArch::UNUSED, "", ""},
SM2(20, "compute_20"), SM2(21, "compute_20"), // Fermi SM2(20, "compute_20"), SM2(21, "compute_20"), // Fermi
SM(30), SM(32), SM(35), SM(37), // Kepler SM(30), SM(32), SM(35), SM(37), // Kepler
SM(50), SM(52), SM(53), // Maxwell SM(50), SM(52), SM(53), // Maxwell
SM(60), SM(61), SM(62), // Pascal SM(60), SM(61), SM(62), // Pascal
SM(70), SM(72), // Volta SM(70), SM(72), // Volta
SM(75), // Turing SM(75), // Turing
SM(80), // Ampere SM(80), // Ampere
GFX(600), // tahiti GFX(600), // gfx600
GFX(601), // pitcairn, verde GFX(601), // gfx601
GFX(602), // oland, hainan GFX(602), // gfx602
GFX(700), // kaveri GFX(700), // gfx700
GFX(701), // hawaii GFX(701), // gfx701
GFX(702), // 290,290x,R390,R390x GFX(702), // gfx702
GFX(703), // kabini mullins GFX(703), // gfx703
GFX(704), // bonaire GFX(704), // gfx704
GFX(705), GFX(705), // gfx705
GFX(801), // carrizo GFX(801), // gfx801
GFX(802), // tonga,iceland GFX(802), // gfx802
GFX(803), // fiji,polaris10 GFX(803), // gfx803
GFX(805), // tongapro GFX(805), // gfx805
GFX(810), // stoney GFX(810), // gfx810
GFX(900), // vega, instinct GFX(900), // gfx900
GFX(902), GFX(904), GFX(906), GFX(908), GFX(909), GFX(90c), GFX(902), // gfx902
GFX(1010), GFX(1011), GFX(1012), GFX(1030), GFX(1031), GFX(1032), GFX(1033) GFX(904), // gfx903
GFX(906), // gfx906
GFX(908), // gfx908
GFX(909), // gfx909
GFX(90c), // gfx90c
GFX(1010), // gfx1010
GFX(1011), // gfx1011
GFX(1012), // gfx1012
GFX(1030), // gfx1030
GFX(1031), // gfx1031
GFX(1032), // gfx1032
GFX(1033), // gfx1033
traUnsubmitted
Not Done
ReplyInline Actions

These comments are kind of redundant now as they do not convey anything in addition to the macro itself.

tra: These comments are kind of redundant now as they do not convey anything in addition to the…
// clang-format on // clang-format on
}; };
#undef SM #undef SM
#undef SM2 #undef SM2
#undef GFX #undef GFX
const char *CudaArchToString(CudaArch A) { const char *CudaArchToString(CudaArch A) {
auto result = std::find_if( auto result = std::find_if(
▲ Show 20 Lines • Show All 120 Lines • Show Last 20 Lines