[NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern.
ClosedPublic
Actions

Authored by jurahul on Dec 9 2020, 6:18 PM.

Details

Reviewers

aartbik
ftynse
jdoerfert
herhut

Commits

rG563879b6f946: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern.

Summary

use ConvertOpToLLVMPattern to avoid explicit casting and in most cases the constructor can be reused to saves a few lines of code.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jurahul created this revision.Dec 9 2020, 6:18 PM

Herald added a reviewer: aartbik. · View Herald TranscriptDec 9 2020, 6:18 PM

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added subscribers: mravishankar, teijeong, rdzhabarov and 17 others. · View Herald Transcript

jurahul requested review of this revision.Dec 9 2020, 6:18 PM

Herald added a reviewer: jdoerfert. · View Herald TranscriptDec 9 2020, 6:18 PM

Herald added a reviewer: herhut. · View Herald Transcript

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B81754: Diff 310740.Dec 9 2020, 8:51 PM

ftynse accepted this revision.Dec 10 2020, 12:46 AM

This revision is now accepted and ready to land.Dec 10 2020, 12:46 AM

This revision was landed with ongoing or failed builds.Dec 10 2020, 9:34 AM

Closed by commit rG563879b6f946: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern. (authored by jurahul). · Explain Why

This revision was automatically updated to reflect the committed changes.

jurahul added a commit: rG563879b6f946: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern..

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Conversion/

LinalgToLLVM/

LinalgToLLVM.h

3 lines

OpenMPToLLVM/

ConvertOpenMPToLLVM.h

3 lines

StandardToLLVM/

ConvertStandardToLLVM.h

4 lines

lib/

Conversion/

AVX512ToLLVM/

ConvertAVX512ToLLVM.cpp

60 lines

GPUCommon/

GPUOpsLowering.h

19 lines

IndexIntrinsicsOpLowering.h

10 lines

OpToFuncCallLowering.h

9 lines

GPUToNVVM/

LowerGpuOpsToNVVMOps.cpp

8 lines

LinalgToLLVM/

LinalgToLLVM.cpp

55 lines

OpenMPToLLVM/

OpenMPToLLVM.cpp

23 lines

VectorToLLVM/

ConvertVectorToLLVM.cpp

350 lines

VectorToROCDL/

VectorToROCDL.cpp

27 lines

Diff 310939

View Options

mlir/include/mlir/Conversion/LinalgToLLVM/LinalgToLLVM.h

View Options

mlir/include/mlir/Conversion/OpenMPToLLVM/ConvertOpenMPToLLVM.h

View Options

mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h

View Options

mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp

View Options

mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h

View Options

mlir/lib/Conversion/GPUCommon/IndexIntrinsicsOpLowering.h

View Options

mlir/lib/Conversion/GPUCommon/OpToFuncCallLowering.h

View Options

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp

View Options

mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp

View Options

mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp

View Options

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

View Options

mlir/lib/Conversion/VectorToROCDL/VectorToROCDL.cpp

[NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 310939

mlir/include/mlir/Conversion/LinalgToLLVM/LinalgToLLVM.h

mlir/include/mlir/Conversion/OpenMPToLLVM/ConvertOpenMPToLLVM.h

mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h

mlir/lib/Conversion/AVX512ToLLVM/ConvertAVX512ToLLVM.cpp

mlir/lib/Conversion/GPUCommon/GPUOpsLowering.h

mlir/lib/Conversion/GPUCommon/IndexIntrinsicsOpLowering.h

mlir/lib/Conversion/GPUCommon/OpToFuncCallLowering.h

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp

mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp

mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp

mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp

mlir/lib/Conversion/VectorToROCDL/VectorToROCDL.cpp

[NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern.
ClosedPublic
Actions

Revision Contents
Changeset List