Page MenuHomePhabricator

[mlir][OpFormatGen] Add support for optional enum attributes
ClosedPublic

Authored by rriddle on Dec 4 2020, 6:57 PM.

Details

Summary

The check for formatting enum attributes was missing a call to get the base attribute, which is necessary to strip off the top-level OptionalAttr<> wrapper.

Diff Detail

Event Timeline

rriddle created this revision.Dec 4 2020, 6:57 PM
rriddle requested review of this revision.Dec 4 2020, 6:57 PM
mehdi_amini accepted this revision.Dec 4 2020, 6:59 PM
This revision is now accepted and ready to land.Dec 4 2020, 6:59 PM
jpienaar accepted this revision.Dec 4 2020, 7:10 PM
jpienaar added a subscriber: jpienaar.

Ha ran into this last week, thanks!