[lldb] set created function decl to public access in TypeSystemClang

[zequanwu]

Summary

Test case stack_unwinding01.cpp crashed in Debug build of lldb on Windows due to access specifier not set for function decl.

[teemperor]

D85993 was trying to do the same thing and contains some explanation why I think this isn't a good solution. TL;DR is that functions in a record should call TypeSystemClang::AddMethodToCXXRecordType instead. Moving the isRecord check you add here to the PDB parser code and then calling AddMethodToCXXRecordType depending on whether the check is true/false is one way to fix this properly.

[shafik]

+1 to what @teemperor said

[zequanwu]

Adrian said he will work on this, so I abandoned this.

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

FunctionDecl *TypeSystemClang::CreateFunctionDeclaration(
   func_decl->setDeclName(declarationName);
   func_decl->setType(ClangUtil::GetQualType(function_clang_type));
   func_decl->setStorageClass(storage);
   func_decl->setInlineSpecified(is_inline);
   func_decl->setHasWrittenPrototype(hasWrittenPrototype);
   func_decl->setConstexprKind(isConstexprSpecified
                                   ? ConstexprSpecKind::Constexpr
                                   : ConstexprSpecKind::Unspecified);
+  if (decl_ctx->isRecord())
+    func_decl->setAccess(clang::AccessSpecifier::AS_public);
   SetOwningModule(func_decl, owning_module);
   if (func_decl)
     decl_ctx->addDecl(func_decl);
 
   VerifyDecl(func_decl);
 
   return func_decl;
 }