This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readelf/obj] - Refine the error message about the broken string table.
ClosedPublic

Authored by grimar on Dec 1 2020, 3:49 AM.

Details

Summary

This:

  1. Changes reportWarning to reportUniqueWarning (no-op here).
  2. Adds more context to the message.
  3. Merges broken-dynsym-link.test into dyn-symbols.test, adds more testing.

Diff Detail

Event Timeline

grimar created this revision.Dec 1 2020, 3:49 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Dec 1 2020, 3:49 AM
MaskRay accepted this revision.Dec 1 2020, 6:32 PM
MaskRay added inline comments.
llvm/tools/llvm-readobj/ELFDumper.cpp
2047

Other messages don't prepend the

This revision is now accepted and ready to land.Dec 1 2020, 6:32 PM
grimar marked an inline comment as done.Dec 2 2020, 1:13 AM
grimar added inline comments.
llvm/tools/llvm-readobj/ELFDumper.cpp
2047

You mean before "decribe(Sec)"? In a few places we have it.

This revision was automatically updated to reflect the committed changes.
grimar marked an inline comment as done.