Page MenuHomePhabricator

[llvm-readelf/obj] - Remove `tryGetSectionName` helper.
ClosedPublic

Authored by grimar on Nov 23 2020, 3:25 AM.

Details

Summary

D91867 introduced the tryGetSectionName helper.
But we have getPrintableSectionName member with the similar
behavior which we can reuse. This patch does it.

Diff Detail

Event Timeline

grimar created this revision.Nov 23 2020, 3:25 AM
Herald added a project: Restricted Project. · View Herald Transcript
grimar requested review of this revision.Nov 23 2020, 3:25 AM
jhenderson accepted this revision.Nov 23 2020, 4:28 AM

I thought there was a function that did this already. Sorry, should have mentioned it in the previous review. LGTM.

This revision is now accepted and ready to land.Nov 23 2020, 4:28 AM

I thought there was a function that did this already. Sorry, should have mentioned it in the previous review. LGTM.

I also thought we have one. But could not find it when wrote the patch for some reason and supposed that it was removed...

This revision was automatically updated to reflect the committed changes.