This is an archive of the discontinued LLVM Phabricator instance.

Differential D91889

[flang][openacc] Add clause validity tests for the host_data directive
ClosedPublic

Authored by clementval on Nov 20 2020, 12:49 PM.

Details

Reviewers
kiranchandramohan
kiranktp
sscalpone
sameeranjoshi
SouraVX
tskeith
klausler
Commits
rG553e364194ac: [flang][openacc] Add clause validity tests for the host_data directive
Summary

Add some clause validity tests for the host_data directive to avoid future regressions.

Diff Detail

Event Timeline

clementval created this revision.Nov 20 2020, 12:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 20 2020, 12:49 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
clementval requested review of this revision.Nov 20 2020, 12:49 PM
Harbormaster completed remote builds in B79648: Diff 306767.Nov 20 2020, 1:06 PM
kiranchandramohan accepted this revision.Nov 20 2020, 2:10 PM

LGTM.

This revision is now accepted and ready to land.Nov 20 2020, 2:10 PM
clementval added a comment.Nov 20 2020, 5:05 PM
In D91889#2409013, @kiranchandramohan wrote:

LGTM.

Thanks for the reviews!

clementval updated this revision to Diff 306809.Nov 20 2020, 5:10 PM

Rebase

This revision was landed with ongoing or failed builds.Nov 20 2020, 5:17 PM
Closed by commit rG553e364194ac: [flang][openacc] Add clause validity tests for the host_data directive (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rG553e364194ac: [flang][openacc] Add clause validity tests for the host_data directive.
Harbormaster completed remote builds in B79668: Diff 306809.Nov 20 2020, 5:31 PM

Revision Contents

PathSize
flang/
test/
Semantics/
17 lines

Diff 306767

flang/test/Semantics/acc-clause-validity.f90

Show All 21 Linesprogram openacc_clause_validity
implicit none implicit none
integer :: i, j, b, gang_size, vector_size, worker_size integer :: i, j, b, gang_size, vector_size, worker_size
integer, parameter :: N = 256 integer, parameter :: N = 256
integer, dimension(N) :: c integer, dimension(N) :: c
logical, dimension(N) :: d, e logical, dimension(N) :: d, e
real :: reduction_r real :: reduction_r
logical :: reduction_l logical :: reduction_l
real(8), dimension(N, N) :: aa real(8), dimension(N, N) :: aa, bb
logical :: ifCondition = .TRUE. logical :: ifCondition = .TRUE.
!ERROR: At least one clause is required on the DECLARE directive !ERROR: At least one clause is required on the DECLARE directive
!$acc declare !$acc declare
real(8), dimension(N) :: a, f, g, h real(8), dimension(N) :: a, f, g, h
!$acc init !$acc init
!$acc init if(.TRUE.) !$acc init if(.TRUE.)
▲ Show 20 Lines • Show All 55 Lines • ▼ Show 20 Linesprogram openacc_clause_validity
!ERROR: At least one of COPYOUT, DELETE, DETACH clause must appear on the EXIT DATA directive !ERROR: At least one of COPYOUT, DELETE, DETACH clause must appear on the EXIT DATA directive
!$acc exit data !$acc exit data
!ERROR: At least one of USE_DEVICE clause must appear on the HOST_DATA directive !ERROR: At least one of USE_DEVICE clause must appear on the HOST_DATA directive
!$acc host_data !$acc host_data
!$acc end host_data !$acc end host_data
!$acc host_data use_device(aa)
!$acc end host_data
!$acc host_data use_device(aa) if(.true.)
!$acc end host_data
!$acc host_data use_device(aa) if(ifCondition)
!$acc end host_data
!$acc host_data use_device(aa, bb) if_present
!$acc end host_data
!$acc host_data use_device(aa, bb) if(.true.) if_present
!$acc end host_data
!ERROR: At least one of DEFAULT_ASYNC, DEVICE_NUM, DEVICE_TYPE clause must appear on the SET directive !ERROR: At least one of DEFAULT_ASYNC, DEVICE_NUM, DEVICE_TYPE clause must appear on the SET directive
!$acc set !$acc set
!ERROR: At least one of ATTACH, COPY, COPYIN, COPYOUT, CREATE, DEFAULT, DEVICEPTR, NO_CREATE, PRESENT clause must appear on the DATA directive !ERROR: At least one of ATTACH, COPY, COPYIN, COPYOUT, CREATE, DEFAULT, DEVICEPTR, NO_CREATE, PRESENT clause must appear on the DATA directive
!$acc data !$acc data
!$acc end data !$acc end data
!$acc data copyin(i) !$acc data copyin(i)
▲ Show 20 Lines • Show All 437 Lines • Show Last 20 Lines