Extract the scratch offset from the scratch buffer descriptor that is
stored in the global table.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
390 ms | linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp |
Event Timeline
llvm/lib/Target/AMDGPU/SIFrameLowering.cpp | ||
---|---|---|
320 |
The autoformatter complained about that, shall I do it anyway?
I’m not sure? In the if-branch, TargetHi is defined, in the else-branch the whole TargetReg is defined. |
llvm/lib/Target/AMDGPU/SIFrameLowering.cpp | ||
---|---|---|
320 | The formatter is stupid and should be ignored |
llvm/lib/Target/AMDGPU/SIFrameLowering.cpp | ||
---|---|---|
320 | I mean in the final ISA TergetLo will be defined first, so probably it is TargetLo should carry implicit def of the super-reg? |
llvm/lib/Target/AMDGPU/SIFrameLowering.cpp | ||
---|---|---|
320 | The ISA looks like this: s_getpc_b64 s[0:1] <- Created else-branch before, explicitly defines TargetReg s_mov_b32 s0, s8 <- This move replaces the lower register (TargetLo) So I think the first definition the whole register is in the if-else and this move does not need an implicit-def anymore? |
clang-format: please reformat the code