This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Extend and reorganize memory legalizer tests
ClosedPublic

Authored by scott.linder on Nov 16 2020, 8:00 AM.

Details

Summary
  • Rename some tests to try to make a convention (where all components are optional) of:

    <addrspace>_<syncscope>_<memory-orders>_<operation>
  • Split up at a level of granularity appropriate for the different RUN lines (i.e. split on addrspace so GFX6 can avoid FLAT) and that makes running a specific test reasonable in terms of wall time taken. This also means when run as part of the test suite the testing is not one serial bottleneck.
  • Auto-generate check lines with update_llc_test_checks.py to make future maintenance more tractable.

Diff Detail

Event Timeline

scott.linder created this revision.Nov 16 2020, 8:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 8:00 AM
scott.linder requested review of this revision.Nov 16 2020, 8:00 AM

Latest changes in this direction are already pretty invasive. If you run lit tests with a debug compiler build these combined tests take minutes to complete. If you need to debug something there it is very slow, and if you just run make check it is very slow, I assume because otherwise several smaller tests could run in parallel. They also take minutes if not tenth of minutes to load into a browser for review. So I would rather split these tests, not combine them.

scott.linder retitled this revision from [AMDGPU] Consolidate memory-legalizer tests to [AMDGPU] Extend and reorganize memory legalizer tests.
scott.linder edited the summary of this revision. (Show Details)

Split up tests on combinations of addrspace, memory scope, memory ordering, and operation. I felt this was a reasonable amount of tests, but I can split things down further if needed.

rampitec accepted this revision.Nov 17 2020, 4:38 PM

LGTM, but please also check with Tony.

This revision is now accepted and ready to land.Nov 17 2020, 4:38 PM
t-tye accepted this revision.Nov 20 2020, 1:23 PM

LGTM

Reviewed script that produces the new organization of the tests.

I somehow managed to omit deleting the old tests in the last patchset. I think it was implied that I would, but I'm pushing up to make sure there aren't any objections (and I didn't make any mistakes).

t-tye accepted this revision.Nov 20 2020, 3:00 PM

LGTM

This revision was landed with ongoing or failed builds.Dec 3 2020, 11:37 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/CodeGen/AMDGPU/memory-legalizer-local-wavefront.ll