This is an archive of the discontinued LLVM Phabricator instance.

Differential D91519

[AST][Mach0] Fix unused-variable warnings
ClosedPublic

Authored by ehjogab on Nov 16 2020, 12:57 AM.

Details

Reviewers
dsanders
arsenm
qcolombet
ab
bjope
rovka
Commits
rG2d1f471e45af: [Mach0] Fix unused-variable warnings
Summary

Change-Id: Id37948be57aad3551eb14fc16b2aea2441a45e7d

Diff Detail

Unit TestsFailed

TimeTest
370 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
80 mslinux > SanitizerCommon-Unit._/Sanitizer-x86_64-Test::SanitizerCommon.StackDepotPrint

Event Timeline

ehjogab created this revision.Nov 16 2020, 12:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 12:57 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ehjogab requested review of this revision.Nov 16 2020, 12:57 AM
Herald added a subscriber: wdng. · View Herald TranscriptNov 16 2020, 12:57 AM
Harbormaster completed remote builds in B78928: Diff 305424.Nov 16 2020, 1:29 AM
arsenm added inline comments.Nov 16 2020, 6:40 AM
lld/MachO/SymbolTable.cpp
137

Should use isa

ehjogab updated this revision to Diff 305984.Nov 17 2020, 11:21 PM

Replace dyn_cast with isa

ehjogab marked an inline comment as done.Nov 17 2020, 11:22 PM
Harbormaster completed remote builds in B79233: Diff 305984.Nov 17 2020, 11:55 PM
arsenm accepted this revision.Nov 18 2020, 6:59 AM
This revision is now accepted and ready to land.Nov 18 2020, 6:59 AM
This revision was landed with ongoing or failed builds.Nov 19 2020, 1:52 AM
Closed by commit rG2d1f471e45af: [Mach0] Fix unused-variable warnings (authored by ehjogab, committed by dstenb). · Explain Why
This revision was automatically updated to reflect the committed changes.
dstenb added a commit: rG2d1f471e45af: [Mach0] Fix unused-variable warnings.
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2020, 1:52 AM

Revision Contents

PathSize
clang/
lib/
AST/
2 lines
lld/
MachO/
2 lines

Diff 305424

clang/lib/AST/APValue.cpp

//===--- APValue.cpp - Union class for APFloat/APSInt/Complex -------------===// //===--- APValue.cpp - Union class for APFloat/APSInt/Complex -------------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 1,048 Lines • ▼ Show 20 Lines for (unsigned I = 0, N = V.getStructNumBases(); I != N; ++I)
break; break;
for (unsigned I = 0, N = V.getStructNumFields(); I != N; ++I) for (unsigned I = 0, N = V.getStructNumFields(); I != N; ++I)
if (Merge(V.getStructField(I))) if (Merge(V.getStructField(I)))
break; break;
break; break;
} }
case APValue::Union: case APValue::Union:
if (const auto *FD = V.getUnionField()) if (V.getUnionField())
Merge(V.getUnionValue()); Merge(V.getUnionValue());
break; break;
case APValue::Array: { case APValue::Array: {
for (unsigned I = 0, N = V.getArrayInitializedElts(); I != N; ++I) for (unsigned I = 0, N = V.getArrayInitializedElts(); I != N; ++I)
if (Merge(V.getArrayInitializedElt(I))) if (Merge(V.getArrayInitializedElt(I)))
break; break;
if (V.hasArrayFiller()) if (V.hasArrayFiller())
▲ Show 20 Lines • Show All 47 Lines • Show Last 20 Lines

lld/MachO/SymbolTable.cpp

//===- SymbolTable.cpp ----------------------------------------------------===// //===- SymbolTable.cpp ----------------------------------------------------===//
Lint: Lint
Inline Actions

clang-format not found in user's PATH; not linting file.

Lint: Lint: clang-format not found in user's PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Lines
Symbol *SymbolTable::addDSOHandle(const MachHeaderSection *header) { Symbol *SymbolTable::addDSOHandle(const MachHeaderSection *header) {
Symbol *s; Symbol *s;
bool wasInserted; bool wasInserted;
std::tie(s, wasInserted) = insert(DSOHandle::name); std::tie(s, wasInserted) = insert(DSOHandle::name);
if (!wasInserted) { if (!wasInserted) {
// FIXME: Make every symbol (including absolute symbols) contain a // FIXME: Make every symbol (including absolute symbols) contain a
// reference to their originating file, then add that file name to this // reference to their originating file, then add that file name to this
// error message. // error message.
if (auto *defined = dyn_cast<Defined>(s)) if (dyn_cast<Defined>(s))
Lint: Pre-merge checks
Inline Actions

clang-tidy: warning: return value from dyn_cast<> not used [llvm-prefer-isa-or-dyn-cast-in-conditionals]
not useful

Lint: Pre-merge checks: clang-tidy: warning: return value from dyn_cast<> not used [llvm-prefer-isa-or-dyn-cast-in…
arsenmUnsubmitted
Done
ReplyInline Actions

Should use isa

arsenm: Should use isa
error("found defined symbol with illegal name " + DSOHandle::name); error("found defined symbol with illegal name " + DSOHandle::name);
} }
replaceSymbol<DSOHandle>(s, header); replaceSymbol<DSOHandle>(s, header);
return s; return s;
} }
SymbolTable *macho::symtab; SymbolTable *macho::symtab;