This is an archive of the discontinued LLVM Phabricator instance.

Differential D91519

[AST][Mach0] Fix unused-variable warnings
ClosedPublic

Authored by ehjogab on Nov 16 2020, 12:57 AM.

Download Raw Diff

Details

Reviewers

dsanders
arsenm
qcolombet
ab
bjope
rovka

Commits

rG2d1f471e45af: [Mach0] Fix unused-variable warnings

Summary

Change-Id: Id37948be57aad3551eb14fc16b2aea2441a45e7d

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ehjogab created this revision.Nov 16 2020, 12:57 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 16 2020, 12:57 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

ehjogab requested review of this revision.Nov 16 2020, 12:57 AM

Herald added a subscriber: wdng. · View Herald TranscriptNov 16 2020, 12:57 AM

Harbormaster completed remote builds in B78928: Diff 305424.Nov 16 2020, 1:29 AM

arsenm added inline comments.Nov 16 2020, 6:40 AM

lld/MachO/SymbolTable.cpp
137	Should use isa

Replace dyn_cast with isa

ehjogab marked an inline comment as done.Nov 17 2020, 11:22 PM

Harbormaster completed remote builds in B79233: Diff 305984.Nov 17 2020, 11:55 PM

arsenm accepted this revision.Nov 18 2020, 6:59 AM

This revision is now accepted and ready to land.Nov 18 2020, 6:59 AM

This revision was landed with ongoing or failed builds.Nov 19 2020, 1:52 AM

Closed by commit rG2d1f471e45af: [Mach0] Fix unused-variable warnings (authored by ehjogab, committed by dstenb). · Explain Why

This revision was automatically updated to reflect the committed changes.

dstenb added a commit: rG2d1f471e45af: [Mach0] Fix unused-variable warnings.

Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2020, 1:52 AM

Revision Contents

Path

Size

lld/

MachO/

SymbolTable.cpp

2 lines

Diff 306339

lld/MachO/SymbolTable.cpp

	Show First 20 Lines • Show All 128 Lines • ▼ Show 20 Lines
	Symbol SymbolTable::addDSOHandle(const MachHeaderSection header) {			Symbol SymbolTable::addDSOHandle(const MachHeaderSection header) {
	Symbol *s;			Symbol *s;
	bool wasInserted;			bool wasInserted;
	std::tie(s, wasInserted) = insert(DSOHandle::name);			std::tie(s, wasInserted) = insert(DSOHandle::name);
	if (!wasInserted) {			if (!wasInserted) {
	// FIXME: Make every symbol (including absolute symbols) contain a			// FIXME: Make every symbol (including absolute symbols) contain a
	// reference to their originating file, then add that file name to this			// reference to their originating file, then add that file name to this
	// error message.			// error message.
	if (auto *defined = dyn_cast<Defined>(s))			if (isa<Defined>(s))
				arsenmUnsubmitted Done Reply Inline Actions Should use isa arsenm: Should use isa
	error("found defined symbol with illegal name " + DSOHandle::name);			error("found defined symbol with illegal name " + DSOHandle::name);
	}			}
	replaceSymbol<DSOHandle>(s, header);			replaceSymbol<DSOHandle>(s, header);
	return s;			return s;
	}			}

	SymbolTable *macho::symtab;			SymbolTable *macho::symtab;