The code seemed not to account for the field 1 offset. This patch hopefully fixes that issue.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
| Time | Test | |
|---|---|---|
| 40 ms | x64 windows > LLVM.CodeGen/XCore::threads.ll Script:
--
: 'RUN: at line 1'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\llc.exe -march=xcore < C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll
|
Event Timeline
Comment Actions
I *think* this is looking good, but I'd like a second pair of eyes from @jrtc27 as I know she's fixed bugs around this area recently too. We would like to have this ready for 11.0.1 if possible.
| clang/lib/CodeGen/TargetInfo.cpp | ||
|---|---|---|
| 10595 | Please may you update this name to reflect what it really is - the offset of the *end* of Field1, rather than its size. This code is complex enough without confusing names. :) | |
Comment Actions
Seems good other than additional comments regarding code clarity.
| clang/lib/CodeGen/TargetInfo.cpp | ||
|---|---|---|
| 10567 | This NFC hunk definitely makes this clearer :) | |
| 10595 | +1 to Field1End or similar | |
| 10596–10597 | Swapping the order of the operands would be the more natural way to express this. | |