Paths

Table of Contentst

Differential D91278

[Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex
ClosedPublic
Actions

Authored by luismarques on Nov 11 2020, 9:31 AM.

Details

Reviewers

asb
lenary
rjmccall
efriedma

Summary

Fixes bug 44904.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	90 ms	x64 windows > LLVM.CodeGen/XCore::threads.ll Script: -- : 'RUN: at line 1'; c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\llc.exe -march=xcore < C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll \| c:\ws\w16n2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16n2-1\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll

Event Timeline

luismarques created this revision.Nov 11 2020, 9:31 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 11 2020, 9:31 AM

Herald added subscribers: cfe-commits, frasercrmck, NickHung and 24 others. · View Herald Transcript

luismarques requested review of this revision.Nov 11 2020, 9:31 AM

luismarques added a parent revision: D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct.

Fix bad test.

Harbormaster completed remote builds in B78480: Diff 304551.Nov 11 2020, 11:01 AM

Harbormaster completed remote builds in B78483: Diff 304554.Nov 11 2020, 11:04 AM

LGTM - the big hint is that the new test is handled the same as f_empty_double2 as required by the ABI.

clang/test/CodeGen/riscv32-ilp32d-abi.cpp
36	Please can you add a test of `{ struct {}; float _Complex fc;}` too, just for regression purposes?

lenary accepted this revision.Nov 30 2020, 2:34 PM

This revision is now accepted and ready to land.Nov 30 2020, 2:34 PM

Add float Complex case, for regression test completeness.

luismarques marked an inline comment as done.Dec 7 2020, 12:27 PM

LGTM

Harbormaster completed remote builds in B81342: Diff 309991.Dec 7 2020, 2:16 PM

luismarques closed this revision.Dec 8 2020, 3:27 AM

Revision Contents
Changeset List

Path

Size

clang/

lib/

CodeGen/

1 line

test/

CodeGen/

riscv32-ilp32d-abi.cpp

16 lines

Diff 309991

clang/lib/CodeGen/TargetInfo.cpp

Loading...

clang/test/CodeGen/riscv32-ilp32d-abi.cpp

Loading...