new worker and builder for clangd

[kuhnel]

Summary

Adding new worker and builder to cover remote indexing feature of clangd.

[kbobyrev]

buildbot/osuosl/master/config/workers.py

210

nit: typo here and above in "Ubuntu"

[kuhnel]

fixed typos

[sammccall]

Thanks so much for doing this!

buildbot/osuosl/master/config/builders.py

1863

nit: tsan or TSan (though the builders seem to be conventionally all-lowercase)

1867

can we add checks=['check-clangd']?

As well as being faster, building/testing clangd without building clang is something we want to work. (clangd doesn't have a dependency on all of clang).
See D90518 where this was broken for months and we didn't know.

1870

Don't we need -DCMAKE_CXX_COMPILER=clang++ or clang++-11 or so? (and ditto -DCMAKE_C_COMPILER)

[kuhnel]

addressed Sam's comments

[kuhnel]

buildbot/osuosl/master/config/builders.py

1870

You're right, CMake was using GCC. Let me set the environment variable in the Docker container, as we're configuring the other build tools there.

[kuhnel]

removed stray edit to Dockerfile

[kbobyrev]

buildbot/osuosl/master/config/workers.py

211

Also, is this the correct reference? terraform/main.tf seems to have Windows buildbot configs https://reviews.llvm.org/rZORG0e2cebb40db7ff0a5e10f02041f1c3a6c106b937

[kuhnel]

@kbobyrev Yes, the main.tf was a dirty working copy. I fixed that now.

buildbot/osuosl/master/config/builders.py

'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
                     depends_on_projects=['llvm'],
                     extra_configure_args= [
                         "-DCMAKE_BUILD_TYPE=Release",
                         "-DLLVM_CCACHE_BUILD=ON",
                         "-DLLVM_ENABLE_ASSERTIONS=ON",
                         "-DTENSORFLOW_AOT_PATH=/var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow"
                     ])},
 
+    # build clangd with remote-index enabled and check with TSAN
+    {'name': "clangd-ubuntu-TSAN",
+     'tags': ["clangd"],
+     'workernames': ["clangd-ubuntu-clang"],
+     'builddir': "clangd-ubuntu-TSAN",
+     'factory': UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory(
+         clean=True,
+         depends_on_projects=['"clang;clang-tools-extra'],
+         extra_configure_args=[
+             '-DLLVM_CCACHE_BUILD="ON"',
+             '-DLLVM_USE_SANITIZER="Thread"',
+             '-DCMAKE_BUILD_TYPE="RELEASE"',
+             '-DCLANGD_ENABLE_REMOTE="ON"',
+             '-DLLVM_ENABLE_ASSERTIONS="ON"',
+         ])},
+
+
 ]

buildbot/osuosl/master/config/workers.py

return [
         create_worker("windows7-buildbot", properties={'jobs': 2}, max_builds=1),
 
         # Windows 10, Visual Studio 2019, Google Cloud 16 cores
         create_worker("windows10-vs2019", properties={'jobs': 32}, max_builds=1),
 
         # CentOS 7.5.1804 on Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, 96GB RAM
         create_worker("nec-arrproto41", properties={'jobs': 12}, max_builds=1),
 
-        # Uubntu 18.04 amd64 on Google Cloud, 16 core, Nvidia Tesla T4
+        # Ubuntu 18.04 amd64 on Google Cloud, 16 core, Nvidia Tesla T4
         create_worker("mlir-nvidia", properties={'jobs': 16}, max_builds=1),
 
+        # Ubuntu 18.04 on Google Cloud, for machine configuration check
+        # buildbot/google/terraform/main.tf
+        create_worker("clangd-ubuntu-clang", max_builds=1),
+
         # Ubuntu 18.04.LTS x86_64, GCE instance
         create_worker("polly-x86_64-gce1", properties={'jobs': 2}, max_builds=1),
         create_worker("polly-x86_64-gce2", properties={'jobs': 2}, max_builds=1),
 
         # Ubuntu 18.04.LTS x86_64, Intel(R) Xeon(R) CPU X3460 @ 2.80GHz, 32 GiB RAM
         create_worker("polly-x86_64-fdcserver", properties={'jobs': 8, 'loadaverage': 8}, max_builds=1),
 
         create_worker("flang-aarch64-ubuntu-build"),