This is an archive of the discontinued LLVM Phabricator instance.

Differential D90802

[OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]
ClosedPublic

Authored by dreachem on Nov 4 2020, 3:21 PM.

Details

Reviewers
kkwli0
jdoerfert
ABataev
RaviNarayanaswamy
Commits
rG7046be17307d: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]
Summary

Adding features in OpenMP 5.1 specification, as documented in feature change history, to the 5.1 table. I alphabetized the rows of the table according to the category. For deprecating master construct, I just used 'other' as the category.

Diff Detail

Event Timeline

dreachem created this revision.Nov 4 2020, 3:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 4 2020, 3:21 PM
Herald added subscribers: cfe-commits, jfb, guansong, yaxunl. · View Herald Transcript
dreachem requested review of this revision.Nov 4 2020, 3:21 PM
Herald added a subscriber: sstefan1. · View Herald TranscriptNov 4 2020, 3:21 PM
jdoerfert added inline comments.Nov 4 2020, 3:36 PM
clang/docs/OpenMPSupport.rst
343

What is missing here?

Harbormaster completed remote builds in B77621: Diff 302982.Nov 4 2020, 4:01 PM
dreachem added inline comments.Nov 5 2020, 7:11 AM
clang/docs/OpenMPSupport.rst
343

This is from the original table. Is this referring to begin/end declare variant feature, which I also added? If so, I should remove that one.

jdoerfert accepted this revision.Nov 5 2020, 1:53 PM

LGTM

clang/docs/OpenMPSupport.rst
343

yes. remove this and mark begin/end declare variant as done.

This revision is now accepted and ready to land.Nov 5 2020, 1:53 PM
dreachem updated this revision to Diff 303258.Nov 5 2020, 2:05 PM

Marking the "begin/end declare variant" feature as 'done' in the 5.1 table.

dreachem added a comment.Nov 5 2020, 2:10 PM

I don't have commit access. @jdoerfert, please commit the change if you think it's ready. Thanks.

Closed by commit rG7046be17307d: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC] (authored by dreachem, committed by cchen). · Explain WhyNov 18 2020, 8:47 AM
This revision was automatically updated to reflect the committed changes.
cchen added a commit: rG7046be17307d: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC].

Revision Contents

PathSize
clang/
docs/
90 lines

Diff 306131

clang/docs/OpenMPSupport.rst

Show First 20 Lines • Show All 258 Lines • ▼ Show 20 Lines
The following table provides a quick overview over various OpenMP 5.1 features The following table provides a quick overview over various OpenMP 5.1 features
and their implementation status, as defined in the technical report 8 (TR8). and their implementation status, as defined in the technical report 8 (TR8).
Please contact *openmp-dev* at *lists.llvm.org* for more information or if you Please contact *openmp-dev* at *lists.llvm.org* for more information or if you
want to help with the implementation. want to help with the implementation.
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
|Category | Feature | Status | Reviews | |Category | Feature | Status | Reviews |
+==============================+==============================================================+==========================+=======================================================================+ +==============================+==============================================================+==========================+=======================================================================+
| misc extension | user-defined function variants with #ifdef protection | :part:`worked on` | D71179 | | atomic extension | 'compare' and 'fail' clauses on atomic construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | default(firstprivate) & default(private) | :part:`partial` | firstprivate done: D75591 | | base language | C++ attribute specifier syntax | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| loop extension | Loop tiling transformation | :part:`worked on` | D76342 |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | 'present' map type modifier | :good:`done` | D83061, D83062, D84422 | | device extension | 'present' map type modifier | :good:`done` | D83061, D83062, D84422 |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | 'present' motion modifier | :good:`done` | D84711, D84712 | | device extension | 'present' motion modifier | :good:`done` | D84711, D84712 |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | 'present' in defaultmap clause | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | map clause reordering reordering based on 'present' modifier | :none:`unclaimed` | | | device extension | map clause reordering reordering based on 'present' modifier | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | device-specific environment variables | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | omp_target_is_accessible routine | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | omp_get_mapped_ptr routine | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | new async target memory copy routines | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | thread_limit clause on target construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | has_device_addr clause on target construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | iterators in map clause or motion clauses | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | indirect clause on declare target directive | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | allow virtual functions calls for mapped object on device | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | interop construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| device extension | assorted routines for querying interoperable properties | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| loop extension | Loop tiling transformation | :part:`worked on` | D76342 |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| loop extension | Loop unrolling transformation | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| loop extension | 'reproducible'/'unconstrained' modifiers in 'order' clause | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| memory management | alignment extensions for allocate directive and clause | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| memory management | new memory management routines | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| memory management | changes to omp_alloctrait_key enum | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| memory model extension | seq_cst clause on flush construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | 'omp_all_memory' keyword and use in 'depend' clause | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | error directive | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | scope construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | routines for controlling and querying team regions | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | changes to ompt_scope_endpoint_t enum | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | omp_display_env routine | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | extended OMP_PLACES syntax | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | OMP_NUM_TEAMS and OMP_TEAMS_THREAD_LIMIT env vars | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | 'target_device' selector in context specifier | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | begin/end declare variant | :good:`done` | D71179 |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | dispatch construct and function variant argument adjustment | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | assume and assumes directives | :part:`worked on` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | nothing directive | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | masked construct and related combined constructs | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| misc extension | default(firstprivate) & default(private) | :part:`partial` | firstprivate done: D75591 |
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

What is missing here?

jdoerfert: What is missing here?
dreachemAuthorUnsubmitted
Done
ReplyInline Actions

This is from the original table. Is this referring to begin/end declare variant feature, which I also added? If so, I should remove that one.

dreachem: This is from the original table. Is this referring to begin/end declare variant feature, which…
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

yes. remove this and mark begin/end declare variant as done.

jdoerfert: yes. remove this and mark `begin/end declare variant ` as done.
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| other | deprecating master construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| OMPT | new barrier types added to ompt_sync_region_t enum | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| OMPT | async data transfers added to ompt_target_data_op_t enum | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| OMPT | new barrier state values added to ompt_state_t enum | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| OMPT | new 'emi' callbacks for external monitoring interfaces | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| task extension | 'strict' modifier for taskloop construct | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| task extension | inoutset in depend clause | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+
| task extension | nowait clause on taskwait | :none:`unclaimed` | |
+------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+