Page MenuHomePhabricator

[Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree
AbandonedPublic

Authored by glaubitz on Nov 1 2020, 2:01 AM.

Details

Summary

Both sparc and sparc64 are using the MultiArch mechanism on modern Debian
systems the same way as x86_64, powerpc64el and others. Thus, switch the
CHECK-DEBIAN-SPARC32 and CHECK-DEBIAN-SPARC64 tests to use the files from
the debian_multiarch_tree directory for the header and linker path tests.

Also, rename CHECK-DEBIAN-SPARC32 to CHECK-DEBIAN-SPARC to match the naming
scheme of the Debian MultiArch checks for the other Debian architectures.

Diff Detail

Unit TestsFailed

TimeTest
390 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

glaubitz created this revision.Nov 1 2020, 2:01 AM
glaubitz requested review of this revision.Nov 1 2020, 2:01 AM
glaubitz updated this revision to Diff 302131.Nov 1 2020, 2:10 AM
glaubitz edited the summary of this revision. (Show Details)

Update commit comment to reflect the rename of CHECK-DEBIAN-SPARC32 to CHECK-DEBIAN-SPARC.

glaubitz updated this revision to Diff 302133.Nov 1 2020, 3:19 AM
glaubitz edited the summary of this revision. (Show Details)

Update the patch to include the linux-header-search.cpp tests as well.

glaubitz updated this revision to Diff 302139.Nov 1 2020, 4:29 AM

The previous patch accidentally missed the necessary files changes in Inputs/debian_multiarch_tree,
let's hope this one is correct now.

This change is required to fix testsuite failures as a result of this fix: https://reviews.llvm.org/D90524

ro added a comment.Nov 9 2020, 5:39 AM

As I'd mentioned in D90524, I believe both patches should be merged into one. Otherwise, no matter in which order you commit them, the buildbots might show failures otherwise.

Another point I'm not certain about is wether the checks for the old directory layout should be removed: shouldn't clang still work correctly on both? If so, both should still be tested. However, this is something I'm not familiar with, so I'll leave approval to someone who is.

glaubitz abandoned this revision.Nov 9 2020, 5:59 AM