This is an archive of the discontinued LLVM Phabricator instance.

Differential D90274

[mlir] Fix stack-use-after-scope in cuda/vulkan cpu runners
ClosedPublic

Authored by ezhulenev on Oct 27 2020, 4:04 PM.

Details

Reviewers
mehdi_amini
mravishankar
antiagainst
Commits
rGa297340d9ef8: [mlir] Fix stack-use-after-scope in cuda/vulkan cpu runners
Summary

+fix rocm runner

Diff Detail

Unit TestsFailed

TimeTest
330 mslinux > LLVM.DebugInfo/WebAssembly::dwarf-headers.ll
350 mswindows > LLVM.DebugInfo/WebAssembly::dwarf-headers.ll

Event Timeline

ezhulenev created this revision.Oct 27 2020, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 27 2020, 4:04 PM
Herald added subscribers: rdzhabarov, tatianashp, msifontes and 13 others. · View Herald Transcript
ezhulenev requested review of this revision.Oct 27 2020, 4:04 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 27 2020, 4:04 PM
ezhulenev added a reviewer: mehdi_amini.Oct 27 2020, 4:05 PM
Harbormaster completed remote builds in B76642: Diff 301116.Oct 27 2020, 4:39 PM
ezhulenev updated this revision to Diff 301131.Oct 27 2020, 5:02 PM

Fix cuda and vulkan runner

Herald added a reviewer: mravishankar. · View Herald TranscriptOct 27 2020, 5:02 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a subscriber: AlexeySotkin. · View Herald Transcript
ezhulenev retitled this revision from [mlir] Update mlir-rocm-runner JitRunnerMain call to [mlir] Fix stack-use-after-scope in cuda/vulkan cpu runners.Oct 27 2020, 5:03 PM
ezhulenev edited the summary of this revision. (Show Details)
Herald added a subscriber: yaxunl. · View Herald TranscriptOct 27 2020, 5:03 PM
Harbormaster completed remote builds in B76648: Diff 301131.Oct 27 2020, 5:03 PM
mehdi_amini accepted this revision.Oct 27 2020, 5:05 PM

LGTM.

Feel free to submit simple fixes without review.

This revision is now accepted and ready to land.Oct 27 2020, 5:05 PM
ezhulenev updated this revision to Diff 301141.Oct 27 2020, 5:22 PM

Rebase

ezhulenev updated this revision to Diff 301143.Oct 27 2020, 5:24 PM

Spirv runner

This revision was landed with ongoing or failed builds.Oct 27 2020, 5:26 PM
Closed by commit rGa297340d9ef8: [mlir] Fix stack-use-after-scope in cuda/vulkan cpu runners (authored by ezhulenev). · Explain Why
This revision was automatically updated to reflect the committed changes.
ezhulenev added a commit: rGa297340d9ef8: [mlir] Fix stack-use-after-scope in cuda/vulkan cpu runners.
Harbormaster completed remote builds in B76653: Diff 301141.Oct 27 2020, 5:43 PM
Harbormaster completed remote builds in B76654: Diff 301143.Oct 27 2020, 5:50 PM

Revision Contents

PathSize
mlir/
tools/
mlir-cuda-runner/
2 lines
mlir-rocm-runner/
6 lines
mlir-vulkan-runner/
2 lines

Diff 301143

mlir/tools/mlir-cuda-runner/mlir-cuda-runner.cpp

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Linesint main(int argc, char **argv) {
LLVMInitializeNVPTXTarget(); LLVMInitializeNVPTXTarget();
LLVMInitializeNVPTXTargetInfo(); LLVMInitializeNVPTXTargetInfo();
LLVMInitializeNVPTXTargetMC(); LLVMInitializeNVPTXTargetMC();
LLVMInitializeNVPTXAsmPrinter(); LLVMInitializeNVPTXAsmPrinter();
mlir::initializeLLVMPasses(); mlir::initializeLLVMPasses();
mlir::JitRunnerConfig jitRunnerConfig; mlir::JitRunnerConfig jitRunnerConfig;
jitRunnerConfig.mlirTransformer = &runMLIRPasses; jitRunnerConfig.mlirTransformer = runMLIRPasses;
return mlir::JitRunnerMain(argc, argv, jitRunnerConfig); return mlir::JitRunnerMain(argc, argv, jitRunnerConfig);
} }

mlir/tools/mlir-rocm-runner/mlir-rocm-runner.cpp

Show First 20 Lines • Show All 328 Lines • ▼ Show 20 Linesint main(int argc, char **argv) {
// Initialize LLVM AMDGPU backend. // Initialize LLVM AMDGPU backend.
LLVMInitializeAMDGPUTarget(); LLVMInitializeAMDGPUTarget();
LLVMInitializeAMDGPUTargetInfo(); LLVMInitializeAMDGPUTargetInfo();
LLVMInitializeAMDGPUTargetMC(); LLVMInitializeAMDGPUTargetMC();
LLVMInitializeAMDGPUAsmPrinter(); LLVMInitializeAMDGPUAsmPrinter();
mlir::initializeLLVMPasses(); mlir::initializeLLVMPasses();
return mlir::JitRunnerMain(argc, argv, &runMLIRPasses);
mlir::JitRunnerConfig jitRunnerConfig;
jitRunnerConfig.mlirTransformer = runMLIRPasses;
return mlir::JitRunnerMain(argc, argv, jitRunnerConfig);
} }

mlir/tools/mlir-vulkan-runner/mlir-vulkan-runner.cpp

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesint main(int argc, char **argv) {
registerPassManagerCLOptions(); registerPassManagerCLOptions();
llvm::InitLLVM y(argc, argv); llvm::InitLLVM y(argc, argv);
llvm::InitializeNativeTarget(); llvm::InitializeNativeTarget();
llvm::InitializeNativeTargetAsmPrinter(); llvm::InitializeNativeTargetAsmPrinter();
mlir::initializeLLVMPasses(); mlir::initializeLLVMPasses();
mlir::JitRunnerConfig jitRunnerConfig; mlir::JitRunnerConfig jitRunnerConfig;
jitRunnerConfig.mlirTransformer = &runMLIRPasses; jitRunnerConfig.mlirTransformer = runMLIRPasses;
return mlir::JitRunnerMain(argc, argv, jitRunnerConfig); return mlir::JitRunnerMain(argc, argv, jitRunnerConfig);
} }