Page MenuHomePhabricator

ezhulenev (Eugene Zhulenev)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 6 2020, 7:42 PM (66 w, 5 d)

Recent Activity

Tue, Jun 8

ezhulenev added a comment to D103686: [mlir] Fix body-less async.execute printing.

Execute without a body doesn't make much sense, maybe check it in verifier? Currently it will also fail because of op.body() access

Tue, Jun 8, 3:12 AM · Restricted Project
ezhulenev accepted D103686: [mlir] Fix body-less async.execute printing.
Tue, Jun 8, 3:11 AM · Restricted Project

Thu, Jun 3

ezhulenev accepted D103592: [mlir] Catch nonconvertible types in async conversion.
Thu, Jun 3, 12:29 AM · Restricted Project

Thu, May 27

ezhulenev committed rG8f23fac4da25: [mlir:Async] Convert assertions to async errors only inside async functions (authored by ezhulenev).
[mlir:Async] Convert assertions to async errors only inside async functions
Thu, May 27, 12:49 PM
ezhulenev closed D103278: [mlir:Async] Convert assertions to async errors only inside async functions.
Thu, May 27, 12:49 PM · Restricted Project
ezhulenev requested review of D103278: [mlir:Async] Convert assertions to async errors only inside async functions.
Thu, May 27, 12:43 PM · Restricted Project
ezhulenev committed rG9136b7d075d2: [mlir] AsyncRefCounting: check that LivenessBlockInfo is not nullptr (authored by ezhulenev).
[mlir] AsyncRefCounting: check that LivenessBlockInfo is not nullptr
Thu, May 27, 10:54 AM
ezhulenev closed D103270: [mlir] AsyncRefCounting: check that LivenessBlockInfo is not nullptr.
Thu, May 27, 10:54 AM · Restricted Project
ezhulenev added a reviewer for D103270: [mlir] AsyncRefCounting: check that LivenessBlockInfo is not nullptr: jpienaar.
Thu, May 27, 10:48 AM · Restricted Project
ezhulenev requested review of D103270: [mlir] AsyncRefCounting: check that LivenessBlockInfo is not nullptr.
Thu, May 27, 10:47 AM · Restricted Project
ezhulenev committed rGd8c84d2a4efc: [mlir] Async: Add error propagation support to async groups (authored by ezhulenev).
[mlir] Async: Add error propagation support to async groups
Thu, May 27, 9:35 AM
ezhulenev closed D103203: [mlir] Async: Add error propagation support to async groups.
Thu, May 27, 9:35 AM · Restricted Project
ezhulenev committed rG39957aa4243c: [mlir] Add error state and error propagation to async runtime values (authored by ezhulenev).
[mlir] Add error state and error propagation to async runtime values
Thu, May 27, 9:29 AM
ezhulenev closed D103109: [mlir] Add error state and error propagation to async runtime values.
Thu, May 27, 9:28 AM · Restricted Project
ezhulenev committed rGc412979cde54: [mlir] Async reference counting for block successors with divergent reference… (authored by ezhulenev).
[mlir] Async reference counting for block successors with divergent reference…
Thu, May 27, 9:22 AM
ezhulenev closed D103102: [mlir] Async reference counting for block successors with divergent reference counted liveness.
Thu, May 27, 9:22 AM · Restricted Project

Wed, May 26

ezhulenev updated the summary of D103203: [mlir] Async: Add error propagation support to async groups.
Wed, May 26, 1:35 PM · Restricted Project
ezhulenev requested review of D103203: [mlir] Async: Add error propagation support to async groups.
Wed, May 26, 1:33 PM · Restricted Project

Tue, May 25

ezhulenev updated the diff for D103109: [mlir] Add error state and error propagation to async runtime values.

Fix verifier error

Tue, May 25, 3:06 PM · Restricted Project
ezhulenev added inline comments to D103109: [mlir] Add error state and error propagation to async runtime values.
Tue, May 25, 3:04 PM · Restricted Project
ezhulenev updated the diff for D103109: [mlir] Add error state and error propagation to async runtime values.

Update is_error op definition to reject async.group operands

Tue, May 25, 3:03 PM · Restricted Project
ezhulenev updated the summary of D103109: [mlir] Add error state and error propagation to async runtime values.
Tue, May 25, 12:10 PM · Restricted Project
ezhulenev requested review of D103109: [mlir] Add error state and error propagation to async runtime values.
Tue, May 25, 12:08 PM · Restricted Project
ezhulenev added inline comments to D103102: [mlir] Async reference counting for block successors with divergent reference counted liveness.
Tue, May 25, 11:02 AM · Restricted Project
ezhulenev updated the diff for D103102: [mlir] Async reference counting for block successors with divergent reference counted liveness.

Address comments

Tue, May 25, 11:02 AM · Restricted Project
ezhulenev updated the summary of D103102: [mlir] Async reference counting for block successors with divergent reference counted liveness.
Tue, May 25, 10:50 AM · Restricted Project
ezhulenev requested review of D103102: [mlir] Async reference counting for block successors with divergent reference counted liveness.
Tue, May 25, 10:45 AM · Restricted Project

May 12 2021

ezhulenev updated the diff for D102368: [mlir] Fix ssa values naming bug.

Add top level names scope to named context

May 12 2021, 2:17 PM · Restricted Project
ezhulenev updated the summary of D102368: [mlir] Fix ssa values naming bug.
May 12 2021, 2:08 PM · Restricted Project
ezhulenev requested review of D102368: [mlir] Fix ssa values naming bug.
May 12 2021, 2:07 PM · Restricted Project
ezhulenev added inline comments to D101693: [mlir] Add ComprehensiveBufferize pass for function and modules (step 1/n).
May 12 2021, 10:41 AM · Restricted Project

May 5 2021

ezhulenev committed rG3c952ab25fb8: [mlir] Check generated IR of math_polynomial_approx.mlir (authored by cota).
[mlir] Check generated IR of math_polynomial_approx.mlir
May 5 2021, 4:43 PM
ezhulenev closed D101940: [mlir] Check generated IR of math_polynomial_approx.mlir.
May 5 2021, 4:43 PM · Restricted Project
ezhulenev committed rG0edc4bc84aa2: [mlir] Add polynomial approximation for math::ExpM1 (authored by cota).
[mlir] Add polynomial approximation for math::ExpM1
May 5 2021, 2:31 PM
ezhulenev closed D101852: [mlir] Add polynomial approximation for math::ExpM1.
May 5 2021, 2:31 PM · Restricted Project
ezhulenev accepted D101852: [mlir] Add polynomial approximation for math::ExpM1.
May 5 2021, 2:27 PM · Restricted Project
ezhulenev added inline comments to D101852: [mlir] Add polynomial approximation for math::ExpM1.
May 5 2021, 5:35 AM · Restricted Project

May 3 2021

ezhulenev committed rG9b67096fe952: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering (authored by ezhulenev).
[mlir] Linalg: add vector transfer lowering patterns to the contraction lowering
May 3 2021, 4:22 PM
ezhulenev closed D101795: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering.
May 3 2021, 4:22 PM · Restricted Project
ezhulenev updated the summary of D101795: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering.
May 3 2021, 4:07 PM · Restricted Project
ezhulenev requested review of D101795: [mlir] Linalg: add vector transfer lowering patterns to the contraction lowering.
May 3 2021, 4:06 PM · Restricted Project
ezhulenev committed rG1c0374e77095: [mlir] Add polynomial approximation for math::Log1p (authored by cota).
[mlir] Add polynomial approximation for math::Log1p
May 3 2021, 3:11 PM
ezhulenev closed D101765: [mlir] Add polynomial approximation for math::Log1p.
May 3 2021, 3:11 PM · Restricted Project
ezhulenev accepted D101765: [mlir] Add polynomial approximation for math::Log1p.
May 3 2021, 12:17 PM · Restricted Project

Apr 29 2021

ezhulenev accepted D101531: [mlir] Fix lowering of multi-dimensional vector log1p to LLVM.
Apr 29 2021, 12:46 PM · Restricted Project

Apr 26 2021

ezhulenev added a comment to D93592: [mlir] Async: lowering async.value to LLVM.

Can the problem be in calculation of the value storage size? (https://github.com/llvm/llvm-project/blob/d480f968ad8b56d3ee4a6b6df5532d485b0ad01e/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp#L518-L542) I'd check what the value of size passed in here: https://github.com/llvm/llvm-project/blob/main/mlir/lib/ExecutionEngine/AsyncRuntime.cpp#L205-L208

Apr 26 2021, 10:42 AM · Restricted Project

Apr 21 2021

ezhulenev committed rG3f1e827abd7f: [mlir] Linalg : do not forward memrefs to outputs when do bufferization (authored by ezhulenev).
[mlir] Linalg : do not forward memrefs to outputs when do bufferization
Apr 21 2021, 4:39 PM
ezhulenev closed D100921: [mlir] Linalg : do not forward memrefs to outputs when do bufferization.
Apr 21 2021, 4:39 PM · Restricted Project
ezhulenev retitled D100921: [mlir] Linalg : do not forward memrefs to outputs when do bufferization from [mlir] Linalg : clone output buffers allocated by AllocOp to [mlir] Linalg : do not forward memrefs to outputs when do bufferization.
Apr 21 2021, 3:54 PM · Restricted Project
ezhulenev updated the diff for D100921: [mlir] Linalg : do not forward memrefs to outputs when do bufferization.

Do not forward memrefs to outputs when do bufferization

Apr 21 2021, 3:53 PM · Restricted Project

Apr 20 2021

ezhulenev updated the summary of D100921: [mlir] Linalg : do not forward memrefs to outputs when do bufferization.
Apr 20 2021, 7:52 PM · Restricted Project
ezhulenev requested review of D100921: [mlir] Linalg : do not forward memrefs to outputs when do bufferization.
Apr 20 2021, 7:50 PM · Restricted Project

Apr 13 2021

ezhulenev committed rG8a316b00d63d: [mlir] Convert async dialect passes from function passes to op agnostic passes (authored by ezhulenev).
[mlir] Convert async dialect passes from function passes to op agnostic passes
Apr 13 2021, 11:46 AM
ezhulenev closed D100401: [mlir] Convert async dialect passes from function passes to op agnostic passes.
Apr 13 2021, 11:46 AM · Restricted Project
ezhulenev updated the diff for D100401: [mlir] Convert async dialect passes from function passes to op agnostic passes.

Rebased

Apr 13 2021, 11:40 AM · Restricted Project
ezhulenev requested review of D100401: [mlir] Convert async dialect passes from function passes to op agnostic passes.
Apr 13 2021, 11:16 AM · Restricted Project

Apr 12 2021

ezhulenev committed rGa6628e596e70: [mlir] Async: add automatic reference counting at async.runtime operations level (authored by ezhulenev).
[mlir] Async: add automatic reference counting at async.runtime operations level
Apr 12 2021, 6:55 PM
ezhulenev closed D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Apr 12 2021, 6:55 PM · Restricted Project
ezhulenev added inline comments to D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Apr 12 2021, 10:50 AM · Restricted Project
ezhulenev updated the diff for D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

Return after signaling pass failure

Apr 12 2021, 10:48 AM · Restricted Project

Apr 11 2021

ezhulenev updated the diff for D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

Fix typo

Apr 11 2021, 12:44 PM · Restricted Project
ezhulenev added inline comments to D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Apr 11 2021, 12:40 PM · Restricted Project
ezhulenev updated the diff for D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

Traverse only blocks where the ref counted value has users

Apr 11 2021, 12:40 PM · Restricted Project

Apr 10 2021

ezhulenev added inline comments to D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Apr 10 2021, 2:44 PM · Restricted Project
ezhulenev updated the diff for D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

Do not lookup in the hash map twice.

Apr 10 2021, 2:44 PM · Restricted Project
ezhulenev added inline comments to D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.
Apr 10 2021, 2:19 PM · Restricted Project
ezhulenev updated the diff for D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

Update reference counting pass documentation

Apr 10 2021, 2:18 PM · Restricted Project

Apr 7 2021

ezhulenev added a comment to D95390: [mlir] Async: add automatic reference counting at async.runtime operations level.

@mehdi_amini will you have time to take a look at this change? Diffs looks large, but really no new ideas here. I plan to get back to working on async stuff next week, and need this to land first.

Apr 7 2021, 2:44 PM · Restricted Project

Apr 5 2021

ezhulenev added inline comments to D99818: [mlir] X86Vector: Add AVX Rsqrt.
Apr 5 2021, 11:08 AM · Restricted Project

Apr 3 2021

ezhulenev updated subscribers of D99560: Utility to construct visitors from lambdas..

It’s impossible to statically dispatch to the correct lambda with such API
(or at least a very difficult exercise). std::visit takes a single visitor
and multiple variants, not the other way around. Stitching lambdas together
is just one way of constructing a visitor type, it can be a plain old class
with overloaded operator() set.

Apr 3 2021, 12:53 AM · Restricted Project

Apr 2 2021

ezhulenev added a comment to D99560: Utility to construct visitors from lambdas..

std::forward with inheritance does not remove a need to invoke a copy constructors, I managed to implement overloaded using a struct member and super ugly SFINAE that does properly captures lambdas by reference when lambda is a lvalue, however it still does need to copy when lambda is rvalue: https://godbolt.org/z/dqshPW6h1 (top most example, I just count the number of HeavyStuff::HeavyStuff(HeavyStuff const&) copy constructor calls in the generated code). But it does look much worse than inheritance.

Apr 2 2021, 9:39 PM · Restricted Project

Mar 30 2021

ezhulenev added a comment to D99561: Support visitor pattern by PointerUnion..

True llvm::visit API similar to std::visit requires visited type to be a std::variant (llvm::variant?) and implementng it is a lot of code (e.g. implementation in absl). Given that it's unlikely that PointerUnion at any point will become std::variant, I'd say that it will always be a separate API. And for this usability improvement the change is not that large.

Mar 30 2021, 9:35 PM · Restricted Project
ezhulenev added inline comments to D99561: Support visitor pattern by PointerUnion..
Mar 30 2021, 3:44 PM · Restricted Project
ezhulenev committed rG6c9fbcf5b1cb: [mlir] Linalg: add tile interchange flag to test-linalg-codegen-strategy pass (authored by ezhulenev).
[mlir] Linalg: add tile interchange flag to test-linalg-codegen-strategy pass
Mar 30 2021, 10:49 AM
ezhulenev closed D99397: [mlir] Linalg: add tile interchange flag to test-linalg-codegen-strategy pass.
Mar 30 2021, 10:48 AM · Restricted Project

Mar 25 2021

ezhulenev updated the summary of D99397: [mlir] Linalg: add tile interchange flag to test-linalg-codegen-strategy pass.
Mar 25 2021, 7:50 PM · Restricted Project
ezhulenev requested review of D99397: [mlir] Linalg: add tile interchange flag to test-linalg-codegen-strategy pass.
Mar 25 2021, 7:49 PM · Restricted Project

Mar 18 2021

ezhulenev committed rG32a744ab20f3: [mlir] Add linalg.fill bufferization conversion (authored by ezhulenev).
[mlir] Add linalg.fill bufferization conversion
Mar 18 2021, 1:41 PM
ezhulenev closed D98671: [mlir] Add linalg.fill bufferization conversion.
Mar 18 2021, 1:41 PM · Restricted Project

Mar 16 2021

ezhulenev committed rG74f6138bd98f: [mlir] Add lowering from math::Log1p to LLVM (authored by ezhulenev).
[mlir] Add lowering from math::Log1p to LLVM
Mar 16 2021, 3:59 PM
ezhulenev closed D98662: [mlir] Add lowering from math::Log1p to LLVM.
Mar 16 2021, 3:59 PM · Restricted Project

Mar 15 2021

ezhulenev updated the summary of D98671: [mlir] Add linalg.fill bufferization conversion.
Mar 15 2021, 4:55 PM · Restricted Project
ezhulenev updated the summary of D98671: [mlir] Add linalg.fill bufferization conversion.
Mar 15 2021, 4:54 PM · Restricted Project
ezhulenev requested review of D98671: [mlir] Add linalg.fill bufferization conversion.
Mar 15 2021, 4:52 PM · Restricted Project
ezhulenev updated the summary of D98662: [mlir] Add lowering from math::Log1p to LLVM.
Mar 15 2021, 2:40 PM · Restricted Project
ezhulenev requested review of D98662: [mlir] Add lowering from math::Log1p to LLVM.
Mar 15 2021, 2:39 PM · Restricted Project

Mar 12 2021

ezhulenev committed rG39b2cd400996: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED (authored by ezhulenev).
[mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED
Mar 12 2021, 11:26 AM
ezhulenev closed D98476: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED.
Mar 12 2021, 11:26 AM · Restricted Project
ezhulenev retitled D98476: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED from [mlir] Put functions used only in debug mode under NDEBUG to [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED.
Mar 12 2021, 10:40 AM · Restricted Project
ezhulenev updated the diff for D98476: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED.

Use LLVM_ATTRIBUTE_UNUSED

Mar 12 2021, 10:39 AM · Restricted Project

Mar 11 2021

ezhulenev added a reviewer for D98476: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED: dcaballe.
Mar 11 2021, 8:38 PM · Restricted Project
ezhulenev updated the summary of D98476: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED.
Mar 11 2021, 8:37 PM · Restricted Project
ezhulenev requested review of D98476: [mlir] Annotate functions used only in debug mode with LLVM_ATTRIBUTE_UNUSED.
Mar 11 2021, 8:35 PM · Restricted Project
ezhulenev added a comment to D97304: [mlir] Add polynomial approximation for math::LogOp (using builders API).

They are actually used but only inside assert, is it a release build when it is a warning?

Mar 11 2021, 10:28 AM · Restricted Project

Mar 10 2021

ezhulenev committed rGc0891706bc9f: [mlir] Add polynomial approximation for math::Log2 (authored by cota).
[mlir] Add polynomial approximation for math::Log2
Mar 10 2021, 2:49 PM
ezhulenev closed D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 10 2021, 2:49 PM · Restricted Project
ezhulenev accepted D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 10 2021, 11:15 AM · Restricted Project

Mar 9 2021

ezhulenev added inline comments to D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 9 2021, 4:26 PM · Restricted Project
ezhulenev added inline comments to D98282: [mlir] Add polynomial approximation for math::Log2.
Mar 9 2021, 12:35 PM · Restricted Project

Feb 27 2021

ezhulenev accepted D97599: [mlir] Add polynomial approximation for math::ExpOp.
Feb 27 2021, 5:49 AM · Restricted Project