I had to remove some checks in MemRefReinterpretCastOp::verify. It might make
sense to convert to LLVM directly to avoid that.
https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15
Paths
| Differential D90235
[mlir] Convert memref_reshape to memref_reinterpret_cast. ClosedPublic Authored by pifon2a on Oct 27 2020, 8:09 AM.
Details Summary I had to remove some checks in MemRefReinterpretCastOp::verify. It might make https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15
Diff Detail
Event TimelineHerald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 27 2020, 8:09 AM
Comment Actions Please address comments, otherwise lgtm.
This revision is now accepted and ready to land.Oct 28 2020, 8:33 AM Comment Actions Remove tabs
This revision was landed with ongoing or failed builds.Oct 28 2020, 1:15 PM Closed by commit rG7a996027b984: [mlir] Convert memref_reshape to memref_reinterpret_cast. (authored by pifon2a). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 301287 mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
mlir/include/mlir/Dialect/StandardOps/Transforms/Passes.h
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
mlir/lib/Dialect/StandardOps/Transforms/ExpandMemRefReshape.cpp
mlir/test/Dialect/Standard/expand-memref-reshape.mlir
mlir/test/Dialect/Standard/invalid.mlir
mlir/test/lib/Transforms/TestExpandMemRefReshape.cpp
mlir/test/mlir-cpu-runner/memref_reshape.mlir
mlir/tools/mlir-opt/mlir-opt.cpp
|
Missing space after comma.