Page MenuHomePhabricator

ekatz (Ehud Katz)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2019, 1:22 AM (18 w, 6 d)

Recent Activity

Today

ekatz added a comment to D74415: [ADT] Implement the Waymarking as an independent utility.

Ping

Tue, Feb 25, 12:42 PM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Ping

Tue, Feb 25, 12:42 PM · Restricted Project

Thu, Feb 20

ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Ping

Thu, Feb 20, 7:26 AM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Thu, Feb 20, 7:26 AM · Restricted Project
ekatz added a comment to D74415: [ADT] Implement the Waymarking as an independent utility.

Ping

Thu, Feb 20, 7:17 AM · Restricted Project

Wed, Feb 12

ekatz added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Should be fixed in rGd8a2ea9fd5c7

Wed, Feb 12, 12:52 PM · Restricted Project
ekatz committed rGd8a2ea9fd5c7: [LoopExtractor] Fix legacy pass dependencies (authored by ekatz).
[LoopExtractor] Fix legacy pass dependencies
Wed, Feb 12, 12:43 PM
ekatz added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Wed, Feb 12, 11:38 AM · Restricted Project
ekatz committed rG167c42849099: [unittests] Fix TargetLibraryInfoTest.ValidProto (authored by ekatz).
[unittests] Fix TargetLibraryInfoTest.ValidProto
Wed, Feb 12, 4:14 AM
ekatz committed rG2470d2988a05: [ConstantFolding] Fold calls to FP remainder function (authored by ekatz).
[ConstantFolding] Fold calls to FP remainder function
Wed, Feb 12, 3:28 AM
ekatz closed D69777: [ConstantFolding] Fold calls to FP remainder function.
Wed, Feb 12, 3:28 AM · Restricted Project
ekatz added inline comments to D69777: [ConstantFolding] Fold calls to FP remainder function.
Wed, Feb 12, 3:19 AM · Restricted Project
ekatz committed rG9d0956ebd471: [APFloat] Fix FP remainder operation (authored by ekatz).
[APFloat] Fix FP remainder operation
Wed, Feb 12, 12:53 AM
ekatz closed D69776: [APFloat] Fix FP remainder operation.
Wed, Feb 12, 12:52 AM · Restricted Project

Tue, Feb 11

ekatz abandoned D69332: Implement the Waymarking as an independent utility.

Separate into 2 different patches.

Tue, Feb 11, 7:59 AM · Restricted Project
ekatz created D74415: [ADT] Implement the Waymarking as an independent utility.
Tue, Feb 11, 7:59 AM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Tue, Feb 11, 6:37 AM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Ping

Tue, Feb 11, 5:07 AM · Restricted Project
ekatz updated the diff for D69776: [APFloat] Fix FP remainder operation.

Added asserts for the opStatus returned by the operations.

Tue, Feb 11, 5:07 AM · Restricted Project

Mon, Feb 10

ekatz added inline comments to D69776: [APFloat] Fix FP remainder operation.
Mon, Feb 10, 9:13 PM · Restricted Project
ekatz updated the diff for D69776: [APFloat] Fix FP remainder operation.

Simplified logics according to the notes.
Also added more extensive tests.

Mon, Feb 10, 12:45 PM · Restricted Project
ekatz added a comment to D69776: [APFloat] Fix FP remainder operation.

@efriedma , I updated the files according to your requests.

Mon, Feb 10, 12:45 PM · Restricted Project

Sun, Feb 9

ekatz committed rG3b70ee27a503: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass (authored by ekatz).
[LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass
Sun, Feb 9, 2:35 AM
ekatz closed D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Sun, Feb 9, 2:35 AM · Restricted Project

Fri, Feb 7

ekatz added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

@fhahn does it look right?

Fri, Feb 7, 12:44 PM · Restricted Project

Thu, Feb 6

ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Thu, Feb 6, 12:06 PM · Restricted Project
ekatz updated the diff for D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Added IR checks of all the tests.

Thu, Feb 6, 12:05 PM · Restricted Project
ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Thu, Feb 6, 11:07 AM · Restricted Project
ekatz updated the diff for D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Thu, Feb 6, 10:58 AM · Restricted Project
ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Thu, Feb 6, 9:44 AM · Restricted Project
ekatz updated the diff for D70097: [SCEV] Add missing cache queries.

Fixed noted issues.

Thu, Feb 6, 4:12 AM · Restricted Project
ekatz added inline comments to D70097: [SCEV] Add missing cache queries.
Thu, Feb 6, 4:12 AM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Do you have a simple test demonstrating a claimed speedup?

Thu, Feb 6, 3:19 AM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Thu, Feb 6, 3:01 AM · Restricted Project
ekatz added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

@fhahn , do I have a green light?

Thu, Feb 6, 3:01 AM · Restricted Project

Wed, Jan 29

ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Wed, Jan 29, 1:40 PM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Wed, Jan 29, 1:40 PM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Ping

Wed, Jan 29, 1:40 PM · Restricted Project

Jan 22 2020

ekatz updated the diff for D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Added test cases for the bugs, as well as for testing a simple extraction and a no extraction in the edge case where the function is just a minimal wrapper around a loop.

Jan 22 2020, 11:46 AM · Restricted Project

Jan 21 2020

ekatz committed rG2d77e0b9f22a: Fix tests of constant folding of fp operations on NaN values (authored by ekatz).
Fix tests of constant folding of fp operations on NaN values
Jan 21 2020, 11:55 AM
ekatz committed rG0b336b6048ae: [APFloat] Add support for operations on Signaling NaN (authored by ekatz).
[APFloat] Add support for operations on Signaling NaN
Jan 21 2020, 11:07 AM
ekatz closed D69774: [APFloat] Add support for operations on Signaling NaN.
Jan 21 2020, 11:07 AM · Restricted Project
ekatz committed rG68122b5826b5: [APFloat] Extend conversion from special strings (authored by ekatz).
[APFloat] Extend conversion from special strings
Jan 21 2020, 10:30 AM
ekatz closed D69773: [APFloat] Extend converting from special strings.
Jan 21 2020, 10:30 AM · Restricted Project
ekatz updated the diff for D69773: [APFloat] Extend converting from special strings.

Done requested nit changes.

Jan 21 2020, 9:00 AM · Restricted Project

Jan 20 2020

ekatz added a comment to D70097: [SCEV] Add missing cache queries.

@reames any comment on the change?

Jan 20 2020, 5:03 AM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Jan 20 2020, 5:03 AM · Restricted Project
ekatz added a comment to D69773: [APFloat] Extend converting from special strings.

Ping

Jan 20 2020, 5:03 AM · Restricted Project

Jan 15 2020

ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Jan 15 2020, 8:34 PM · Restricted Project
ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Jan 15 2020, 8:34 PM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.
In D72068#1822503, @rnk wrote:

I feel like this is creating too much unnecessary abstraction. I think we can use simple techniques, like unions, as I did here in this uncommitted patch:
https://reviews.llvm.org/D51664#C1373737NL442
Even better, we can do that incrementally, without many changes to the get/set value subclass data APIs.

Jan 15 2020, 1:29 PM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Jan 15 2020, 10:12 AM · Restricted Project
ekatz added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

@fhahn, what do you say?

Jan 15 2020, 10:12 AM · Restricted Project

Jan 14 2020

ekatz abandoned D69334: [MathExtras] Add intrinsic for the PopulationCounter in Visual Studio.

I agree. This seems like too much of a hassle. I'll abandon this patch.

Jan 14 2020, 9:55 AM · Restricted Project

Jan 13 2020

ekatz added a comment to D69773: [APFloat] Extend converting from special strings.

Ping

Jan 13 2020, 1:24 PM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Ping

Jan 13 2020, 11:31 AM · Restricted Project

Jan 10 2020

ekatz added a comment to D72214: [GlobalOpt] Get DT only if it is available..

I could not get getAnalysisIfAvailable to get a function level analysis from a module pass. IIUC it only works for function passes.

Jan 10 2020, 10:22 AM · Restricted Project
ekatz added a comment to D72214: [GlobalOpt] Get DT only if it is available..

The old PassManager has the function getAnalysisIfAvailable that should be used in case you only need to update an analysis (equivalent to getCachedResult of the new PassManager). You should probably switch to use this function, instead of the SmallPtrSet<> DTRequested.

Jan 10 2020, 9:18 AM · Restricted Project

Jan 9 2020

ekatz added a comment to D72214: [GlobalOpt] Get DT only if it is available..

This is a welcoming improvement!
Is it sufficient that I'll approve it for you? Or are you waiting for the code-owner?

Jan 9 2020, 1:32 PM · Restricted Project
ekatz added a comment to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Would it be possible to also add some of the test cases for the linked bugs?

Jan 9 2020, 1:14 PM · Restricted Project
ekatz added a comment to D72068: [IR] Refactor SubclassData.

Ping

Jan 9 2020, 6:46 AM · Restricted Project
ekatz updated the diff for D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Jan 9 2020, 6:46 AM · Restricted Project
ekatz added inline comments to D69770: [APFloat] Add recoverable string parsing errors to APFloat.
Jan 9 2020, 12:34 AM · Restricted Project, Restricted Project

Jan 8 2020

ekatz committed rG24b326cc610d: [APFloat] Fix checked error assert failures (authored by ekatz).
[APFloat] Fix checked error assert failures
Jan 8 2020, 11:57 PM

Jan 7 2020

ekatz added a comment to D70097: [SCEV] Add missing cache queries.

Ping

Jan 7 2020, 12:11 PM · Restricted Project
ekatz updated the diff for D69773: [APFloat] Extend converting from special strings.

Reduced the patch to only the extensions of:

  • Signaling NaN
  • NaN Pyaload
Jan 7 2020, 12:10 PM · Restricted Project
ekatz added inline comments to D69773: [APFloat] Extend converting from special strings.
Jan 7 2020, 11:21 AM · Restricted Project
ekatz committed rG63a222e504c2: [APFloat] Fix out of scope usage of a pointer to local variable (authored by ekatz).
[APFloat] Fix out of scope usage of a pointer to local variable
Jan 7 2020, 1:32 AM

Jan 6 2020

ekatz committed rG08de551f4f10: [APFloat] Fix fusedMultiplyAdd when `this` equals to `Addend` (authored by ekatz).
[APFloat] Fix fusedMultiplyAdd when `this` equals to `Addend`
Jan 6 2020, 11:12 PM
ekatz closed D70422: [APFloat] Fix fusedMultiplyAdd when `this` equals to `Addend`.
Jan 6 2020, 11:12 PM · Restricted Project
ekatz added inline comments to D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Jan 6 2020, 12:14 PM · Restricted Project
ekatz committed rGf3f7dc3d2990: [APFloat] Fix compilation warnings (authored by ekatz).
[APFloat] Fix compilation warnings
Jan 6 2020, 1:31 AM
ekatz committed rGc5fb73c5d1b3: [APFloat] Add recoverable string parsing errors to APFloat (authored by ekatz).
[APFloat] Add recoverable string parsing errors to APFloat
Jan 6 2020, 12:17 AM
ekatz closed D69770: [APFloat] Add recoverable string parsing errors to APFloat.
Jan 6 2020, 12:16 AM · Restricted Project, Restricted Project

Jan 2 2020

ekatz added a comment to D70097: [SCEV] Add missing cache queries.
Jan 2 2020, 6:48 AM · Restricted Project

Jan 1 2020

ekatz created D72068: [IR] Refactor SubclassData.
Jan 1 2020, 11:57 PM · Restricted Project

Dec 23 2019

ekatz added a comment to D69334: [MathExtras] Add intrinsic for the PopulationCounter in Visual Studio.

I thought I might add a dynamic detection to the CMake files, as it already does that for headers and other supported functionalities. Didn't find the time for it, as it is a pretty low priority. But, what do you think?

Dec 23 2019, 10:43 PM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.
Dec 23 2019, 7:21 PM · Restricted Project

Dec 11 2019

ekatz added a comment to D69773: [APFloat] Extend converting from special strings.

Ping

Dec 11 2019, 1:42 PM · Restricted Project
ekatz added a comment to D69776: [APFloat] Fix FP remainder operation.

Ping

Dec 11 2019, 1:42 PM · Restricted Project
ekatz added a comment to D69770: [APFloat] Add recoverable string parsing errors to APFloat.

Ping

Dec 11 2019, 1:42 PM · Restricted Project, Restricted Project
ekatz added a comment to D69777: [ConstantFolding] Fold calls to FP remainder function.

Ping

Dec 11 2019, 1:42 PM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.
Dec 11 2019, 1:42 PM · Restricted Project

Dec 4 2019

ekatz committed rG2b6b8cb10c87: [APFloat] Prevent construction of APFloat with Semantics and FP value (authored by ekatz).
[APFloat] Prevent construction of APFloat with Semantics and FP value
Dec 4 2019, 2:08 AM
ekatz closed D70425: [APFloat] Prevent construction of APFloat with Semantics and FP value.
Dec 4 2019, 2:08 AM · Restricted Project

Dec 2 2019

ekatz added a comment to D70422: [APFloat] Fix fusedMultiplyAdd when `this` equals to `Addend`.

Note that this is a safe overload, as multiplySignificand is private.

Dec 2 2019, 9:48 AM · Restricted Project
ekatz updated the diff for D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.

Fix test.

Dec 2 2019, 9:39 AM · Restricted Project
ekatz added a comment to D70425: [APFloat] Prevent construction of APFloat with Semantics and FP value.

Ping

Dec 2 2019, 9:39 AM · Restricted Project
ekatz added a comment to D69777: [ConstantFolding] Fold calls to FP remainder function.

Ping

Dec 2 2019, 9:39 AM · Restricted Project
ekatz added a comment to D69770: [APFloat] Add recoverable string parsing errors to APFloat.

Ping

Dec 2 2019, 9:31 AM · Restricted Project, Restricted Project
ekatz added a comment to D69773: [APFloat] Extend converting from special strings.

Ping

Dec 2 2019, 9:31 AM · Restricted Project
ekatz added a comment to D69776: [APFloat] Fix FP remainder operation.

Ping

Dec 2 2019, 9:31 AM · Restricted Project
ekatz added a comment to D70097: [SCEV] Add missing cache queries.
Dec 2 2019, 9:31 AM · Restricted Project

Nov 27 2019

ekatz committed rG825debe847d1: [InlineCost] Fix infinite loop in indirect call evaluation (authored by ekatz).
[InlineCost] Fix infinite loop in indirect call evaluation
Nov 27 2019, 10:48 PM
ekatz closed D69349: [InlineCost] Fix infinite loop in indirect call evaluation.
Nov 27 2019, 10:48 PM · Restricted Project

Nov 24 2019

ekatz retitled D69069: [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass from [IPO] Convert LoopExtractor pass from LoopPass to ModulePass to [LoopExtractor] Convert LoopExtractor from LoopPass to ModulePass.
Nov 24 2019, 11:41 AM · Restricted Project
ekatz retitled D69770: [APFloat] Add recoverable string parsing errors to APFloat from Add recoverable string parsing errors to APFloat to [APFloat] Add recoverable string parsing errors to APFloat.
Nov 24 2019, 11:14 AM · Restricted Project, Restricted Project
ekatz updated the diff for D70097: [SCEV] Add missing cache queries.

Remove unrelated changes. Now only the missing cache queries are present in the patch.

Nov 24 2019, 11:14 AM · Restricted Project
ekatz updated the diff for D69776: [APFloat] Fix FP remainder operation.

Added comments and fix tests to meet gtestism.

Nov 24 2019, 10:10 AM · Restricted Project
ekatz reopened D69349: [InlineCost] Fix infinite loop in indirect call evaluation.
Nov 24 2019, 2:40 AM · Restricted Project