Page MenuHomePhabricator

[MLIR] Extract buffer alias analysis for reuse
ClosedPublic

Authored by frgossen on Oct 21 2020, 11:19 AM.

Details

Summary

Extract buffer alias analysis from buffer placement.

Diff Detail

Event Timeline

frgossen created this revision.Oct 21 2020, 11:19 AM
frgossen requested review of this revision.Oct 21 2020, 11:19 AM
pifon2a accepted this revision.Oct 21 2020, 11:27 AM
pifon2a added inline comments.
mlir/include/mlir/Interfaces/ControlFlowInterfaces.td
143

nit: tyop!

This revision is now accepted and ready to land.Oct 21 2020, 11:27 AM
rriddle added inline comments.Oct 21 2020, 11:29 AM
mlir/lib/Analysis/BufferAliasAnalysis.cpp
37

Can you please write this as a non-recursive algorithm instead? With unknown bounds, recursive algorithms quickly become unwieldy.

frgossen updated this revision to Diff 299772.Oct 21 2020, 11:59 AM
frgossen marked 2 inline comments as done.

Address comments

rriddle added inline comments.Oct 21 2020, 12:19 PM
mlir/lib/Analysis/BufferAliasAnalysis.cpp
24

nit: Use pop_back_val

frgossen updated this revision to Diff 299781.Oct 21 2020, 12:33 PM
frgossen marked an inline comment as done.

Address comment

This revision was landed with ongoing or failed builds.Oct 23 2020, 6:24 AM
This revision was automatically updated to reflect the committed changes.

Is this change related to build breakage? (https://buildkite.com/mlir/mlir-core/builds/8813)