This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans
ClosedPublic

Authored by Paul-C-Anagnostopoulos on Oct 20 2020, 7:55 AM.

Details

Summary

After adding the !not operator, I'm making a pass over the various targets to clean up things like !if(!eq(boolean, 1) and !eq(boolean 0). I'm pushing patches one target at a time.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2020, 7:55 AM
Paul-C-Anagnostopoulos requested review of this revision.Oct 20 2020, 7:55 AM
rampitec accepted this revision.Oct 20 2020, 10:44 AM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 20 2020, 10:44 AM
This revision was landed with ongoing or failed builds.Oct 20 2020, 1:24 PM
This revision was automatically updated to reflect the committed changes.
foad added a subscriber: foad.Oct 21 2020, 7:15 AM

This inspired me to do some further cleanups in rGf6a5699c6cb5.