Reuse most code for printing/parsing/verification from SubViewOp.
https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15
Paths
| Differential D89720
[mlir] Add MemRefReinterpretCastOp definition to Standard. ClosedPublic Authored by pifon2a on Oct 19 2020, 11:39 AM.
Details Summary Reuse most code for printing/parsing/verification from SubViewOp. https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15
Diff Detail
Event TimelineComment Actions Can you link the discourse discussion on this? Seems really weird that we have many seemingly overlapping cast ops. Comment Actions @rriddle Right, I forgot. This is the first PR to implement https://llvm.discourse.group/t/rfc-standard-memref-cast-ops/1454/15 This revision now requires changes to proceed.Oct 19 2020, 11:48 AM Comment Actions
Thanks! Appreciate it.
Comment Actions Do you want to add a to in the syntax? memref_reinterpret_cast %in to offset: ..., sizes: ... Otherwise, the proposed syntax is far more readable than subview which is missing offset, sizes, and strides markers and prints three integer arrays straight even in its custom form - in fact, its long form is more readable than its custom form! bondhugula added inline comments.
This revision now requires changes to proceed.Oct 19 2020, 8:13 PM Comment Actions Nice, thanks!
This revision now requires changes to proceed.Oct 21 2020, 6:28 AM
Comment Actions
Closed by commit rG461605c418e9: [mlir] Add MemRefReinterpretCastOp definition to Standard. (authored by pifon2a). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 299940 mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
mlir/lib/Dialect/StandardOps/IR/Ops.cpp
mlir/test/Dialect/Standard/invalid.mlir
mlir/test/Dialect/Standard/ops.mlir
|
Do you have a stray ] here or are you missing the opening one? You have more closing brackets than opening ones in the syntax.