Removing unused and unusable code.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
compiler-rt/cmake/base-config-ix.cmake | ||
---|---|---|
178 | remove this endif() |
Follow-up to fix the Windows build, https://github.com/llvm/llvm-project/commit/a7acee89d68473183cc5021d952a56cdf0ae27d3
compiler-rt/cmake/base-config-ix.cmake | ||
---|---|---|
183 | Hang on, you moved the code below from the else-branch of "if not msvc" to the if-branch, effectively flipping the condition under which it's used. |
compiler-rt/cmake/base-config-ix.cmake | ||
---|---|---|
183 | Oh, I assumed the "not msvc" part was deleted for a reason. I was just focusing on the msvc part. Looking closer, you might be right, this looks like it might be deleting a bit too much...? |
compiler-rt/cmake/base-config-ix.cmake | ||
---|---|---|
183 | Our Linux bots are also complaining about the fixup commit. Looks like non-MSVC no longer does any form of test_target_arch, but it still should? |
compiler-rt/cmake/base-config-ix.cmake | ||
---|---|---|
183 | Yes, it looks like deleting a little bit too much. I've milooked this indentation in review. |
compiler-rt/cmake/base-config-ix.cmake | ||
---|---|---|
183 | This change disabled _everything_ on x86_64 Linux. |
Hang on, you moved the code below from the else-branch of "if not msvc" to the if-branch, effectively flipping the condition under which it's used.