- User Since
- Nov 10 2017, 10:09 AM (108 w, 4 d)
Thu, Dec 5
Tue, Dec 3
Are there any plans to implement __declspec(guard(nocf)) or an equivalent mechanism? __attribute__((nocf_check)) doesn't do anything without the -fcf-protection flag. (https://bugs.llvm.org/show_bug.cgi?id=44096)
This lgtm from the Windows side but I'd feel better if you got an additional review from someone who knows gcov better than me.
Mon, Dec 2
The extra setup/teardown work for Windows relative to Linux is unfortunate. How would you feel about using an SRWLock instead? They accept a static initializer. (https://docs.microsoft.com/en-us/windows/win32/sync/slim-reader-writer--srw--locks)
Tue, Nov 19
Mon, Nov 18
Hi, I filed https://bugs.llvm.org/show_bug.cgi?id=44049 for some strange crashes that we're seeing because the CFG code overwrites the lower byte of function pointers before jumping to them. (Commenting separately here because I was unable to CC @ajpaverd in Bugzilla)
Oct 1 2019
For posterity: this was reverted in r361837.
Aug 2 2019
While debugging something else, I noticed that with this patch, Decl now has 33 bits worth of bitfields, so it has gained an extra word. Is that ok? Just want to make sure it wasn't unintentional.
Jul 30 2019
Jul 29 2019
May 16 2019
May 13 2019
No rush, I don't have any pressing need for a fix. I was just curious.
Apr 26 2019
I've confirmed that this fixes the Firefox repro, thanks!
Mar 12 2019
Are there any bugs/reviews/etc. that I can subscribe to for the implementation of this in COFF?
Feb 27 2019
Oh you know what, I bet it's https://reviews.llvm.org/D53540#1326473. Rust has an LLVM roll in progress as I write this, so this should just sort itself out.
The function that I'm interested in (a Rust function, on arm64, if it matters) is apparently failing the IMAGE_SYM_DTYPE_FUNCTION test. Is there any other category of thing that it could be?
So after some further digging I was wrong, and my particular bug isn't to do with S->kind(). :(
Feb 25 2019
@rnk would you be able to test this out on the nacl browser_tests before landing?
Feb 12 2019
Feb 11 2019
Feb 4 2019
Feb 1 2019
Jan 22 2019
Jan 18 2019
Even better -- thanks!
Jan 16 2019
The updated patch works for Firefox too.
I've confirmed that I can build Firefox successfully with this patch on top of latest trunk. Thank you @ssijaric!
Jan 9 2019
Jan 8 2019
Nov 19 2018
Thanks! I applied the patch and confirmed that it fixes the problematic Firefox DLL. (I don't know if I'm allowed to formally approve it though...)
Nov 9 2018
Nov 8 2018
Nov 2 2018
Oct 22 2018
Oct 15 2018
Oct 8 2018
Oct 3 2018
Relanded in r343606.
Oct 2 2018
Sep 26 2018
Sep 25 2018
After writing the last comment and thinking about this some more, I convinced myself that this is more of a problem with interceptors than exception handlers.
@rnk, do I guess correctly that the runtime pretty deeply assumes that it will never be unloaded? Interceptions, exception handlers, etc. never get cleaned up? If that's the case then I don't feel too bad about this hack. But if unloading is supported by the design, then maybe we should do something more graceful than this.
Sep 20 2018
Sep 14 2018
Sep 7 2018
This isn't strictly necessary for anything; I was just debugging something and noticed that a hook fell back to Trampoline rather than Hotpatch because the prefix nop was only 8 bytes.
Aug 16 2018
This broke Windows debug builds where MemalignFromLocalPool becomes an unresolved external. (I guess in optimized builds the call within the if(0) gets optimized away.)
Jun 5 2018
I don't know this code well enough to be a proper reviewer, but I want to offer moral support for this change. Not having atime updates on NTFS can be frustrating at times.