- User Since
- Nov 10 2017, 10:09 AM (307 w, 4 d)
Feb 22 2021
Feb 17 2021
We're seeing errors about duplicate gcov symbols in Rust code after this change: https://bugs.llvm.org/show_bug.cgi?id=49226
Feb 11 2021
coff-dwarf.test started failing after this commit: http://lab.llvm.org:8011/#/builders/109/builds/8398
This commit broke the build on aarch64 because OriginAddr() isn't defined on that platform, could you please take a look?
Feb 10 2021
Thank you for the quick followup!
This broke the windows bot: http://lab.llvm.org:8011/#/builders/86/builds/7540/steps/6/logs/stdio
Jan 28 2021
It does feel kind of awkward to me that _this_ is the patch that ends up breaking the builds, versus something at the cmake level that says "you are explicitly unsupported".
Jan 27 2021
If I'm reading git correctly, the change is still present on the 12.x branch. Should it be reverted there too?
Firefox has a build break from this change. In certain Android configurations we use bfd or gold. The statement in the commit message "Android only supports LLD" is news to me, could you point me to any references for this?
Jan 25 2021
On closer inspection (sorry, I'm juggling too many things this morning) it seems gcc does give a matching int nArgs = 1 under -std=c++17 mode.
The bot that reported this failure was using: clang -cc1 -triple x86_64-pc-windows-msvc19.16.27038 -fms-extensions -fms-compatibility -fms-compatibility-version=19.16.27038 -std=c++17
We have a downstream build break due to this commit. One of our files has some convoluted arg-counting logic that now returns a different count, which does not match gcc: https://godbolt.org/z/W8caMr (Note: At time of writing, the clang trunk on godbolt doesn't yet have this change.)
Jan 23 2021
Jan 22 2021
86991d323133 looks good from our side, thank you!
Jan 21 2021
To give you an early heads up, we're seeing crashes in Firefox after this commit. Unfortunately it's only happening on Mac, which I am not equipped to debug. I may need to try enlisting a colleague to investigate and/or throw more test suites at it and hope we can capture something on Linux or Windows.
Jan 19 2021
In case the reduced file from the other bug is insufficient, here's the full-size repro:
@zygoloid: we're seeing the same break with this as reported in the first landing: https://reviews.llvm.org/rG9e08e51a20d0d2b1c5724bb17e969d036fced4cd#966941 could you please take a look?
Jan 18 2021
Hi, after this commit our builds of wasi-sdk have broken because wasi-libc's makefile  finds an undefined symbol for __indirect_function_table that wasn't in its expected list .
Jan 13 2021
Jan 7 2021
Confirmed this fixes our original full-size repro, thanks! I'll let those better knowledgeable than me review the change though.
This commit caused a crash on our bots with a null LLVMTy at changeExtendedVectorElementType. Reduced case: https://godbolt.org/z/7ehffx
Jan 5 2021
I tried the updated patch against our build and it was successful. Thanks!
Jan 4 2021
Before the revert, our bots hit the following issue where we only error out when -Wall is given, so there's definitely something strange going on. Also happens with @Quuxplusone's suggested change applied.
Dec 22 2020
I see that this has been reverted, but while it was in tree, we had some errors on our Windows bots with a different symptom than Chrome's.
Dec 18 2020
Confirmed our bots are still OK after the re-landing. Thanks!
Dec 14 2020
Dec 10 2020
Heads up: the tests are failing on the bots http://lab.llvm.org:8011/#/builders/109/builds/4482/steps/6/logs/FAIL__LLVM__calling-conv-sext-zext_ll
Dec 7 2020
A fix for this is pushed now in https://sourceforge.net/p/mingw-w64/mingw-w64/ci/660e09f3cb20f181b6d6435cb623d65a3922a063/.
Dec 4 2020
Thanks a lot! Glad to see it's fine with a value of 1.5. (We have been setting it to 2 in our build as a temporary workaround)
Dec 2 2020
Dec 1 2020
Nov 30 2020
To connect the dots for posterity: the followup was landed in D92349.
Our mingw builds are failing with error: no member named '_aligned_malloc' in the global namespace. Should the new header have an #include <malloc.h> somewhere?
Nov 17 2020
Nov 16 2020
Firefox tests look good as well.
Nov 13 2020
This broke the bots: http://lab.llvm.org:8011/#/builders/109/builds/2682
Nov 12 2020
Nov 10 2020
Our bots are failing on the new assertion "The number of edge probabilities must match the number of successors." during PGO builds of clang.
I'm very happy to see this land, thank you for writing it!
Nov 4 2020
Oh, I didn't realize that Rui was inactive... trying rnk instead, based on recent commits under lld/COFF/.
Nov 2 2020
Oct 30 2020
After 10f2a0d662d8 our self-host PGO builds are hitting:
llvm::BranchProbability::getBranchProbability(uint64_t, uint64_t): Assertion `Numerator <= Denominator && "Probability cannot be bigger than 1!"' failed.
This commit triggered an assertion failure on our 32-bit bots:
Oct 29 2020
Oct 28 2020
I thiiiink I'm starting to see this a little better, and the problem is that the memcpy clobbers the optimized call slot.
Hi, we have a regression that started with this commit. The problem happens when GEP %43 is moved before the call on line 49: https://paste.mozilla.org/gYqBnKes . Can you see anything obviously wrong with that move?
Oct 27 2020
After this commit our bots have a failure on the wasm target, could you please take a look?
Oct 22 2020
In case it helps, I turned on debug logging for this pass on our repro: https://paste.mozilla.org/HBDkeGXO (starts at line 60)
Oct 21 2020
Could you help to check when block bb.0 is moved below bb.2?
Oct 20 2020
Unfortunately I don't have my git account handy either. I'm fine if this waits until tomorrow.
This is causing an assertion failure in our stage2 builds, could you please take a look? https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319157722&repo=ash&lineNumber=9931 The reproducer artifacts can be obtained by clicking "Show Job Info" in the top bar.
Oct 19 2020
Just a quick status update, I don't reproduce the issue with your script. I'm attempting to adjust the script to match our CI, but I'm distracted by other work.
This caused a regression when calling through function pointers in a certain way as seen in sqlite3: https://bugs.llvm.org/show_bug.cgi?id=47905
Oct 15 2020
Hi, this commit caused an assertion in one of our builds:
/builds/worker/fetches/llvm-project/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:1669: bool (anonymous namespace)::VarLocBasedLDV::join(llvm::MachineBasicBlock &, (anonymous namespace)::VarLocBasedLDV::VarLocInMBB &, (anonymous namespace)::VarLocBasedLDV::VarLocInMBB &, const (anonymous namespace)::VarLocBasedLDV::VarLocMap &, SmallPtrSet<const llvm::MachineBasicBlock *, 16> &, SmallPtrSetImpl<const llvm::MachineBasicBlock *> &): Assertion `(NumVisited || MBB.pred_empty()) && "Should have processed at least one predecessor"' failed.
It's an LTO+PGO build of Firefox so reproducing it is very time-consuming. I will try to get more info but it may take time and I wanted to give you an advance notice. In the meantime is there anything you can guess by inspection about what went wrong?
Oct 14 2020
It may actually be that -vp-counters-per-site needs adjusting. How do you reproduce?
Oct 13 2020
The build bot is happy with Diff 6! \o/
Oct 12 2020
[EDIT: This is specific to the armv7-linux-android target]
More errors: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318436438&repo=ash&lineNumber=15974
(Please note that there are two different files mentioned -- sanitizer_linux.cpp and sanitizer_linux_libcdep.cpp)
The v2 patch still fails with
And later we also get use of undeclared identifier 'dl_iterate_phdr' in (EDIT:) lsan_common_linux.cpp. We compile for API 16, which doesn't implement that.
This caused a build break in our compiler-rt build for Android: use of undeclared identifier '__interceptor_memalign'
Oct 7 2020
Oct 5 2020
This caused a failure on the bots: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/38144
Oct 2 2020
The bots are happy, thanks.
Thanks. I get the impression that libc++ has generally been more aggressive about raising requirements than LLVM overall. My org's crusty and underowned build has been getting caught up in that, so anything that you could codify as an upfront enforcement would be appreciated and probably lead to me bugging you less. =)
This appears to have broken our stage1 build which uses gcc 7:
Sep 25 2020
This change broke the configure step of Firefox mingw builds.
Sep 22 2020
The expensive-checks bots have been red for several days. Could you please take a look or revert?
Sep 21 2020
I threw as many tests as I could find at 9d172c8e9c84, and I don't see any regressions compared to its parent revision.
Sep 18 2020
Thanks, this fixes the specific translation unit I was looking at today. It's going to take some time before I have full build results but I don't expect any problems.
This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?
Thanks for the heads up. I'll schedule a more intensive test run over the weekend while there's less demand for machines.
Sep 17 2020
This broke Firefox builds too, in one of our helper binaries that uses a wWinMain, although I'm having trouble writing a minimal reproducer for it. Simply making a barebones wWinMain program doesn't hit the error.
Sep 16 2020
Sep 15 2020
Here is a reduced-ish repro, I can keep poking at it but maybe this is sufficient for you to notice something: https://godbolt.org/z/endf6d.
Sep 14 2020
Aug 28 2020
Our builds are back to green with that change. I agree that the root cause is likely elsewhere, but getting to the bottom of it would unfortunately take more time than I am able to commit.
Yeah, I wish I could give a nice test case, but it's a huge build and the affected configuration needs a lot of setup so I can't even replicate it locally at the moment.
Hi, we're seeing an assertion failure in one of the Firefox LTO bots:
char llvm::StringRef::operator(size_t) const: Assertion `Index < Length && "Invalid index!"' failed.
I'm still working on finishing the bisection but I have a hunch that it may be this change. Unfortunately I can't seem to get a backtrace out of this particular bot.
Aug 24 2020
We're seeing a break in the Firefox build after this change:
WidenVectorResult #0: t29: v2i32 = rotl t25, t28, /builds/worker/checkouts/gecko/gfx/angle/checkout/src/image_util/loadimage.cpp:640