dmajor (David Major)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2017, 10:09 AM (52 w, 4 d)

Recent Activity

Fri, Nov 9

dmajor added inline comments to D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Fri, Nov 9, 7:08 PM

Thu, Nov 8

dmajor added inline comments to D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Thu, Nov 8, 12:29 PM
dmajor added inline comments to D53540: [COFF, ARM64] Implement support for SEH extensions __try/__except/__finally.
Thu, Nov 8, 7:57 AM

Fri, Nov 2

dmajor added inline comments to D53988: Close file mapping handle on Windows, so flushed gcda files can be removed while the process is in execution.
Fri, Nov 2, 12:59 PM

Mon, Oct 22

dmajor added a comment to D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg.

Will abandon this patch since I have implementations of these which I will upstream soon.

Mon, Oct 22, 3:37 PM
Herald updated subscribers of D50166: [ARM64] [Windows] MCLayer support for exception handling.
Mon, Oct 22, 2:48 PM
dmajor added a comment to D53431: clang appears not to respect __attribute__((noinline)).

The intent of noinline in LLVM's IR is to block inlining, not all interprocedural optimizations. So I don't think this is actually a bug

Mon, Oct 22, 2:17 PM

Mon, Oct 15

dmajor created P8111 aarch64 crash 2.
Mon, Oct 15, 10:13 AM

Oct 8 2018

dmajor changed the visibility for P8110 aarch64 crash 1.
Oct 8 2018, 7:55 AM
dmajor created P8110 aarch64 crash 1.
Oct 8 2018, 7:53 AM

Oct 3 2018

dmajor added a comment to D52091: [winasan] Unpoison the stack in NtTerminateThread.

Relanded in r343606.

Oct 3 2018, 2:55 PM

Oct 2 2018

dmajor committed rCRT343606: Reland r342652 "[winasan] Unpoison the stack in NtTerminateThread".
Reland r342652 "[winasan] Unpoison the stack in NtTerminateThread"
Oct 2 2018, 10:21 AM
dmajor committed rL343606: Reland r342652 "[winasan] Unpoison the stack in NtTerminateThread".
Reland r342652 "[winasan] Unpoison the stack in NtTerminateThread"
Oct 2 2018, 10:20 AM

Sep 26 2018

dmajor committed rCRT343123: [winasan] Pin the ASan DLL to prevent unloading.
[winasan] Pin the ASan DLL to prevent unloading
Sep 26 2018, 9:31 AM
dmajor committed rL343123: [winasan] Pin the ASan DLL to prevent unloading.
[winasan] Pin the ASan DLL to prevent unloading
Sep 26 2018, 9:31 AM
dmajor closed D52505: [winasan] Pin the ASan DLL to prevent unloading.
Sep 26 2018, 9:31 AM

Sep 25 2018

dmajor requested review of D52505: [winasan] Pin the ASan DLL to prevent unloading.
Sep 25 2018, 3:50 PM
dmajor updated the diff for D52505: [winasan] Pin the ASan DLL to prevent unloading.

After writing the last comment and thinking about this some more, I convinced myself that this is more of a problem with interceptors than exception handlers.

Sep 25 2018, 3:50 PM
dmajor added inline comments to D52505: [winasan] Pin the ASan DLL to prevent unloading.
Sep 25 2018, 2:56 PM
dmajor added a comment to D52505: [winasan] Pin the ASan DLL to prevent unloading.

@rnk, do I guess correctly that the runtime pretty deeply assumes that it will never be unloaded? Interceptions, exception handlers, etc. never get cleaned up? If that's the case then I don't feel too bad about this hack. But if unloading is supported by the design, then maybe we should do something more graceful than this.

Sep 25 2018, 9:15 AM
dmajor created D52505: [winasan] Pin the ASan DLL to prevent unloading.
Sep 25 2018, 9:12 AM

Sep 20 2018

dmajor committed rCRT342654: Fix test after r342652.
Fix test after r342652
Sep 20 2018, 8:26 AM
dmajor committed rL342654: Fix test after r342652.
Fix test after r342652
Sep 20 2018, 8:26 AM
dmajor committed rL342652: [winasan] Unpoison the stack in NtTerminateThread.
[winasan] Unpoison the stack in NtTerminateThread
Sep 20 2018, 8:01 AM
dmajor committed rCRT342652: [winasan] Unpoison the stack in NtTerminateThread.
[winasan] Unpoison the stack in NtTerminateThread
Sep 20 2018, 8:00 AM
dmajor closed D52091: [winasan] Unpoison the stack in NtTerminateThread.
Sep 20 2018, 8:00 AM
dmajor committed rL342649: [winasan] Reduce hotpatch prefix check to 8 bytes.
[winasan] Reduce hotpatch prefix check to 8 bytes
Sep 20 2018, 7:30 AM
dmajor committed rCRT342649: [winasan] Reduce hotpatch prefix check to 8 bytes.
[winasan] Reduce hotpatch prefix check to 8 bytes
Sep 20 2018, 7:30 AM
dmajor closed D51788: [winasan] Reduce hotpatch prefix check to 8 bytes.
Sep 20 2018, 7:30 AM

Sep 14 2018

dmajor created D52091: [winasan] Unpoison the stack in NtTerminateThread.
Sep 14 2018, 6:00 AM

Sep 7 2018

dmajor added a comment to D51788: [winasan] Reduce hotpatch prefix check to 8 bytes.

This isn't strictly necessary for anything; I was just debugging something and noticed that a hook fell back to Trampoline rather than Hotpatch because the prefix nop was only 8 bytes.

Sep 7 2018, 8:09 AM
dmajor created D51788: [winasan] Reduce hotpatch prefix check to 8 bytes.
Sep 7 2018, 7:14 AM

Aug 16 2018

dmajor added a comment to D47916: [asan, myriad] Use local pool for new/delete when ASan run-time is not up.

This broke Windows debug builds where MemalignFromLocalPool becomes an unresolved external. (I guess in optimized builds the call within the if(0) gets optimized away.)

Aug 16 2018, 8:33 AM

Jun 5 2018

dmajor added a comment to D47266: Update thin-lto cache file atimes when on windows.

I don't know this code well enough to be a proper reviewer, but I want to offer moral support for this change. Not having atime updates on NTFS can be frustrating at times.

Jun 5 2018, 2:19 PM

May 11 2018

dmajor committed rCRT332095: [winasan] Update GetInstructionSize for Win10 1803.
[winasan] Update GetInstructionSize for Win10 1803
May 11 2018, 7:35 AM
dmajor committed rL332095: [winasan] Update GetInstructionSize for Win10 1803.
[winasan] Update GetInstructionSize for Win10 1803
May 11 2018, 7:34 AM
dmajor closed D46458: [winasan] Update GetInstructionSize for Win10 1803.
May 11 2018, 7:34 AM
dmajor committed rCRT332092: [ASan] Fix range check in AddrIsInHighShadow.
[ASan] Fix range check in AddrIsInHighShadow
May 11 2018, 7:27 AM
dmajor committed rL332092: [ASan] Fix range check in AddrIsInHighShadow.
[ASan] Fix range check in AddrIsInHighShadow
May 11 2018, 7:27 AM
dmajor closed D46291: [ASan] Fix range check in AddrIsInHighShadow.
May 11 2018, 7:27 AM

May 4 2018

dmajor added a reviewer for D46458: [winasan] Update GetInstructionSize for Win10 1803: rnk.
May 4 2018, 1:47 PM
dmajor created D46458: [winasan] Update GetInstructionSize for Win10 1803.
May 4 2018, 1:47 PM
dmajor committed rCRT331523: Comment fix..
Comment fix.
May 4 2018, 7:46 AM
dmajor committed rL331523: Comment fix..
Comment fix.
May 4 2018, 7:45 AM

May 1 2018

dmajor updated the diff for D46291: [ASan] Fix range check in AddrIsInHighShadow.

Fixed AddrIsInMidShadow too.

May 1 2018, 1:33 PM
dmajor added a comment to D46291: [ASan] Fix range check in AddrIsInHighShadow.

Hmm, come to think of it, AddrIsInMidShadow has the same bug, right?

May 1 2018, 1:08 PM

Apr 30 2018

dmajor created D46291: [ASan] Fix range check in AddrIsInHighShadow.
Apr 30 2018, 3:07 PM

Dec 14 2017

dmajor added a comment to D39994: Loosen MSVC 2017 path requirements.

Anyway, I'm just venting. If rnk@ wants to lgtm this, I'm fine.

Dec 14 2017, 11:59 AM

Dec 6 2017

dmajor added a comment to D39968: [COFF] Ignore semicolons in module definition identifiers.

@ruiu Does this patch look ok?

Dec 6 2017, 10:46 AM · lld

Nov 22 2017

dmajor updated the diff for D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.

While writing a test I found a problem: the code that infers /entry should not run if we've previously defined one in a drectve. (In Mozilla's build, it worked by accident because the drectve was redundantly specifying the same function that got inferred.) Updated the patch.

Nov 22 2017, 12:36 PM · lld

Nov 20 2017

dmajor added a comment to D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.
Nov 20 2017, 1:58 PM · lld
dmajor updated the diff for D39968: [COFF] Ignore semicolons in module definition identifiers.

Added a test. If this looks OK, do you mind landing it for me?

Nov 20 2017, 9:20 AM · lld

Nov 13 2017

dmajor created D39994: Loosen MSVC 2017 path requirements.
Nov 13 2017, 5:52 PM
dmajor created D39972: [LLD] [COFF] Support ENTRY and SUBSYSTEM in .drectve sections.
Nov 13 2017, 12:46 PM · lld
dmajor updated subscribers of D39968: [COFF] Ignore semicolons in module definition identifiers.
Nov 13 2017, 11:14 AM · lld
dmajor created D39968: [COFF] Ignore semicolons in module definition identifiers.
Nov 13 2017, 10:40 AM · lld