Page MenuHomePhabricator

dmajor (dmajor)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 10 2017, 10:09 AM (166 w, 6 d)

Recent Activity

Yesterday

dmajor added a comment to D93764: [LoopUnswitch] Implement first version of partial unswitching..

To give you an early heads up, we're seeing crashes in Firefox after this commit. Unfortunately it's only happening on Mac, which I am not equipped to debug. I may need to try enlisting a colleague to investigate and/or throw more test suites at it and hope we can capture something on Linux or Windows.

Thu, Jan 21, 4:31 PM · Restricted Project

Tue, Jan 19

dmajor added a comment to rG4b574008aef5: [c++20] P1907R1: Support for generalized non-type template arguments of scalar….

Should be fixed in 18e093faf726d15f210ab4917142beec51848258. Sorry I
overlooked your comment on the previous landing of this change.

Tue, Jan 19, 8:12 PM
dmajor added a comment to rG4b574008aef5: [c++20] P1907R1: Support for generalized non-type template arguments of scalar….

In case the reduced file from the other bug is insufficient, here's the full-size repro:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/G5HdGFm8Tx-NLTTMnO-2vw/runs/0/artifacts/public/build/Unified_cpp_js_src_wasm2-ff66ce.cpp
and
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/G5HdGFm8Tx-NLTTMnO-2vw/runs/0/artifacts/public/build/Unified_cpp_js_src_wasm2-ff66ce.sh

Tue, Jan 19, 1:09 PM
dmajor added a comment to rG4b574008aef5: [c++20] P1907R1: Support for generalized non-type template arguments of scalar….

@zygoloid: we're seeing the same break with this as reported in the first landing: https://reviews.llvm.org/rG9e08e51a20d0d2b1c5724bb17e969d036fced4cd#966941 could you please take a look?

Tue, Jan 19, 12:07 PM

Mon, Jan 18

dmajor added a comment to D92215: [WebAssembly] MC layer writes table symbols to object files.

Here's the log: https://firefoxci.taskcluster-artifacts.net/U_L_Cc_QRxiRefZVNDs8KQ/0/public/logs/live_backing.log

Mon, Jan 18, 3:04 PM · Restricted Project
dmajor added a comment to D92215: [WebAssembly] MC layer writes table symbols to object files.

Hi, after this commit our builds of wasi-sdk have broken because wasi-libc's makefile [1] finds an undefined symbol for __indirect_function_table that wasn't in its expected list [2].

Mon, Jan 18, 12:07 PM · Restricted Project

Wed, Jan 13

dmajor added a reviewer for D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior: steveire.
Wed, Jan 13, 12:29 PM · Restricted Project

Thu, Jan 7

dmajor added a comment to D94234: [AArch64] Fix crash caused by invalid vector element type.

Confirmed this fixes our original full-size repro, thanks! I'll let those better knowledgeable than me review the change though.

Thu, Jan 7, 8:49 AM · Restricted Project
dmajor added a comment to D91255: [AArch64] Rearrange mul(dup(sext/zext)) to mul(sext/zext(dup)).

This commit caused a crash on our bots with a null LLVMTy at changeExtendedVectorElementType. Reduced case: https://godbolt.org/z/7ehffx

Thu, Jan 7, 7:20 AM · Restricted Project

Tue, Jan 5

dmajor added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

I tried the updated patch against our build and it was successful. Thanks!

Tue, Jan 5, 9:35 AM · Restricted Project

Mon, Jan 4

dmajor added a comment to D92936: [Sema] Fix deleted function problem in implicitly movable test.

Before the revert, our bots hit the following issue where we only error out when -Wall is given, so there's definitely something strange going on. Also happens with @Quuxplusone's suggested change applied.

Mon, Jan 4, 11:50 AM · Restricted Project

Dec 22 2020

dmajor added a comment to rG9e08e51a20d0: [c++20] P1907R1: Support for generalized non-type template arguments of scalar….

I see that this has been reverted, but while it was in tree, we had some errors on our Windows bots with a different symptom than Chrome's.

Dec 22 2020, 1:15 PM

Dec 18 2020

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Confirmed our bots are still OK after the re-landing. Thanks!

Dec 18 2020, 8:47 AM · Restricted Project

Dec 14 2020

dmajor added inline comments to D91813: [PGO] verify BFI counts after loading profile data.
Dec 14 2020, 4:50 PM · Restricted Project, Restricted Project

Dec 10 2020

dmajor added a comment to D92793: [RISCV] Add (Proposed) Assembler Extend Pseudo-Instructions.

Heads up: the tests are failing on the bots http://lab.llvm.org:8011/#/builders/109/builds/4482/steps/6/logs/FAIL__LLVM__calling-conv-sext-zext_ll

Dec 10 2020, 12:00 PM · Restricted Project

Dec 7 2020

dmajor added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

A fix for this is pushed now in https://sourceforge.net/p/mingw-w64/mingw-w64/ci/660e09f3cb20f181b6d6435cb623d65a3922a063/.

Dec 7 2020, 9:46 AM · Restricted Project, Restricted Project

Dec 4 2020

dmajor added a comment to D92669: [PGO] Adjust -vp-counters-per-site..

Thanks a lot! Glad to see it's fine with a value of 1.5. (We have been setting it to 2 in our build as a temporary workaround)

Dec 4 2020, 10:02 AM · Restricted Project

Dec 2 2020

dmajor added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

I haven't run into this issue - how do you end up getting intrin.h included before the other includes here?

Dec 2 2020, 8:41 AM · Restricted Project, Restricted Project

Dec 1 2020

dmajor updated subscribers of D91379: [libc++] Factor out common logic for calling aligned allocation.

Our mingw builds are failing with error: no member named '_aligned_malloc' in the global namespace. Should the new header have an #include <malloc.h> somewhere?

That's weird, as we were not including <malloc.h> anywhere before either. Can you confirm that including <malloc.h> fixes your issue? I'm wary of adding non standard includes in our headers, since it causes all kinds of problems.

Dec 1 2020, 8:10 PM · Restricted Project, Restricted Project

Nov 30 2020

dmajor added a comment to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

To connect the dots for posterity: the followup was landed in D92349.

Nov 30 2020, 6:01 PM · Restricted Project
dmajor added a comment to D91379: [libc++] Factor out common logic for calling aligned allocation.

Our mingw builds are failing with error: no member named '_aligned_malloc' in the global namespace. Should the new header have an #include <malloc.h> somewhere?

Nov 30 2020, 10:01 AM · Restricted Project, Restricted Project
dmajor added a comment to D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros.

Looks like _LIBCPP_HAS_NO_THREADS is being set for libcxxabi, and the build now fails with this change:

llvm-project/libcxxabi/../libcxx/include/__config:1172:2: error: _LIBCPP_HAS_NO_THREADS cannot be set when STDCPP_THREADS is set

Nov 30 2020, 9:05 AM · Restricted Project

Nov 17 2020

dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

It seems that I can't reproduce it. Here's my script. Can you reproduce with it or modify it so it reproduces?

Nov 17 2020, 11:16 AM · Restricted Project, Restricted Project

Nov 16 2020

dmajor added a comment to D87544: [CFGuard] Add address-taken IAT tables and delay-load support.

Firefox tests look good as well.

Nov 16 2020, 10:02 AM · Restricted Project

Nov 13 2020

dmajor added a comment to D91330: [clangd] Ensure we test for compatibility of serialized index format.

Looks like it is already green at http://lab.llvm.org:8011/#/builders/109/builds/2693

Nov 13 2020, 9:38 AM · Restricted Project
dmajor added a comment to D91330: [clangd] Ensure we test for compatibility of serialized index format.

This broke the bots: http://lab.llvm.org:8011/#/builders/109/builds/2682

Nov 13 2020, 9:36 AM · Restricted Project

Nov 12 2020

dmajor added reviewers for D91153: [IndVarSimplify] Fix Modified status when handling dead PHI nodes: mkazantsev, lebedev.ri.
Nov 12 2020, 5:45 PM · Restricted Project

Nov 10 2020

dmajor added a comment to D91017: [BranchProbabilityInfo] Use SmallVector (NFC).

Our bots are failing on the new assertion "The number of edge probabilities must match the number of successors." during PGO builds of clang.

Nov 10 2020, 5:18 PM · Restricted Project
dmajor added a comment to D87951: Enable opt-bisect for the new pass manager.

I'm very happy to see this land, thank you for writing it!

Nov 10 2020, 7:46 AM · Restricted Project

Nov 4 2020

dmajor added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Nov 4 2020, 7:45 PM · Restricted Project
dmajor added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Nov 4 2020, 7:41 PM · Restricted Project
dmajor added a reviewer for D90624: [lld][COFF] Add command line options for LTO with new pass manager: rnk.

Oh, I didn't realize that Rui was inactive... trying rnk instead, based on recent commits under lld/COFF/.

Nov 4 2020, 10:04 AM · Restricted Project

Nov 2 2020

dmajor requested review of D90624: [lld][COFF] Add command line options for LTO with new pass manager.
Nov 2 2020, 9:33 AM · Restricted Project

Oct 30 2020

dmajor added a comment to D88609: Use uint64_t for branch weights instead of uint32_t.

After 10f2a0d662d8 our self-host PGO builds are hitting:
llvm::BranchProbability::getBranchProbability(uint64_t, uint64_t): Assertion `Numerator <= Denominator && "Probability cannot be bigger than 1!"' failed.

Oct 30 2020, 6:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
dmajor added a comment to D89969: [SLP] Consider alternatives for cost of select instructions..

This commit triggered an assertion failure on our 32-bit bots:

Oct 30 2020, 12:48 PM · Restricted Project

Oct 29 2020

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

@dmajor and @aeubanks, could you help to see if the following patch can fix the crash when combined with patch adfb5415010f?

Oct 29 2020, 5:03 PM · Restricted Project
dmajor added a comment to D89623: [MemCpyOpt] Move GEP during call slot optimization.

@dmajor If the call slot optimization applies, then that load/store pair should also get dropped as part of the optimization. I don't immediately see how we can end up both changing the call argument and not dropping the load/store, if I understand right what is happening in your case.

Oct 29 2020, 10:33 AM · Restricted Project

Oct 28 2020

dmajor added a comment to D89623: [MemCpyOpt] Move GEP during call slot optimization.

I thiiiink I'm starting to see this a little better, and the problem is that the memcpy clobbers the optimized call slot.

Oct 28 2020, 7:30 PM · Restricted Project
dmajor added a comment to D89623: [MemCpyOpt] Move GEP during call slot optimization.

Hi, we have a regression that started with this commit. The problem happens when GEP %43 is moved before the call on line 49: https://paste.mozilla.org/gYqBnKes . Can you see anything obviously wrong with that move?

Oct 28 2020, 3:03 PM · Restricted Project

Oct 27 2020

dmajor added a comment to D87528: Enable '#pragma STDC FENV_ACCESS' in frontend.

After this commit our bots have a failure on the wasm target, could you please take a look?

Oct 27 2020, 8:57 AM · Restricted Project

Oct 22 2020

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

In case it helps, I turned on debug logging for this pass on our repro: https://paste.mozilla.org/HBDkeGXO (starts at line 60)

Oct 22 2020, 7:10 PM · Restricted Project

Oct 21 2020

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Could you help to check when block bb.0 is moved below bb.2?

Oct 21 2020, 3:25 PM · Restricted Project

Oct 20 2020

dmajor updated subscribers of D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Adding @jmorse in case D83046 is related.

Oct 20 2020, 2:26 PM · Restricted Project
dmajor added a comment to rGe372a5f86f64: [InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3))….

Unfortunately I don't have my git account handy either. I'm fine if this waits until tomorrow.

Oct 20 2020, 1:32 PM
dmajor added a comment to rGe372a5f86f64: [InstCombine] Add or((icmp ult/ule (A + C1), C3), (icmp ult/ule (A + C2), C3))….

This is causing an assertion failure in our stage2 builds, could you please take a look? https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319157722&repo=ash&lineNumber=9931 The reproducer artifacts can be obtained by clicking "Show Job Info" in the top bar.

Oct 20 2020, 11:38 AM

Oct 19 2020

dmajor added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Oct 19 2020, 12:57 PM · Restricted Project
dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

Just a quick status update, I don't reproduce the issue with your script. I'm attempting to adjust the script to match our CI, but I'm distracted by other work.

Oct 19 2020, 12:41 PM · Restricted Project, Restricted Project
dmajor added a comment to D87544: [CFGuard] Add address-taken IAT tables and delay-load support.

This caused a regression when calling through function pointers in a certain way as seen in sqlite3: https://bugs.llvm.org/show_bug.cgi?id=47905

Oct 19 2020, 10:28 AM · Restricted Project

Oct 15 2020

dmajor added a comment to D89088: [MBP] Add whole chain to BlockFilterSet instead of individual BB.

Hi, this commit caused an assertion in one of our builds:

/builds/worker/fetches/llvm-project/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:1669: bool (anonymous namespace)::VarLocBasedLDV::join(llvm::MachineBasicBlock &, (anonymous namespace)::VarLocBasedLDV::VarLocInMBB &, (anonymous namespace)::VarLocBasedLDV::VarLocInMBB &, const (anonymous namespace)::VarLocBasedLDV::VarLocMap &, SmallPtrSet<const llvm::MachineBasicBlock *, 16> &, SmallPtrSetImpl<const llvm::MachineBasicBlock *> &): Assertion `(NumVisited || MBB.pred_empty()) && "Should have processed at least one predecessor"' failed.

It's an LTO+PGO build of Firefox so reproducing it is very time-consuming. I will try to get more info but it may take time and I wanted to give you an advance notice. In the meantime is there anything you can guess by inspection about what went wrong?

Oct 15 2020, 8:28 PM · Restricted Project

Oct 14 2020

dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

It may actually be that -vp-counters-per-site needs adjusting. How do you reproduce?

Oct 14 2020, 8:40 AM · Restricted Project, Restricted Project

Oct 13 2020

dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 causes our PGO build of clang to have thousands of

LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time.

Is that expected? Should the cmake set a higher value of -vp-counters-per-site in self-hosted PGO builds?

This has been reverted for now. There was a related issue.

Oct 13 2020, 11:14 AM · Restricted Project, Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

The build bot is happy with Diff 6! \o/

Oct 13 2020, 8:40 AM · Restricted Project

Oct 12 2020

dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

[EDIT: This is specific to the armv7-linux-android target]

Oct 12 2020, 9:02 PM · Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

More errors: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318436438&repo=ash&lineNumber=15974
(Please note that there are two different files mentioned -- sanitizer_linux.cpp and sanitizer_linux_libcdep.cpp)

Oct 12 2020, 5:50 PM · Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

Latest errors: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318424891&repo=ash&lineNumber=23010

Oct 12 2020, 2:47 PM · Restricted Project
dmajor added a comment to D89251: Reland [lsan] Enable LSAN for Android.

The v2 patch still fails with

Oct 12 2020, 12:36 PM · Restricted Project
dmajor added a comment to D85927: Enable LSAN for Android.

Thanks for the report!

This caused a build break in our compiler-rt build for Android: use of undeclared identifier '__interceptor_memalign'

Are you also building with API 16? (From your second comment)

Oct 12 2020, 10:41 AM · Restricted Project
dmajor added a comment to D85927: Enable LSAN for Android.

And later we also get use of undeclared identifier 'dl_iterate_phdr' in (EDIT:) lsan_common_linux.cpp. We compile for API 16, which doesn't implement that.

Oct 12 2020, 9:04 AM · Restricted Project
dmajor added a comment to D85927: Enable LSAN for Android.

This caused a build break in our compiler-rt build for Android: use of undeclared identifier '__interceptor_memalign'

Oct 12 2020, 8:16 AM · Restricted Project

Oct 7 2020

dmajor created P8239 After loop-vectorize.
Oct 7 2020, 1:39 PM
dmajor created P8238 Before loop-vectorize.
Oct 7 2020, 1:38 PM

Oct 5 2020

dmajor added a comment to D87836: [ARM] Fold select_cc(vecreduce_[u|s][min|max], x) into VMINV or VMAXV.

This caused a failure on the bots: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/38144

Oct 5 2020, 10:49 AM · Restricted Project

Oct 2 2020

dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

The bots are happy, thanks.

Oct 2 2020, 4:37 PM
dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

Thanks. I get the impression that libc++ has generally been more aggressive about raising requirements than LLVM overall. My org's crusty and underowned build has been getting caught up in that, so anything that you could codify as an upfront enforcement would be appreciated and probably lead to me bugging you less. =)

Oct 2 2020, 2:25 PM
dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

Can you move to the runtimes build, which builds libc++ with the just-built Clang instead of with whatever compiler happens to be on your system?

Oct 2 2020, 2:16 PM
dmajor added a comment to rG3e5f9dacb092: [libc++] Fix tests on GCC 10.

This appears to have broken our stage1 build which uses gcc 7:

Oct 2 2020, 1:48 PM

Sep 25 2020

dmajor added a comment to D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling.

This change broke the configure step of Firefox mingw builds.

Sep 25 2020, 8:31 PM · Restricted Project

Sep 22 2020

dmajor added a comment to D83004: [UpdateCCTestChecks] Include generated functions if asked.

The expensive-checks bots have been red for several days. Could you please take a look or revert?

Sep 22 2020, 7:56 AM · Restricted Project, Restricted Project

Sep 21 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I threw as many tests as I could find at 9d172c8e9c84, and I don't see any regressions compared to its parent revision.

Sep 21 2020, 12:32 PM · Restricted Project, Restricted Project

Sep 18 2020

dmajor added a comment to D87917: [Sema] Handle objc_super special lookup when checking builtin compatibility.

Thanks, this fixes the specific translation unit I was looking at today. It's going to take some time before I have full build results but I don't expect any problems.

Sep 18 2020, 11:05 AM · Restricted Project
dmajor added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

This commit broke Firefox builds on Mac with an error in the SDK headers. Could you please revert if a fix is not readily available?

Sep 18 2020, 9:40 AM · Restricted Project
dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Thanks for the heads up. I'll schedule a more intensive test run over the weekend while there's less demand for machines.

Sep 18 2020, 5:05 AM · Restricted Project, Restricted Project

Sep 17 2020

dmajor added a comment to D87701: Do not apply calling conventions to MSVC entry points.

This broke Firefox builds too, in one of our helper binaries that uses a wWinMain, although I'm having trouble writing a minimal reproducer for it. Simply making a barebones wWinMain program doesn't hit the error.

Sep 17 2020, 1:41 PM · Restricted Project

Sep 16 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I checked in a fix in https://reviews.llvm.org/rGfc8200633122, but I haven't yet verified it addresses all the failures reported.

Sep 16 2020, 8:42 AM · Restricted Project, Restricted Project

Sep 15 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Reduced a bit more: https://godbolt.org/z/j59evK (C++) and https://godbolt.org/z/8xG688 (IR) -- the store at line 43 of while.end has been removed.

Sep 15 2020, 9:21 AM · Restricted Project, Restricted Project
dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Here is a reduced-ish repro, I can keep poking at it but maybe this is sufficient for you to notice something: https://godbolt.org/z/endf6d.

Sep 15 2020, 8:50 AM · Restricted Project, Restricted Project

Sep 14 2020

dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

I also pushed a fix for a MemorySSA issue that was exposed through DSE + MemorySSA in c4f1b3144184. This might also fix (some) of the failures you are seeing.

Sep 14 2020, 2:22 PM · Restricted Project, Restricted Project
dmajor added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Heads-up: We're seeing fairly widespread test failures with this in Chromium that go away when we force this flag off. It's possible that it's due to only a small number of issues and they might be previously-benign UB (no idea), but I figured I'd give an early note. We'll send an update once we've reduced a failing test.

Thanks for the heads-up. I just pushed another fix for the issue @uabelho. I'd guess at least some of the failures you are seeing should be related. If not, I think it makes sense to revert this once we have the reproducers and can work in ironing out the remaining issues.

Sep 14 2020, 1:27 PM · Restricted Project, Restricted Project

Aug 28 2020

dmajor added a comment to D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab.

Our builds are back to green with that change. I agree that the root cause is likely elsewhere, but getting to the bottom of it would unfortunately take more time than I am able to commit.

Aug 28 2020, 6:09 PM · Restricted Project
dmajor added a comment to D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab.

Yeah, I wish I could give a nice test case, but it's a huge build and the affected configuration needs a lot of setup so I can't even replicate it locally at the moment.

Aug 28 2020, 1:26 PM · Restricted Project
dmajor added a comment to D84803: [ThinLTO][Legacy] Compute PreservedGUID based on IRName in Symtab.

Hi, we're seeing an assertion failure in one of the Firefox LTO bots:

char llvm::StringRef::operator[](size_t) const: Assertion `Index < Length && "Invalid index!"' failed.

I'm still working on finishing the bisection but I have a hunch that it may be this change. Unfortunately I can't seem to get a backtrace out of this particular bot.

Aug 28 2020, 11:40 AM · Restricted Project

Aug 24 2020

dmajor added a comment to D77152: [SelectionDAG] Better legalization for FSHL and FSHR.

We're seeing a break in the Firefox build after this change:

WidenVectorResult #0: t29: v2i32 = rotl t25, t28, /builds/worker/checkouts/gecko/gfx/angle/checkout/src/image_util/loadimage.cpp:640
Aug 24 2020, 8:59 AM · Restricted Project

Aug 17 2020

dmajor added a comment to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
In D86103#2222585, @yln wrote:

I just discovered that this is still not enough; linking still fails with SDK < 10.14.

Aug 17 2020, 2:38 PM · Restricted Project
dmajor added a comment to D86103: [TSan][libdispatch] Ensure TSan dylib works on old systems.
In D86103#2222302, @yln wrote:

@dmajor: do you have a quick way to check if this unbreaks your builds?
Another follow-up might be required to make the test work: https://reviews.llvm.org/D85995

Aug 17 2020, 1:23 PM · Restricted Project
dmajor added a comment to D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

Our automation builds are broken after this change, with undefined symbols for _dispatch_async_and_wait{,_f}. We build using the 10.12 SDK with a deployment target of 10.11. Should this code have a version check?

Aug 17 2020, 8:23 AM · Restricted Project

Aug 10 2020

dmajor added a comment to D85545: [Diagnostics] Diagnose missing comma in string array initialization.

In the Firefox repo this warning is firing on a number of strings that were broken up by clang-format (or humans) for line length, for example https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/security/certverifier/ExtendedValidation.cpp#176-178 or https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/xpcom/tests/gtest/TestEscape.cpp#103-104 or https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/js/src/jsapi-tests/testXDR.cpp#115.

Aug 10 2020, 2:21 PM · Restricted Project

Aug 6 2020

dmajor added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

I've now opened https://github.com/WebAssembly/wasi-sdk/pull/151/ to remove the --no-threads from wasi-sdk, which was a workaround for an old bug that has long been fixed.

Aug 6 2020, 9:52 AM · Restricted Project

Aug 4 2020

dmajor added a comment to D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={1,2,...} /threads:{1,2,...}.

--no-threads is used rarely. So just delete --no-threads instead of keeping it for compatibility for a while.

Aug 4 2020, 12:30 PM · Restricted Project

Aug 3 2020

dmajor added a comment to D82562: Implement AVX ABI Warning/error.

@erichkeane, could you help me understand what is the action item of these warnings?

Aug 3 2020, 12:24 PM · Restricted Project

Jul 23 2020

dmajor added a comment to D84474: [libFuzzer] Add a missing include_directories..

I've confirmed that this fixes our builds, thank you.

Jul 23 2020, 6:15 PM · Restricted Project
dmajor added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

After this commit, several of our builds are failing with FuzzerInterceptors.cpp:30:10: fatal error: 'sanitizer/common_interface_defs.h' file not found. This is odd because the file certainly seems like it exists. Is there a missing include path somewhere, perhaps?

Jul 23 2020, 3:19 PM · Restricted Project, Restricted Project
dmajor accepted D84418: [libc++] Build the dylib with -faligned-allocation.

Our mac builds are back to green, and no complaints from the other platforms. Thank you!

Jul 23 2020, 10:05 AM · Restricted Project
dmajor added a comment to D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD).

To connect the dots for anyone following along: this was reverted in cc28058c13e89ecc85dac7e1bd5d13a2ce1bb620.

Jul 23 2020, 8:48 AM · Restricted Project
dmajor added a comment to D84418: [libc++] Build the dylib with -faligned-allocation.

Kicked off a run.

Jul 23 2020, 8:27 AM · Restricted Project
dmajor added a comment to D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete.

Hmmm. There's a few interesting things here. First, I'd like to understand why you're building the dylib with a deployment target of 10.11 -- we usually make the assumption that people building libc++ are vendors, and we take for granted that they're building for new-ish platforms. For example, at Apple, we only build the dylib for the latest OS because that's what the dylib is going into, so using an older deployment target just doesn't make sense. If you have another use case, it might be useful to know about it for the future.

Jul 23 2020, 7:00 AM · Restricted Project

Jul 22 2020

dmajor added a comment to D83219: [ARM] Add MVE_TwoOpPattern. NFC.

We just noticed this in Firefox as well, and I confirmed that 411eb87c7962ec817ab6bf7aa3c737a3159d2d4e fixes the issue for us. Thanks for the fast response!

Jul 22 2020, 4:35 PM · Restricted Project
dmajor added a comment to D81682: [PGO] Extend the value profile buckets for mem op sizes..

The re-landing of this patch in 4a539faf74b9b4c25ee3b880e4007564bd5139b0 causes our PGO build of clang to have thousands of

LLVM Profile Warning: Unable to track new values: Running out of static counters.  Consider using option -mllvm -vp-counters-per-site=<n> to allocate more value profile counters at compile time.

Is that expected? Should the cmake set a higher value of -vp-counters-per-site in self-hosted PGO builds?

Jul 22 2020, 3:11 PM · Restricted Project, Restricted Project
dmajor added a comment to D75243: [libc++] Build the dylib with C++17 to allow aligned new/delete.

In our builds with the 10.12 SDK and MACOSX_DEPLOYMENT_TARGET of 10.11, this is producing

Jul 22 2020, 3:00 PM · Restricted Project

Jul 15 2020

dmajor added a comment to D82148: [compiler-rt][Android] Stop using detect_target_arch.

The revert fixes our build too. Just in time for the 11.0.0 branch, thanks @aeubanks!

Jul 15 2020, 9:37 AM · Restricted Project

Jul 14 2020

dmajor added a comment to D82148: [compiler-rt][Android] Stop using detect_target_arch.

Hi, this commit seems to have caused a problem in Firefox. We're no longer getting a libclang_rt.profile-arm-android.a in our clang package when we request armv7-linux-android. Does arm need special translation similar to the i686->i386 special case?

Jul 14 2020, 12:37 PM · Restricted Project