This is an archive of the discontinued LLVM Phabricator instance.

Add an mlir natvis file for debugging with Visual Studio
ClosedPublic

Authored by kile on Oct 16 2020, 4:02 PM.

Download Raw Diff

Details

Reviewers

asmith
mspertus
jpienaar

Commits

rGf98bb414f58e: Add a mlir natvis file for debugging with Visual Studio

Diff Detail

Event Timeline

kile created this revision.Oct 16 2020, 4:02 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 16 2020, 4:02 PM

Herald added subscribers: rdzhabarov, tatianashp, msifontes and 13 others. · View Herald Transcript

kile requested review of this revision.Oct 16 2020, 4:02 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptOct 16 2020, 4:02 PM

Harbormaster completed remote builds in B75390: Diff 298776.Oct 16 2020, 4:34 PM

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

In D89601#2336384, @jpienaar wrote:

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

In D89601#2336394, @asmith wrote:

In D89601#2336384, @jpienaar wrote:

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Ah I see, that makes sense.

Thanks for the contribution!

LGTM on the principle, but I can't review the correctness as I'm unfamiliar with the format.

In D89601#2336431, @jpienaar wrote:

In D89601#2336394, @asmith wrote:

In D89601#2336384, @jpienaar wrote:

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Ah I see, that makes sense.

I wonder if it makes sense to move all the nativs files under the llvm-project/utils/ directory?

In D89601#2336956, @asmith wrote:

In D89601#2336431, @jpienaar wrote:

In D89601#2336394, @asmith wrote:

In D89601#2336384, @jpienaar wrote:

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Ah I see, that makes sense.

I wonder if it makes sense to move all the nativs files under the llvm-project/utils/ directory?

That would make sense, though I do worry about breaking devs who wouldn't be expecting their natvis files to move...ultimately up to you :)

In D89601#2336484, @mehdi_amini wrote:

Thanks for the contribution!

LGTM on the principle, but I can't review the correctness as I'm unfamiliar with the format.

Thanks! Based on the git history of the other two natvis files being referenced above, I'll add Mike Spertus.

kile added a reviewer: mspertus.Oct 19 2020, 9:34 AM

Since this has no impact on anyone I think we can just commit it. Anyone else want to comment on the change?

SGTM

This revision is now accepted and ready to land.Oct 23 2020, 12:04 PM

Closed by commit rGf98bb414f58e: Add a mlir natvis file for debugging with Visual Studio (authored by kile, committed by asmith). · Explain WhyOct 23 2020, 2:15 PM

This revision was automatically updated to reflect the committed changes.

asmith added a commit: rGf98bb414f58e: Add a mlir natvis file for debugging with Visual Studio.

Revision Contents

Path

Size

mlir/

utils/

MLIRVisualizers/

mlir.natvis

35 lines

Diff 298776

mlir/utils/MLIRVisualizers/mlir.natvis

This file was added.

				<?xml version="1.0" encoding="utf-8"?>
				<AutoVisualizer xmlns="http://schemas.microsoft.com/vstudio/debugger/natvis/2010">
				<Type Name="mlir::detail::StorageUserBase<*>">
				<!--handles mlir::Type-->
				<DisplayString>{"$T3"}</DisplayString>
				<Expand>
				<ExpandedItem>($T3*)impl</ExpandedItem>
				</Expand>
				</Type>

				<Type Name="mlir::Value">
				<DisplayString>{ownerAndKind}</DisplayString>
				<Expand>
				<Item Name="OpResult" Condition=
				"((ownerAndKind.Value >> ImplType::InfoTy::IntShift) & ImplType::InfoTy::IntMask) < mlir::Value::Kind::TrailingOpResult">
				(Operation*)(ImplType::InfoTy::PointerBitMask & ownerAndKind.Value)
				</Item>
				<Item Name="TrailingOpResult" Condition=
				"((ownerAndKind.Value >> ImplType::InfoTy::IntShift) & ImplType::InfoTy::IntMask) == mlir::Value::Kind::TrailingOpResult">
				(detail::TrailingOpResult*)(ImplType::InfoTy::PointerBitMask & ownerAndKind.Value)
				</Item>
				<Item Name="BlockArgument" Condition=
				"((ownerAndKind.Value >> ImplType::InfoTy::IntShift) & ImplType::InfoTy::IntMask) == mlir::Value::Kind::BlockArgument">
				(detail::BlockArgumentImpl*)(ImplType::InfoTy::PointerBitMask & ownerAndKind.Value)
				</Item>
				<Item Name="ownerAndKind">ownerAndKind</Item>
				</Expand>
				</Type>

				<Type Name="mlir::Location">
				<Expand>
				<ExpandedItem >(LocationAttr)impl</ExpandedItem>
				</Expand>
				</Type>
				</AutoVisualizer>