Page MenuHomePhabricator

mspertus (Mike Spertus)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 11 2015, 9:59 AM (213 w, 2 d)

Recent Activity

Aug 6 2019

mspertus committed rG49068a054bda: Improve MSVC visualizations so the parser shows where we are in the code (authored by mspertus).
Improve MSVC visualizations so the parser shows where we are in the code
Aug 6 2019, 6:32 AM

Jul 13 2019

mspertus committed rGf6ce7ddecbc5: Template-related improvements to Visual Studio visualizers (authored by mspertus).
Template-related improvements to Visual Studio visualizers
Jul 13 2019, 8:29 AM

Jul 5 2019

mspertus committed rGcf45cb0b9d48: Improve MSVC visualization of annot_template_id tokens (authored by mspertus).
Improve MSVC visualization of annot_template_id tokens
Jul 5 2019, 2:44 PM

Jun 30 2019

mspertus committed rGfb133b0aabec: Various tweaks to MSVC natvis visualizers (authored by mspertus).
Various tweaks to MSVC natvis visualizers
Jun 30 2019, 11:40 PM
mspertus committed rGbb0b44deaab4: Clean up MSVC visualization of LLVM pointer types (authored by mspertus).
Clean up MSVC visualization of LLVM pointer types
Jun 30 2019, 11:40 PM

Jun 22 2019

mspertus committed rG08c699a1105b: MSVC visualizers for type aliases (authored by mspertus).
MSVC visualizers for type aliases
Jun 22 2019, 6:17 PM
mspertus committed rGd050479be519: Natural MSVC visualization of constructors (authored by mspertus).
Natural MSVC visualization of constructors
Jun 22 2019, 11:58 AM

Jun 17 2019

mspertus committed rG1f50697abc7d: Various improvements to Clang MSVC Visualizer (authored by mspertus).
Various improvements to Clang MSVC Visualizer
Jun 17 2019, 9:11 AM

Jun 7 2019

mspertus created D63039: Various improvements to Clang MSVC Visualizers.
Jun 7 2019, 6:04 PM · Restricted Project, Restricted Project
mspertus committed rGb359596d5ae0: Visualizer for APInt and remove obsolete visualizer (authored by mspertus).
Visualizer for APInt and remove obsolete visualizer
Jun 7 2019, 5:21 PM

Jun 2 2019

mspertus committed rG2d59bab568fe: Update MSVC Visualizer to reflect new variadic PointerUnion (authored by mspertus).
Update MSVC Visualizer to reflect new variadic PointerUnion
Jun 2 2019, 4:32 PM

Jan 1 2019

mspertus updated the diff for D56186: Fix MSVC PointerUnion visualization.

Improve PointerUnion expansion to show what type it holds

Jan 1 2019, 11:39 AM
mspertus created D56186: Fix MSVC PointerUnion visualization.
Jan 1 2019, 9:20 AM

Jun 12 2016

mspertus closed D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl.

revision 272525

Jun 12 2016, 7:01 PM
mspertus accepted D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl.

No adverse (or otherwise) comments received, so committing as revision 272525

Jun 12 2016, 6:50 PM

Jun 10 2016

mspertus retitled D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl from to Improved Visual Studio 2015 visualization of SmallVectorImpl.
Jun 10 2016, 7:57 PM

Mar 28 2016

mspertus closed D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

Closing diff after commit

Mar 28 2016, 11:09 AM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

Commited as revision 264603

Mar 28 2016, 11:09 AM
mspertus closed D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Committed as revisions 264601 and 264602

Mar 28 2016, 11:05 AM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

This is still showing as "Needs review" Are there any further changes required or can someone accept it? I installed both VS2015 and VS2013 on my laptop and saw the correct solution files built by cmake.

Mar 28 2016, 10:52 AM

Mar 27 2016

mspertus updated the diff for D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Adding missing period in comment!

Mar 27 2016, 6:21 PM
mspertus updated the diff for D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

Incorporating ariccio's comments and fixing some html

Mar 27 2016, 6:17 PM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 6:14 PM
mspertus added inline comments to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 6:13 PM
mspertus added a comment to D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

utils/llvm.natvis is a duplicate of utils/LLVMVisualizers/llvm.natvis?

The file was moved to a more appropriate directory (Otherwise, the project files were stepping on each other).
svn mv utils/llvm.natvis utils/LLVMVisualizers/llvm.natvis

Mar 27 2016, 6:05 PM
mspertus updated the diff for D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

Now that we are generating projects for native visualizers, have it properly reflected in the directory structure

Mar 27 2016, 4:57 PM
mspertus updated the diff for D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Add missing newline

Mar 27 2016, 4:52 PM
mspertus updated the diff for D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Since this is now creating a project, we should do some housekeeping to move the files to different directories so that the build tree has an LLVMVisualizers project directory.

Mar 27 2016, 4:50 PM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

I understand your concerns, but on balance, I don't see a better course of action than what I've done. If I have some time, I'll submit a CMake change so we can eventually migrate to having CMake generate a Natvis tag, but that will take a long time to propagate, so I don't want to delay this operationally semantically equivalent change. Sound ok?

Mar 27 2016, 12:19 PM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

No. Testing shows that it works fine in the project with the <None> tag. VS2015 empirically looks at the extension.

Mar 27 2016, 12:11 PM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

I'm not sure I understand. I'm not installing anything for VS2013. You still have to manually copy into Documents\Visual Studio 2013\Visualizers. The purpose of this change is to eliminate this manual step for VS2015 by leveraging the new Natvis project support. Am I missing something?

Mar 27 2016, 11:54 AM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

What do you mean by "making both paths the same"?

Mar 27 2016, 11:23 AM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

Hmmm, I just tried adding set_source_files_properties(utils/clang.natvis LANGUAGE natvis) similar to what you suggest in http://lists.llvm.org/pipermail/llvm-dev/2016-January/093887.html, but it still produces the None tag in the .vcxproj file.

Mar 27 2016, 10:04 AM
mspertus added a comment to D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

For vs2015, the files still need to be in the project right? (In the
vcxproj with a <natvis> tag)

Mar 27 2016, 9:28 AM
mspertus updated the diff for D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up.

Apply whitespace comments from D18497 mutatis mutandis to this change

Mar 27 2016, 9:09 AM
mspertus added a comment to D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 9:05 AM
mspertus updated the diff for D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Missed one (the missing period in llvm.natvis).

Mar 27 2016, 9:04 AM
mspertus added a comment to D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 8:44 AM
mspertus updated the diff for D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Accepting Aaron's suggestions

Mar 27 2016, 8:43 AM
mspertus updated the diff for D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.

Correctly handle non-Visual Studio case (e.g., Linux)

Mar 27 2016, 8:27 AM
mspertus updated D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 1:28 AM
mspertus retitled D18498: Auto-install Clang Visual Studio visualizers for VS2015 and up from to Auto-install Clang Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 1:28 AM
mspertus retitled D18497: Auto-install LLVM Visual Studio visualizers for VS2015 and up from to Auto-install LLVM Visual Studio visualizers for VS2015 and up.
Mar 27 2016, 1:23 AM

Mar 20 2016

mspertus closed D18303: Visual Studio Visualizers for clang::FunctionDecl.

Closing accepted revision

Mar 20 2016, 1:25 PM
mspertus added a comment to D18303: Visual Studio Visualizers for clang::FunctionDecl.

Committed as revision 263915.

Mar 20 2016, 1:25 PM
mspertus closed D18299: Better visualization of clang::BuiltinType in VisualStudio.

Closing committed revision

Mar 20 2016, 1:17 PM
mspertus accepted D18299: Better visualization of clang::BuiltinType in VisualStudio.

Per Aaron, I want to close the committed diff, but I seem to need to accept it first. Further discussion as needed on mailing list

Mar 20 2016, 1:16 PM
mspertus closed D18297: Visualizer for clang::FunctionProtoType.

Closing committed revision. Further discussion as needed on mailing list

Mar 20 2016, 1:14 PM
mspertus accepted D18297: Visualizer for clang::FunctionProtoType.

Accepting revision based on Aaron's LGTM email to reviews.llvm.org.

Mar 20 2016, 1:14 PM
mspertus retitled D18303: Visual Studio Visualizers for clang::FunctionDecl from to Visual Studio Visualizers for clang::FunctionDecl.
Mar 20 2016, 9:05 AM

Mar 19 2016

mspertus retitled D18299: Better visualization of clang::BuiltinType in VisualStudio from to Better visualization of clang::BuiltinType in VisualStudio.
Mar 19 2016, 5:38 PM
mspertus added a comment to D18297: Visualizer for clang::FunctionProtoType.

Based on Aaron's agreement to conducting post-commit reviews, I've committed this as revision 263890. Please let me know if I should not have done so. (This change is a lot smaller and simpler than I feared when I commented on my roadmap in diff D18270, so I think this is a good inaugural post-commit review for me).

Mar 19 2016, 5:29 PM
mspertus retitled D18297: Visualizer for clang::FunctionProtoType from to Visualizer for clang::FunctionProtoType.
Mar 19 2016, 1:18 PM

Mar 18 2016

mspertus closed D18270: Typesafe visualization of PointerIntPairs in Visual Studio.

Committed as revision 263821.

Mar 18 2016, 1:12 PM
mspertus retitled D18270: Typesafe visualization of PointerIntPairs in Visual Studio from to Typesafe visualization of PointerIntPairs in Visual Studio.
Mar 18 2016, 10:02 AM
mspertus closed D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers.

Thanks, Aaron. Committed as revision 263794

Mar 18 2016, 9:44 AM
mspertus added a comment to D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers.

I think the code is correct as written, see response in comment

Mar 18 2016, 8:39 AM

Mar 17 2016

mspertus retitled D18261: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers from to Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers.
Mar 17 2016, 6:59 PM

Mar 16 2016

mspertus closed D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types.

Forgot to close the revision

Mar 16 2016, 1:21 PM
mspertus added a comment to D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types.

Committed as revision 263638. At Chandler's suggestion, I am going to send an announcement to cfe-dev letting people know of all of the recent improvements to native visualizers

Mar 16 2016, 7:34 AM
mspertus added inline comments to D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types.
Mar 16 2016, 7:12 AM
mspertus updated the diff for D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types.

Added reference types and a more accurate AttributedType enum. I am working on additional items for the future (class members, function types, etc.) but those will take longer, and I think it is worthwhile to get this revision committed unless there are defects in it. Agree?

Mar 16 2016, 7:08 AM

Mar 14 2016

mspertus retitled D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types from to Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types.
Mar 14 2016, 3:22 PM
mspertus closed D17908: Add Visual Studio Visualizers for more Clang types.

Committed as revision 262933

Mar 14 2016, 3:00 PM

Mar 11 2016

mspertus closed D18076: Improve Visual Studio visualizations of llvm::PointerUnion by increasing type correctness.

Committed as svn revision 263270

Mar 11 2016, 10:32 AM
mspertus updated the diff for D18076: Improve Visual Studio visualizations of llvm::PointerUnion by increasing type correctness.

Applying same logic to PointerUnion3 and PointerUnion4 as suggested by Aaron

Mar 11 2016, 7:39 AM
mspertus added a comment to D18076: Improve Visual Studio visualizations of llvm::PointerUnion by increasing type correctness.

Good catch. Give me two minutes....

Mar 11 2016, 7:33 AM

Mar 10 2016

mspertus retitled D18076: Improve Visual Studio visualizations of llvm::PointerUnion by increasing type correctness from to Improve Visual Studio visualizations of llvm::PointerUnion by increasing type correctness.
Mar 10 2016, 7:45 PM

Mar 8 2016

mspertus added a comment to D17908: Add Visual Studio Visualizers for more Clang types.

Committed, thanks!

Mar 8 2016, 8:20 AM

Mar 7 2016

mspertus updated the diff for D17908: Add Visual Studio Visualizers for more Clang types.

Based on Eric Feiveson's comment that I can suppress the numeric value of an enum visualization with ", en" I have uploaded a new diff. By suppressing the numeric values, instead of the verbose TemplateArgumentLoc visualization

Mar 7 2016, 8:38 PM
mspertus updated the diff for D17908: Add Visual Studio Visualizers for more Clang types.

Updated in response to review comments to fix issues around MSVC versions

Mar 7 2016, 6:14 PM
mspertus added a comment to D17908: Add Visual Studio Visualizers for more Clang types.

Hmm, testing reveals that the preexisting clang.natvis does not work in VS2013!

Mar 7 2016, 3:16 PM
mspertus added a comment to D17908: Add Visual Studio Visualizers for more Clang types.

I believe that it will all work on VS2013 (and have kicked off a build to confirm). I guess I would rather drop the number so it doesn't get out of sync whenever the base compiler version changes.

Mar 7 2016, 7:27 AM

Mar 5 2016

mspertus retitled D17908: Add Visual Studio Visualizers for more Clang types from to Add Visual Studio Visualizers for more Clang types.
Mar 5 2016, 8:47 AM

Sep 11 2015

mspertus added a comment to D12807: Display name of identifier tokens in Visual Studio native visualizer.

Thanks, Aaron! Hal mentioned that I might need to ask you to commit on my behalf as I don't have commit access as of now.

Sep 11 2015, 11:34 AM
mspertus retitled D12807: Display name of identifier tokens in Visual Studio native visualizer from to Display name of identifier tokens in Visual Studio native visualizer.
Sep 11 2015, 10:13 AM