Page MenuHomePhabricator

Add an mlir natvis file for debugging with Visual Studio
ClosedPublic

Authored by kile on Oct 16 2020, 4:02 PM.

Diff Detail

Event Timeline

kile created this revision.Oct 16 2020, 4:02 PM
kile requested review of this revision.Oct 16 2020, 4:02 PM

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Ah I see, that makes sense.

mehdi_amini added a comment.EditedOct 16 2020, 9:05 PM

Thanks for the contribution!

LGTM on the principle, but I can't review the correctness as I'm unfamiliar with the format.

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Ah I see, that makes sense.

I wonder if it makes sense to move all the nativs files under the llvm-project/utils/ directory?

kile added a comment.EditedOct 19 2020, 9:33 AM

Nice, to follow the naming convention of other utils folders here, how about mlir/utils/vscode/mlir.natvis ? (or s/vscode/vstudio/? I don't now who which is considered more general/common in folks minds :)).

This is following the convention of the other natvis files.
./clang/utils/ClangVisualizers/clang.natvis
./llvm/utils/LLVMVisualizers/llvm.natvis

Ah I see, that makes sense.

I wonder if it makes sense to move all the nativs files under the llvm-project/utils/ directory?

That would make sense, though I do worry about breaking devs who wouldn't be expecting their natvis files to move...ultimately up to you :)

Thanks for the contribution!

LGTM on the principle, but I can't review the correctness as I'm unfamiliar with the format.

Thanks! Based on the git history of the other two natvis files being referenced above, I'll add Mike Spertus.

Since this has no impact on anyone I think we can just commit it. Anyone else want to comment on the change?

This revision is now accepted and ready to land.Oct 23 2020, 12:04 PM
This revision was automatically updated to reflect the committed changes.