Page MenuHomePhabricator

[flang] Fix CMake bug in the definition of flang-new
ClosedPublic

Authored by awarzynski on Oct 14 2020, 9:48 AM.

Details

Summary

Recent patch that improved Flang's compatibility with respect to how LLVM
dynamic libraries should be linked (and specified in CMake recipes),
introduced a bug in the definition of flang-new:

More specifically, add_flang_tool does not support the
LINK_COMPONENTS CMake argument. Instead, one should set
LLVM_LINK_COMPONENTS before calling add_flang_tool.

This patch reverts the change for flang-new from
https://reviews.llvm.org/D87893, and instead:

  • sets LLVM_LINK_COMPONENTS
  • calls clang_target_link_libraries to add Clang dependencies

Diff Detail

Event Timeline

awarzynski created this revision.Oct 14 2020, 9:48 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Oct 14 2020, 9:48 AM

Revert accidental and unnecessary change

Harbormaster completed remote builds in B75083: Diff 298171.
This revision is now accepted and ready to land.Oct 14 2020, 10:16 AM

Thanks for fixing the bug so quickly!

This revision was automatically updated to reflect the committed changes.