[llvm] Make obj2yaml and yaml2obj LLVM utilities instead of tools

[JDevlieghere]

Summary

For testing purposes I need a way to build and install FileCheck and yaml2obj. I could either make FileCheck an LLVM tool or make obj2yaml and yaml2obj utilities. I think the distinction is rather arbitrary but my understanding is that tools are things meant for the toolchain while utilities are more used for things like testing, which is the case here. The functional difference is that they'll end up in the ${LLVM_UTILS_INSTALL_DIR} which defaults to the ${LLVM_TOOLS_INSTALL_DIR}. Unless you specify a different value or you added obj2yaml and yaml2obj to LLVM_TOOLCHAIN_TOOLS this change should make no difference.

Another option would be to get rid of this distinction altogether and just have tools. This would simplify the CMake logic but would mean you could no longer specify a separate ${LLVM_UTILS_INSTALL_DIR}.

[labath]

I don't have a problem with this, but I don't really know what this implies. Adding some folks who package llvm downstream.

[JDevlieghere]

ping

[compnerd]

I know that many people find these tools useful, but they are meant as testing tools. Marking them as utilities seems reasonable.

[jhenderson]

FWIW, this had an impact on the Visual Studio IDE, as "Tools" and "Utils" are separate solution folders, so yaml2obj and obj2yaml appear in a different location now to where they did before. From a functional point of view, it doesn't really matter (and I agree with your logic), it just caught me off guard when I was looking to build yaml2obj via the UI. Another "Tool" that in my opinion should be a utility is "split-file", but @MaskRay disagreed with me on that one, I think.

llvm/tools/obj2yaml/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   BinaryFormat
   DebugInfoCodeView
   DebugInfoDWARF
   Object
   ObjectYAML
   Support
   )
 
-add_llvm_tool(obj2yaml
+add_llvm_utility(obj2yaml
   obj2yaml.cpp
   coff2yaml.cpp
   dwarf2yaml.cpp
   elf2yaml.cpp
   macho2yaml.cpp
   minidump2yaml.cpp
   xcoff2yaml.cpp
   wasm2yaml.cpp
   )

llvm/tools/yaml2obj/CMakeLists.txt

 set(LLVM_LINK_COMPONENTS
   ObjectYAML
   Support
   )
 
-add_llvm_tool(yaml2obj
+add_llvm_utility(yaml2obj
   yaml2obj.cpp
   )